You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by "Geoffrey Jacoby (Jira)" <ji...@apache.org> on 2020/05/04 20:26:00 UTC

[jira] [Commented] (PHOENIX-5881) Port MaxLookbackAge logic to 5.x

    [ https://issues.apache.org/jira/browse/PHOENIX-5881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17099331#comment-17099331 ] 

Geoffrey Jacoby commented on PHOENIX-5881:
------------------------------------------

The max lookback logic depends upon coproc overrides in preCompactScannerOpen, preFlushScannerOpen, and preStoreScannerOpen, which have changed enough in HBase 2.0 and above that the 1.x logic cannot be ported to it. I filed HBASE-24321 to add missing information to the new hooks, but this will only work for HBase 2.3 and up, and so this JIRA can't be worked until after 2.3 gets released upstream. (And even then, we'll need a compatibility shim since 2.0, 2.1, and 2.2 can't be given HBASE-24321 due to HBase compatibility guidelines.) 

> Port MaxLookbackAge logic to 5.x
> --------------------------------
>
>                 Key: PHOENIX-5881
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5881
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Geoffrey Jacoby
>            Assignee: Geoffrey Jacoby
>            Priority: Major
>
> PHOENIX-5645 wasn't included in the master (5.x) branch because an HBase 2.x change prevented the logic from being useful in the case of deletes, since HBase 2.x no longer allows us to show deleted cells on an SCN query before the point of deletion. Unfortunately, PHOENIX-5645 wound up requiring a lot of follow-up work in the IndexTool and IndexScrutinyTool to deal with its implications, and because of that, the 4.x and 5.x codebases around indexes have diverged a good bit. 
> This work item is to get them back in sync, even though the behavior in the face of deletes will be somewhat different, and so most likely some tests will have to be changed or Ignored. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)