You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2022/08/02 22:29:22 UTC
[GitHub] [accumulo] cshannon opened a new pull request, #2842: Renaming ZooStore get/set property methods to get/set nodeData
cshannon opened a new pull request, #2842:
URL: https://github.com/apache/accumulo/pull/2842
Also using a new enum type for the node names instead of String values.
This closes #2841
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] cshannon commented on pull request #2842: Renaming ZooStore get/set property methods to get/set transactionInfo
Posted by GitBox <gi...@apache.org>.
cshannon commented on PR #2842:
URL: https://github.com/apache/accumulo/pull/2842#issuecomment-1207240910
@EdColeman and @dlmarion - I updated my PR with a new commit to address the comments. I renamed the enum to TxInfo and the methods. Also another change is `the` enum name is used as is now when storing data into ZK which is all caps instead of lower case (this can be changed of course but seems ok to me).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] EdColeman commented on a diff in pull request #2842: Renaming ZooStore get/set property methods to get/set nodeData
Posted by GitBox <gi...@apache.org>.
EdColeman commented on code in PR #2842:
URL: https://github.com/apache/accumulo/pull/2842#discussion_r936092505
##########
core/src/main/java/org/apache/accumulo/core/logging/FateLogger.java:
##########
@@ -80,8 +81,8 @@ public TStatus waitForStatusChange(long tid, EnumSet<TStatus> expected) {
}
@Override
- public Serializable getProperty(long tid, String prop) {
- return store.getProperty(tid, prop);
+ public Serializable getNodeData(long tid, Fate.NodeData prop) {
Review Comment:
Or `nodeData` as used elsewhere
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] dlmarion commented on a diff in pull request #2842: Renaming ZooStore get/set property methods to get/set nodeData
Posted by GitBox <gi...@apache.org>.
dlmarion commented on code in PR #2842:
URL: https://github.com/apache/accumulo/pull/2842#discussion_r936745410
##########
core/src/main/java/org/apache/accumulo/fate/Fate.java:
##########
@@ -70,6 +65,29 @@
private final AtomicBoolean keepRunning = new AtomicBoolean(true);
+ public enum NodeData {
+
+ TARGET_NODE("target_node"),
Review Comment:
@cshannon - @EdColeman and I talked offline and we settled on the following structure for the enum:
```
TxInfo {
REPO_TARGET, EXCEPTION, RETURN_VALUE, AUTO_CLEAN
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] cshannon commented on pull request #2842: Renaming ZooStore get/set property methods to get/set nodeData
Posted by GitBox <gi...@apache.org>.
cshannon commented on PR #2842:
URL: https://github.com/apache/accumulo/pull/2842#issuecomment-1203297685
@EdColeman - Thanks for the quick review, I'll look at making these changes when I get some time later this week either tomorrow or this weekend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] dlmarion commented on pull request #2842: Renaming ZooStore get/set property methods to get/set transactionInfo
Posted by GitBox <gi...@apache.org>.
dlmarion commented on PR #2842:
URL: https://github.com/apache/accumulo/pull/2842#issuecomment-1213331804
Full IT build passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime merged pull request #2842: Renaming ZooStore get/set property methods to get/set transactionInfo
Posted by GitBox <gi...@apache.org>.
milleruntime merged PR #2842:
URL: https://github.com/apache/accumulo/pull/2842
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] EdColeman commented on a diff in pull request #2842: Renaming ZooStore get/set property methods to get/set nodeData
Posted by GitBox <gi...@apache.org>.
EdColeman commented on code in PR #2842:
URL: https://github.com/apache/accumulo/pull/2842#discussion_r936597259
##########
core/src/main/java/org/apache/accumulo/fate/Fate.java:
##########
@@ -70,6 +65,29 @@
private final AtomicBoolean keepRunning = new AtomicBoolean(true);
+ public enum NodeData {
+
+ TARGET_NODE("target_node"),
Review Comment:
Without `_node` the exception and return nodes seem like the should have some decoration. The `target` (formally prop_debug) is the classname of the REPO that is the "head" of the transaction (the "tail" of the stack) - the REPO that starts things, but can have sub-steps. The distinction of that "name" should be reflected in the code. Things like repoHeadName seem awkward. To contrast with top that is the currently executing transaction, tail - but then that requires a deep understanding of the stack nature of REPO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] EdColeman commented on a diff in pull request #2842: Renaming ZooStore get/set property methods to get/set nodeData
Posted by GitBox <gi...@apache.org>.
EdColeman commented on code in PR #2842:
URL: https://github.com/apache/accumulo/pull/2842#discussion_r936083870
##########
core/src/main/java/org/apache/accumulo/core/logging/FateLogger.java:
##########
@@ -80,8 +81,8 @@ public TStatus waitForStatusChange(long tid, EnumSet<TStatus> expected) {
}
@Override
- public Serializable getProperty(long tid, String prop) {
- return store.getProperty(tid, prop);
+ public Serializable getNodeData(long tid, Fate.NodeData prop) {
Review Comment:
Maybe `node` or `data` instead of prop?
##########
core/src/main/java/org/apache/accumulo/fate/AdminUtil.java:
##########
@@ -364,7 +364,7 @@ private FateStatus getTransactionStatus(ReadOnlyTStore<T> zs, Set<Long> filterTx
zs.reserve(tid);
- String debug = (String) zs.getProperty(tid, Fate.DEBUG_PROP);
+ String debug = (String) zs.getNodeData(tid, Fate.NodeData.TARGET_NODE);
Review Comment:
Would `TARGET_DESC_NODE` indicate that it is information and not the "target repo" itself?
##########
core/src/main/java/org/apache/accumulo/fate/ReadOnlyStore.java:
##########
@@ -103,8 +103,8 @@ public TStatus waitForStatusChange(long tid, EnumSet<TStatus> expected) {
}
@Override
- public Serializable getProperty(long tid, String prop) {
- return store.getProperty(tid, prop);
+ public Serializable getNodeData(long tid, Fate.NodeData prop) {
Review Comment:
`nodeData` instead of `prop` ?
##########
core/src/main/java/org/apache/accumulo/fate/ReadOnlyTStore.java:
##########
@@ -132,7 +132,7 @@ enum TStatus {
* @param prop
* name of property to retrieve.
*/
- Serializable getProperty(long tid, String prop);
+ Serializable getNodeData(long tid, Fate.NodeData prop);
Review Comment:
`nodeData` instead of `prop` ?
##########
core/src/main/java/org/apache/accumulo/fate/Fate.java:
##########
@@ -70,6 +65,29 @@
private final AtomicBoolean keepRunning = new AtomicBoolean(true);
+ public enum NodeData {
+
+ TARGET_NODE("target_node"),
Review Comment:
`target_desc_node` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] dlmarion commented on a diff in pull request #2842: Renaming ZooStore get/set property methods to get/set nodeData
Posted by GitBox <gi...@apache.org>.
dlmarion commented on code in PR #2842:
URL: https://github.com/apache/accumulo/pull/2842#discussion_r936563784
##########
core/src/main/java/org/apache/accumulo/fate/Fate.java:
##########
@@ -70,6 +65,29 @@
private final AtomicBoolean keepRunning = new AtomicBoolean(true);
+ public enum NodeData {
Review Comment:
This enum contains members whose names correspond to the attributes of an instance of a Fate transaction. When storing or accessing these attributes you have to supply the Fate transaction id. I would be more inclined to support a name like `TransactionData`, `TxData`, or something like that. I think the word "node" is coming from the fact that the data is stored in a ZK node. The name isn't really descriptive to someone looking at this code that doesn't know the inner workings of the persistence.
##########
core/src/main/java/org/apache/accumulo/core/logging/FateLogger.java:
##########
@@ -80,8 +81,8 @@ public TStatus waitForStatusChange(long tid, EnumSet<TStatus> expected) {
}
@Override
- public Serializable getProperty(long tid, String prop) {
- return store.getProperty(tid, prop);
+ public Serializable getNodeData(long tid, Fate.NodeData prop) {
Review Comment:
`getTransactionData`, `getTransactionInfo`? See my comment for `Fate.NodeData`.
##########
core/src/main/java/org/apache/accumulo/fate/Fate.java:
##########
@@ -70,6 +65,29 @@
private final AtomicBoolean keepRunning = new AtomicBoolean(true);
+ public enum NodeData {
+
+ TARGET_NODE("target_node"),
Review Comment:
I think we can remove `_node` from all of the enum names. Also, I would support renaming `Repo.getDescription` to `Repo.getName` or `Repo.getClassName` as the class name is only ever used. Then, instead of using `target` here, I would just use `name`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] cshannon commented on pull request #2842: Renaming ZooStore get/set property methods to get/set nodeData
Posted by GitBox <gi...@apache.org>.
cshannon commented on PR #2842:
URL: https://github.com/apache/accumulo/pull/2842#issuecomment-1203277106
@EdColeman - Here is my first attempt at renaming the methods and using an enum. Per our discussion offline I renamed the "debug" property to "target" as it's a better description of what it is. Obviously any of those names can be changed or tweaked based on what people think. I didn't add any new tests as I figure the existing Fate tests should catch any issues with the ZooStore and refactoring.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] dlmarion commented on a diff in pull request #2842: Renaming ZooStore get/set property methods to get/set transactionInfo
Posted by GitBox <gi...@apache.org>.
dlmarion commented on code in PR #2842:
URL: https://github.com/apache/accumulo/pull/2842#discussion_r958860875
##########
core/src/main/java/org/apache/accumulo/fate/Fate.java:
##########
@@ -70,6 +65,29 @@
private final AtomicBoolean keepRunning = new AtomicBoolean(true);
+ public enum NodeData {
+
+ TARGET_NODE("target_node"),
Review Comment:
In the comment thread above, `name` and `repoName` were both suggested. I don't remember how we ended up at repoTarget.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] cshannon commented on pull request #2842: Renaming ZooStore get/set property methods to get/set transactionInfo
Posted by GitBox <gi...@apache.org>.
cshannon commented on PR #2842:
URL: https://github.com/apache/accumulo/pull/2842#issuecomment-1212361352
> Looks good but there were a few references to old name (property) still hanging around in the javadoc.
Thanks, I can fix those tomorrow morning and then we can hopefully get this merged in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime commented on a diff in pull request #2842: Renaming ZooStore get/set property methods to get/set transactionInfo
Posted by GitBox <gi...@apache.org>.
milleruntime commented on code in PR #2842:
URL: https://github.com/apache/accumulo/pull/2842#discussion_r958795964
##########
core/src/main/java/org/apache/accumulo/fate/Fate.java:
##########
@@ -70,6 +65,29 @@
private final AtomicBoolean keepRunning = new AtomicBoolean(true);
+ public enum NodeData {
+
+ TARGET_NODE("target_node"),
Review Comment:
Did you guys mean for the first value in the Enum to be "REPO_NAME" instead? While working on the new Fate API, I came to parts of the code using the field and I found that the term "target" doesn't make sense. https://github.com/apache/accumulo/blob/e08287065d3af4773dd97a3991686abc3002f6dd/core/src/main/java/org/apache/accumulo/fate/Fate.java#L303
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] cshannon commented on pull request #2842: Renaming ZooStore get/set property methods to get/set transactionInfo
Posted by GitBox <gi...@apache.org>.
cshannon commented on PR #2842:
URL: https://github.com/apache/accumulo/pull/2842#issuecomment-1213014535
@milleruntime - Ok I added a new commit to fix the Javadoc and enum. This should be ready to merged into main I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime commented on a diff in pull request #2842: Renaming ZooStore get/set property methods to get/set transactionInfo
Posted by GitBox <gi...@apache.org>.
milleruntime commented on code in PR #2842:
URL: https://github.com/apache/accumulo/pull/2842#discussion_r958857738
##########
core/src/main/java/org/apache/accumulo/fate/Fate.java:
##########
@@ -70,6 +65,29 @@
private final AtomicBoolean keepRunning = new AtomicBoolean(true);
+ public enum NodeData {
+
+ TARGET_NODE("target_node"),
Review Comment:
The description [here](https://github.com/apache/accumulo/blob/e08287065d3af4773dd97a3991686abc3002f6dd/core/src/main/java/org/apache/accumulo/fate/AdminUtil.java#L108) made me scratch my head. When we print out the value on the CLI, its just referred to as "op", meaning the name of the current operation. https://github.com/apache/accumulo/blob/e08287065d3af4773dd97a3991686abc3002f6dd/core/src/main/java/org/apache/accumulo/fate/AdminUtil.java#L421-L425
Here is a Fate Tx printed for a compaction:
<pre>
txid: 2d4b1f3195963320 status: IN_PROGRESS op: CompactRange locked: [R:+default, R:1] locking: [] top: CompactionDriver created: 2022-08-30T19:30:00.06Z
</pre>
So "CompactRange" is really just the name of the current operation running for the Tx.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime commented on a diff in pull request #2842: Renaming ZooStore get/set property methods to get/set transactionInfo
Posted by GitBox <gi...@apache.org>.
milleruntime commented on code in PR #2842:
URL: https://github.com/apache/accumulo/pull/2842#discussion_r958870342
##########
core/src/main/java/org/apache/accumulo/fate/Fate.java:
##########
@@ -70,6 +65,29 @@
private final AtomicBoolean keepRunning = new AtomicBoolean(true);
+ public enum NodeData {
+
+ TARGET_NODE("target_node"),
Review Comment:
I made a fix in #2904
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] dlmarion commented on pull request #2842: Renaming ZooStore get/set property methods to get/set transactionInfo
Posted by GitBox <gi...@apache.org>.
dlmarion commented on PR #2842:
URL: https://github.com/apache/accumulo/pull/2842#issuecomment-1213078158
I'm going to kick off a Full IT build as a sanity check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] dlmarion commented on a diff in pull request #2842: Renaming ZooStore get/set property methods to get/set nodeData
Posted by GitBox <gi...@apache.org>.
dlmarion commented on code in PR #2842:
URL: https://github.com/apache/accumulo/pull/2842#discussion_r936608327
##########
core/src/main/java/org/apache/accumulo/fate/Fate.java:
##########
@@ -70,6 +65,29 @@
private final AtomicBoolean keepRunning = new AtomicBoolean(true);
+ public enum NodeData {
+
+ TARGET_NODE("target_node"),
Review Comment:
If you take my comment about `Fate.NodeData` into account and rename the enum, then you would end up with something like:
```
enum TxInfo {
NAME, EXCEPTION, RETURN, AUTO_CLEAN;
}
```
> Without _node the exception and return nodes seem like the should have some decoration.
I think `TxInfo.EXCEPTION` is pretty clear. Maybe `TxInfo.RETURN_VALUE` is a little more clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] EdColeman commented on a diff in pull request #2842: Renaming ZooStore get/set property methods to get/set nodeData
Posted by GitBox <gi...@apache.org>.
EdColeman commented on code in PR #2842:
URL: https://github.com/apache/accumulo/pull/2842#discussion_r936615454
##########
core/src/main/java/org/apache/accumulo/fate/Fate.java:
##########
@@ -70,6 +65,29 @@
private final AtomicBoolean keepRunning = new AtomicBoolean(true);
+ public enum NodeData {
+
+ TARGET_NODE("target_node"),
Review Comment:
Both `TxInfo.EXCEPTION` and `TxInfo.RETURN_VALUE` seem good. `NAME` feels to generic - what about `TxInfo.REPO_NAME`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] EdColeman commented on a diff in pull request #2842: Renaming ZooStore get/set property methods to get/set nodeData
Posted by GitBox <gi...@apache.org>.
EdColeman commented on code in PR #2842:
URL: https://github.com/apache/accumulo/pull/2842#discussion_r936617486
##########
core/src/main/java/org/apache/accumulo/fate/Fate.java:
##########
@@ -70,6 +65,29 @@
private final AtomicBoolean keepRunning = new AtomicBoolean(true);
+ public enum NodeData {
Review Comment:
`TxData` is nice and short and provides context and may be an improvement over node
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] dlmarion commented on a diff in pull request #2842: Renaming ZooStore get/set property methods to get/set nodeData
Posted by GitBox <gi...@apache.org>.
dlmarion commented on code in PR #2842:
URL: https://github.com/apache/accumulo/pull/2842#discussion_r936617622
##########
core/src/main/java/org/apache/accumulo/fate/Fate.java:
##########
@@ -70,6 +65,29 @@
private final AtomicBoolean keepRunning = new AtomicBoolean(true);
+ public enum NodeData {
+
+ TARGET_NODE("target_node"),
Review Comment:
> what about TxInfo.REPO_NAME
Sure, IMO better than `target` and `debug`. I would still suggest renaming `Repo.getDescription`, maybe in this case to `Repo.getName`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime commented on a diff in pull request #2842: Renaming ZooStore get/set property methods to get/set transactionInfo
Posted by GitBox <gi...@apache.org>.
milleruntime commented on code in PR #2842:
URL: https://github.com/apache/accumulo/pull/2842#discussion_r943806151
##########
core/src/main/java/org/apache/accumulo/fate/Fate.java:
##########
@@ -71,6 +66,10 @@
private final AtomicBoolean keepRunning = new AtomicBoolean(true);
+ public enum TxInfo {
+ REPO_TARGET, AUTO_CLEAN, EXCEPTION, RETURN_VALUE;
Review Comment:
```suggestion
REPO_TARGET, AUTO_CLEAN, EXCEPTION, RETURN_VALUE
```
##########
core/src/main/java/org/apache/accumulo/fate/ReadOnlyTStore.java:
##########
@@ -129,10 +129,10 @@ enum TStatus {
*
* @param tid
* transaction id, previously reserved.
- * @param prop
- * name of property to retrieve.
+ * @param txInfo
+ * name of attribute of a transaction to retrieve.
Review Comment:
Javadoc above still refers to "property"
##########
core/src/main/java/org/apache/accumulo/fate/TStore.java:
##########
@@ -65,7 +65,17 @@
*/
void setStatus(long tid, TStatus status);
- void setProperty(long tid, String prop, Serializable val);
+ /**
+ * Set a transaction-specific property.
Review Comment:
```suggestion
* Set transaction-specific information.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org