You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@syncope.apache.org by re...@apache.org on 2012/05/04 15:14:01 UTC
svn commit: r1333937 - in /incubator/syncope/trunk:
console/src/main/java/org/apache/syncope/console/pages/
console/src/main/java/org/apache/syncope/console/wicket/markup/html/form/
core/src/main/java/org/apache/syncope/core/init/
Author: rene
Date: Fri May 4 13:14:00 2012
New Revision: 1333937
URL: http://svn.apache.org/viewvc?rev=1333937&view=rev
Log:
sonar: add checks before casting parameters
Modified:
incubator/syncope/trunk/console/src/main/java/org/apache/syncope/console/pages/NotificationTaskModalPage.java
incubator/syncope/trunk/console/src/main/java/org/apache/syncope/console/wicket/markup/html/form/AjaxCheckBoxPanel.java
incubator/syncope/trunk/console/src/main/java/org/apache/syncope/console/wicket/markup/html/form/MultiValueSelectorPanel.java
incubator/syncope/trunk/core/src/main/java/org/apache/syncope/core/init/JobInstanceLoader.java
Modified: incubator/syncope/trunk/console/src/main/java/org/apache/syncope/console/pages/NotificationTaskModalPage.java
URL: http://svn.apache.org/viewvc/incubator/syncope/trunk/console/src/main/java/org/apache/syncope/console/pages/NotificationTaskModalPage.java?rev=1333937&r1=1333936&r2=1333937&view=diff
==============================================================================
--- incubator/syncope/trunk/console/src/main/java/org/apache/syncope/console/pages/NotificationTaskModalPage.java (original)
+++ incubator/syncope/trunk/console/src/main/java/org/apache/syncope/console/pages/NotificationTaskModalPage.java Fri May 4 13:14:00 2012
@@ -38,11 +38,13 @@ public class NotificationTaskModalPage e
sender.setEnabled(false);
profile.add(sender);
- final ListMultipleChoice<String> recipients = new ListMultipleChoice<String>("recipients",
- new ArrayList<String>(((NotificationTaskTO) taskTO).getRecipients()));
- recipients.setMaxRows(5);
- recipients.setEnabled(false);
- profile.add(recipients);
+ if (taskTO instanceof NotificationTaskTO) {
+ final ListMultipleChoice<String> recipients = new ListMultipleChoice<String>("recipients",
+ new ArrayList<String>(((NotificationTaskTO) taskTO).getRecipients()));
+ recipients.setMaxRows(5);
+ recipients.setEnabled(false);
+ profile.add(recipients);
+ }
final AjaxTextFieldPanel subject = new AjaxTextFieldPanel("subject", getString("subject"),
new PropertyModel<String>(taskTO, "subject"));
Modified: incubator/syncope/trunk/console/src/main/java/org/apache/syncope/console/wicket/markup/html/form/AjaxCheckBoxPanel.java
URL: http://svn.apache.org/viewvc/incubator/syncope/trunk/console/src/main/java/org/apache/syncope/console/wicket/markup/html/form/AjaxCheckBoxPanel.java?rev=1333937&r1=1333936&r2=1333937&view=diff
==============================================================================
--- incubator/syncope/trunk/console/src/main/java/org/apache/syncope/console/wicket/markup/html/form/AjaxCheckBoxPanel.java (original)
+++ incubator/syncope/trunk/console/src/main/java/org/apache/syncope/console/wicket/markup/html/form/AjaxCheckBoxPanel.java Fri May 4 13:14:00 2012
@@ -82,7 +82,7 @@ public class AjaxCheckBoxPanel extends F
@Override
public void setObject(final Serializable object) {
- if (object != null) {
+ if (object != null && object instanceof Boolean) {
list.clear();
list.add(((Boolean) object).toString());
}
Modified: incubator/syncope/trunk/console/src/main/java/org/apache/syncope/console/wicket/markup/html/form/MultiValueSelectorPanel.java
URL: http://svn.apache.org/viewvc/incubator/syncope/trunk/console/src/main/java/org/apache/syncope/console/wicket/markup/html/form/MultiValueSelectorPanel.java?rev=1333937&r1=1333936&r2=1333937&view=diff
==============================================================================
--- incubator/syncope/trunk/console/src/main/java/org/apache/syncope/console/wicket/markup/html/form/MultiValueSelectorPanel.java (original)
+++ incubator/syncope/trunk/console/src/main/java/org/apache/syncope/console/wicket/markup/html/form/MultiValueSelectorPanel.java Fri May 4 13:14:00 2012
@@ -146,6 +146,9 @@ public class MultiValueSelectorPanel<E>
@Override
public MultiValueSelectorPanel<E> setModelObject(Serializable object) {
+ if (!(object instanceof List)) {
+ throw new ClassCastException("object is expected to be List: " + object.getClass().getName());
+ }
view.setModelObject((List<E>) object);
return this;
}
Modified: incubator/syncope/trunk/core/src/main/java/org/apache/syncope/core/init/JobInstanceLoader.java
URL: http://svn.apache.org/viewvc/incubator/syncope/trunk/core/src/main/java/org/apache/syncope/core/init/JobInstanceLoader.java?rev=1333937&r1=1333936&r2=1333937&view=diff
==============================================================================
--- incubator/syncope/trunk/core/src/main/java/org/apache/syncope/core/init/JobInstanceLoader.java (original)
+++ incubator/syncope/trunk/core/src/main/java/org/apache/syncope/core/init/JobInstanceLoader.java Fri May 4 13:14:00 2012
@@ -142,7 +142,7 @@ public class JobInstanceLoader {
if (jobInstance instanceof AbstractTaskJob) {
((AbstractTaskJob) jobInstance).setTaskId(task.getId());
}
- if (jobInstance instanceof SyncJob) {
+ if (jobInstance instanceof SyncJob && task instanceof SyncTask) {
String jobActionsClassName = ((SyncTask) task).getJobActionsClassName();
Class syncJobActionsClass = DefaultSyncJobActions.class;
if (StringUtils.isNotBlank(jobActionsClassName)) {