You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Tim Anderegg <ti...@gmail.com> on 2016/04/21 03:57:08 UTC
Review Request 46469: Added support for credentials to mesos-execute.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46469/
-----------------------------------------------------------
Review request for mesos.
Bugs: MESOS-3402
https://issues.apache.org/jira/browse/MESOS-3402
Repository: mesos
Description
-------
Added support for credentials to mesos-execute.
Diffs
-----
src/cli/execute.cpp 087a73143d739f41638b8335c7e24dfcd14bc7fb
Diff: https://reviews.apache.org/r/46469/diff/
Testing
-------
$ ./mesos-execute --master=127.0.0.1:5050 --name=auth_test --command="while true; do echo 'Hello'; sleep 2; done"
I0420 21:55:11.347501 2751 scheduler.cpp:177] Version: 0.29.0
Received an ERROR event: Received unexpected '401 Unauthorized' () for SUBSCRIBE
$ ./mesos-execute --master=127.0.0.1:5050 --name=auth_test --command="while true; do echo 'Hello'; sleep 2; done" --principal=principal --secret=secret
I0420 21:54:02.924027 2587 scheduler.cpp:177] Version: 0.29.0
Subscribed with ID '81fe5703-ccae-4c6e-8e39-a246109d812e-0001'
Submitted task 'auth_test' to agent '9edb64fe-5b97-43d3-81fe-81f0cdcea0b4-S0'
Received status update TASK_RUNNING for task 'auth_test'
source: SOURCE_EXECUTOR
Thanks,
Tim Anderegg
Re: Review Request 46469: Added support for credentials to
mesos-execute.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46469/#review129852
-----------------------------------------------------------
Bad review!
Reviews applied: []
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos ReviewBot
On April 21, 2016, 1:57 a.m., Tim Anderegg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46469/
> -----------------------------------------------------------
>
> (Updated April 21, 2016, 1:57 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-3402
> https://issues.apache.org/jira/browse/MESOS-3402
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added support for credentials to mesos-execute.
>
>
> Diffs
> -----
>
> src/cli/execute.cpp 087a73143d739f41638b8335c7e24dfcd14bc7fb
>
> Diff: https://reviews.apache.org/r/46469/diff/
>
>
> Testing
> -------
>
> $ ./mesos-execute --master=127.0.0.1:5050 --name=auth_test --command="while true; do echo 'Hello'; sleep 2; done"
> I0420 21:55:11.347501 2751 scheduler.cpp:177] Version: 0.29.0
> Received an ERROR event: Received unexpected '401 Unauthorized' () for SUBSCRIBE
>
> $ ./mesos-execute --master=127.0.0.1:5050 --name=auth_test --command="while true; do echo 'Hello'; sleep 2; done" --principal=principal --secret=secret
> I0420 21:54:02.924027 2587 scheduler.cpp:177] Version: 0.29.0
> Subscribed with ID '81fe5703-ccae-4c6e-8e39-a246109d812e-0001'
> Submitted task 'auth_test' to agent '9edb64fe-5b97-43d3-81fe-81f0cdcea0b4-S0'
> Received status update TASK_RUNNING for task 'auth_test'
> source: SOURCE_EXECUTOR
>
>
> Thanks,
>
> Tim Anderegg
>
>
Re: Review Request 46469: Added support for credentials to
mesos-execute.
Posted by Tim Anderegg <ti...@gmail.com>.
> On April 22, 2016, 1:19 a.m., Vinod Kone wrote:
> > src/cli/execute.cpp, line 754
> > <https://reviews.apache.org/r/46469/diff/1/?file=1354332#file1354332line754>
> >
> > I think it is ok to set principal and not secret. We should just set the framework info principal in that case.
> >
> > also, s/cred/credential_/
Thanks for reviewing Vinod! I'll make the change shortly. I think authentication requires both, but I agree there may be some cases where folks would want to set the principal even when not using authentication.
- Tim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46469/#review130012
-----------------------------------------------------------
On April 22, 2016, 1:20 a.m., Tim Anderegg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46469/
> -----------------------------------------------------------
>
> (Updated April 22, 2016, 1:20 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-3402
> https://issues.apache.org/jira/browse/MESOS-3402
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added support for credentials to mesos-execute.
>
>
> Diffs
> -----
>
> src/cli/execute.cpp 087a73143d739f41638b8335c7e24dfcd14bc7fb
>
> Diff: https://reviews.apache.org/r/46469/diff/
>
>
> Testing
> -------
>
> $ ./mesos-execute --master=127.0.0.1:5050 --name=auth_test --command="while true; do echo 'Hello'; sleep 2; done"
> I0420 21:55:11.347501 2751 scheduler.cpp:177] Version: 0.29.0
> Received an ERROR event: Received unexpected '401 Unauthorized' () for SUBSCRIBE
>
> $ ./mesos-execute --master=127.0.0.1:5050 --name=auth_test --command="while true; do echo 'Hello'; sleep 2; done" --principal=principal --secret=secret
> I0420 21:54:02.924027 2587 scheduler.cpp:177] Version: 0.29.0
> Subscribed with ID '81fe5703-ccae-4c6e-8e39-a246109d812e-0001'
> Submitted task 'auth_test' to agent '9edb64fe-5b97-43d3-81fe-81f0cdcea0b4-S0'
> Received status update TASK_RUNNING for task 'auth_test'
> source: SOURCE_EXECUTOR
>
>
> Thanks,
>
> Tim Anderegg
>
>
Re: Review Request 46469: Added support for credentials to
mesos-execute.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46469/#review130012
-----------------------------------------------------------
src/cli/execute.cpp (line 754)
<https://reviews.apache.org/r/46469/#comment193622>
I think it is ok to set principal and not secret. We should just set the framework info principal in that case.
also, s/cred/credential_/
src/cli/execute.cpp (lines 772 - 774)
<https://reviews.apache.org/r/46469/#comment193623>
see above.
- Vinod Kone
On April 21, 2016, 1:57 a.m., Tim Anderegg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46469/
> -----------------------------------------------------------
>
> (Updated April 21, 2016, 1:57 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-3402
> https://issues.apache.org/jira/browse/MESOS-3402
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added support for credentials to mesos-execute.
>
>
> Diffs
> -----
>
> src/cli/execute.cpp 087a73143d739f41638b8335c7e24dfcd14bc7fb
>
> Diff: https://reviews.apache.org/r/46469/diff/
>
>
> Testing
> -------
>
> $ ./mesos-execute --master=127.0.0.1:5050 --name=auth_test --command="while true; do echo 'Hello'; sleep 2; done"
> I0420 21:55:11.347501 2751 scheduler.cpp:177] Version: 0.29.0
> Received an ERROR event: Received unexpected '401 Unauthorized' () for SUBSCRIBE
>
> $ ./mesos-execute --master=127.0.0.1:5050 --name=auth_test --command="while true; do echo 'Hello'; sleep 2; done" --principal=principal --secret=secret
> I0420 21:54:02.924027 2587 scheduler.cpp:177] Version: 0.29.0
> Subscribed with ID '81fe5703-ccae-4c6e-8e39-a246109d812e-0001'
> Submitted task 'auth_test' to agent '9edb64fe-5b97-43d3-81fe-81f0cdcea0b4-S0'
> Received status update TASK_RUNNING for task 'auth_test'
> source: SOURCE_EXECUTOR
>
>
> Thanks,
>
> Tim Anderegg
>
>