[jira] [Commented] (LIBCLOUD-728) SSLError missing from @retry exceptions

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LIBCLOUD-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14647763#comment-14647763 ] 

ASF GitHub Bot commented on LIBCLOUD-728:
-----------------------------------------

GitHub user thesquelched opened a pull request:

    https://github.com/apache/libcloud/pull/556

    [LIBCLOUD-728] Add SSLError to retry decorator exceptions

    Add `ssl.SSLError` to the list of exceptions that `libcloud.utils.misc.retry` catches, since that `SSLError` can be a transient error.  Also:
    
    - Clean up `retry` a bit, fixing an issue in which keyword arguments defaults are not applied
    - Enable retries in tests that are designed to test retries (previous, some tests passed trivially)
    
    See: https://issues.apache.org/jira/browse/LIBCLOUD-728

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/thesquelched/libcloud retry_ssl_error

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/556.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #556
    
----
commit 1499f11920f9f620041207b212c3216781029382
Author: Scott Kruger <sc...@rackspace.com>
Date:   2015-07-30T15:02:31Z

    [LIBCLOUD-728] Add SSLError to retry decorator exceptions

----


> SSLError missing from @retry exceptions
> ---------------------------------------
>
>                 Key: LIBCLOUD-728
>                 URL: https://issues.apache.org/jira/browse/LIBCLOUD-728
>             Project: Libcloud
>          Issue Type: Bug
>          Components: Core
>            Reporter: Scott Kruger
>            Priority: Minor
>              Labels: easyfix
>
> In {{libcloud/utils/misc.py}}, the {{retry}} decorator is supposed to retry functions upon encountering transient network failures.  However, the list of exceptions is missing {{ssl.SSLError}}, which can be thrown when attempting to connect over HTTPS.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)