You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/01/26 07:11:19 UTC
[GitHub] [apisix] liangliang4ward opened a new pull request #6210: fix: update document directory
liangliang4ward opened a new pull request #6210:
URL: https://github.com/apache/apisix/pull/6210
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
update `plugin-develop` document directory
<!--- If it fixes an open issue, please link to the issue here. -->
### Pre-submission checklist:
<!--
Please follow the PR manners:
1. Use Draft if the PR is not ready to be reviewed
2. Test is required for the feat/fix PR, unless you have a good reason
3. Doc is required for the feat PR
4. Use a new commit to resolve review instead of `push -f`
5. If you need to resolve merge conflicts after the PR is reviewed, please merge master but do not rebase
6. Use "request review" to notify the reviewer once you have resolved the review
7. Only reviewer can click "Resolve conversation" to mark the reviewer's review resolved
-->
* [ ] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] leslie-tsang commented on a change in pull request #6210: docs: update document directory
Posted by GitBox <gi...@apache.org>.
leslie-tsang commented on a change in pull request #6210:
URL: https://github.com/apache/apisix/pull/6210#discussion_r793180385
##########
File path: docs/zh/latest/plugin-develop.md
##########
@@ -25,7 +25,7 @@ title: 插件开发
- [目录](#目录)
- [检查外部依赖](#检查外部依赖)
-- [插件命名与配置](#插件命名与配置)
+- [插件命名，优先级和其他](#插件命名，优先级和其他)
Review comment:
I'd like to know why we changed the title, BTW, the link doesn't work in GitHub Markdown.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] zaunist commented on a change in pull request #6210: docs: update document directory
Posted by GitBox <gi...@apache.org>.
zaunist commented on a change in pull request #6210:
URL: https://github.com/apache/apisix/pull/6210#discussion_r793176354
##########
File path: docs/zh/latest/plugin-develop.md
##########
@@ -25,7 +25,7 @@ title: 插件开发
- [目录](#目录)
- [检查外部依赖](#检查外部依赖)
-- [插件命名与配置](#插件命名与配置)
+- [插件命名，优先级和其他](#插件命名，优先级和其他)
Review comment:
Why we need to change this description? Using commas in titles seems a little strange...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tzssangglass commented on a change in pull request #6210: docs: update document directory
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on a change in pull request #6210:
URL: https://github.com/apache/apisix/pull/6210#discussion_r794173824
##########
File path: docs/zh/latest/plugin-develop.md
##########
@@ -25,7 +25,7 @@ title: 插件开发
- [目录](#目录)
- [检查外部依赖](#检查外部依赖)
-- [插件命名与配置](#插件命名与配置)
+- [插件命名，优先级和其他](#插件命名，优先级和其他)
Review comment:
yes, In fact, I think it would be better to remove the `，` both in nav and docs ……
##########
File path: docs/zh/latest/plugin-develop.md
##########
@@ -25,7 +25,7 @@ title: 插件开发
- [目录](#目录)
- [检查外部依赖](#检查外部依赖)
-- [插件命名与配置](#插件命名与配置)
+- [插件命名，优先级和其他](#插件命名，优先级和其他)
Review comment:
Because the following title is used in `插件命名，优先级和其他`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis merged pull request #6210: docs: update document directory
Posted by GitBox <gi...@apache.org>.
membphis merged pull request #6210:
URL: https://github.com/apache/apisix/pull/6210
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org