[GitHub] [solr] dsmiley commented on a change in pull request #338: @sayandigital SOLR-13182 - NullPointerException

[GitBox <gi...@apache.org>]

dsmiley commented on a change in pull request #338:
URL: https://github.com/apache/solr/pull/338#discussion_r743753769



##########
File path: solr/core/src/java/org/apache/solr/search/join/BlockJoinParentQParser.java
##########
@@ -60,10 +60,15 @@ protected String getFiltersParamName() {
   }
 
   protected Query parseParentFilter() throws SyntaxError {
-    String filter = localParams.get(getParentFilterLocalParamName());
-    QParser parentParser = subQuery(filter, null);
-    Query parentQ = parentParser.getQuery();
-    return parentQ;
+    try {

Review comment:
       Why; what exception gets thrown before your change?  If I recall, this whole method would return null and not throw; right?  So check that parentQ isn't null and if it is, throw a SyntaxError.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org