You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/11/22 08:10:45 UTC
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7641: esp32s2/i2s: implement I2S receiver module
pkarashchenko commented on code in PR #7641:
URL: https://github.com/apache/incubator-nuttx/pull/7641#discussion_r1028990929
##########
boards/xtensa/esp32s2/esp32s2-saola-1/src/esp32s2_bringup.c:
##########
@@ -242,9 +242,24 @@ int esp32s2_bringup(void)
}
#else
+ bool i2s_enable_tx;
+ bool i2s_enable_rx;
+
+#ifdef CONFIG_ESP32S2_I2S_TX
+ i2s_enable_tx = true;
+#else
+ i2s_enable_tx = false;
+#endif /* CONFIG_ESP32S2_I2S_TX */
+
+#ifdef CONFIG_ESP32S2_I2S_RX
+ i2s_enable_rx = true;
+#else
+ i2s_enable_rx = false;
Review Comment:
remove 2 spaces
##########
boards/xtensa/esp32s2/esp32s2-saola-1/src/esp32s2_bringup.c:
##########
@@ -242,9 +242,24 @@ int esp32s2_bringup(void)
}
#else
+ bool i2s_enable_tx;
+ bool i2s_enable_rx;
+
+#ifdef CONFIG_ESP32S2_I2S_TX
+ i2s_enable_tx = true;
+#else
+ i2s_enable_tx = false;
+#endif /* CONFIG_ESP32S2_I2S_TX */
+
+#ifdef CONFIG_ESP32S2_I2S_RX
+ i2s_enable_rx = true;
Review Comment:
remove 2 spaces
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org