You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/03/07 04:19:13 UTC

Review Request: Better cgroups resource monitoring error handling.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9796/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and Vinod Kone.


Description
-------

See subject.


Diffs
-----

  src/slave/cgroups_isolation_module.cpp c7ca32c8122ce97f77a5ba68f6ad3dc1f17704f7 

Diff: https://reviews.apache.org/r/9796/diff/


Testing
-------

make check


Thanks,

Ben Mahler

Re: Review Request: Better cgroups resource monitoring error handling.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9796/
-----------------------------------------------------------

(Updated April 12, 2013, 10:42 p.m.)


Review request for mesos, Benjamin Hindman and Vinod Kone.


Changes
-------

Rebased off trunk, no need for review.


Description
-------

See subject.


Diffs (updated)
-----

  src/slave/cgroups_isolator.cpp 4eb09980ed684a66e8ab9494286e07ce528e8300 

Diff: https://reviews.apache.org/r/9796/diff/


Testing
-------

make check


Thanks,

Ben Mahler

Re: Review Request: Better cgroups resource monitoring error handling.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9796/
-----------------------------------------------------------

(Updated March 28, 2013, 9:26 p.m.)


Review request for mesos, Benjamin Hindman and Vinod Kone.


Changes
-------

Rebased off trunk, no need for review.


Description
-------

See subject.


Diffs (updated)
-----

  src/slave/cgroups_isolator.cpp ebc2843c57d5c1787394d0572aca1ead3e5734f1 

Diff: https://reviews.apache.org/r/9796/diff/


Testing
-------

make check


Thanks,

Ben Mahler

Re: Review Request: Better cgroups resource monitoring error handling.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9796/
-----------------------------------------------------------

(Updated March 12, 2013, 9:36 p.m.)


Review request for mesos, Benjamin Hindman and Vinod Kone.


Changes
-------

Rebased off trunk, no need for review.


Description
-------

See subject.


Diffs (updated)
-----

  src/slave/cgroups_isolation_module.cpp 9395d9cd6cf2ac7a720480b778836eb1d704e00d 

Diff: https://reviews.apache.org/r/9796/diff/


Testing
-------

make check


Thanks,

Ben Mahler

Re: Review Request: Better cgroups resource monitoring error handling.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9796/
-----------------------------------------------------------

(Updated March 8, 2013, 2:27 a.m.)


Review request for mesos, Benjamin Hindman and Vinod Kone.


Changes
-------

Reviews, rebased off trunk.


Description
-------

See subject.


Diffs (updated)
-----

  src/slave/cgroups_isolation_module.cpp c7ca32c8122ce97f77a5ba68f6ad3dc1f17704f7 

Diff: https://reviews.apache.org/r/9796/diff/


Testing
-------

make check


Thanks,

Ben Mahler

Re: Review Request: Better cgroups resource monitoring error handling.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9796/#review17511
-----------------------------------------------------------

Ship it!



src/slave/cgroups_isolation_module.cpp
<https://reviews.apache.org/r/9796/#comment37173>

    s/. e.g./, e.g.,



src/slave/cgroups_isolation_module.cpp
<https://reviews.apache.org/r/9796/#comment37174>

    s/. e.g./, e.g.,


- Vinod Kone


On March 7, 2013, 3:19 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9796/
> -----------------------------------------------------------
> 
> (Updated March 7, 2013, 3:19 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Description
> -------
> 
> See subject.
> 
> 
> Diffs
> -----
> 
>   src/slave/cgroups_isolation_module.cpp c7ca32c8122ce97f77a5ba68f6ad3dc1f17704f7 
> 
> Diff: https://reviews.apache.org/r/9796/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Re: Review Request: Better cgroups resource monitoring error handling.

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9796/#review17527
-----------------------------------------------------------

Ship it!



src/slave/cgroups_isolation_module.cpp
<https://reviews.apache.org/r/9796/#comment37199>

    +1



src/slave/cgroups_isolation_module.cpp
<https://reviews.apache.org/r/9796/#comment37200>

    +1!


- Benjamin Hindman


On March 7, 2013, 3:19 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9796/
> -----------------------------------------------------------
> 
> (Updated March 7, 2013, 3:19 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Description
> -------
> 
> See subject.
> 
> 
> Diffs
> -----
> 
>   src/slave/cgroups_isolation_module.cpp c7ca32c8122ce97f77a5ba68f6ad3dc1f17704f7 
> 
> Diff: https://reviews.apache.org/r/9796/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>