You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by robertkowalski <gi...@git.apache.org> on 2016/02/01 04:56:10 UTC

[GitHub] couchdb-fauxton pull request: React 14 update

Github user robertkowalski commented on a diff in the pull request:

    https://github.com/apache/couchdb-fauxton/pull/617#discussion_r51377269
  
    --- Diff: app/addons/documents/doc-editor/tests/doc-editor.componentsSpec.react.jsx ---
    @@ -146,13 +147,13 @@ define([
             }
           });
     
    -      var attachmentNode = $(el.getDOMNode()).find('.view-attachments-section .dropdown-menu li')[0];
    +      var attachmentNode = $(ReactDOM.findDOMNode(el)).find('.view-attachments-section .dropdown-menu li')[0];
           var attachmentURLactual = $(attachmentNode).find('a').attr('href');
     
           assert.equal(attachmentURLactual, "../../id/_design/test-doc/one.png");
         });
     
    -
    +/*
    --- End diff --
    
    this should get uncommented or deleted


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---