You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/04 18:43:28 UTC
[GitHub] [flink] bowenli86 commented on a change in pull request #10419:
[FLINK-15026][SQL-CLIENT]Support create/drop/alter database in sql client
bowenli86 commented on a change in pull request #10419: [FLINK-15026][SQL-CLIENT]Support create/drop/alter database in sql client
URL: https://github.com/apache/flink/pull/10419#discussion_r353915795
##########
File path: flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/LocalExecutor.java
##########
@@ -544,6 +544,11 @@ public ProgramTargetDescriptor executeUpdate(String sessionId, String statement)
String statement) {
applyUpdate(context, context.getTableEnvironment(), context.getQueryConfig(), statement);
+ //Todo: we should refactor following condition after TableEnvironment has support submit job directly.
+ if (!statement.trim().matches("(INSERT\\s+INTO.*)")) {
Review comment:
why does this PR have things to do with "INSERT INTO"?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services