You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "jack-moseley (via GitHub)" <gi...@apache.org> on 2023/04/12 22:41:17 UTC

[GitHub] [gobblin] jack-moseley commented on a diff in pull request #3671: [GOBBLIN-1815] Refactor yarn app launchers to support extending these classes

jack-moseley commented on code in PR #3671:
URL: https://github.com/apache/gobblin/pull/3671#discussion_r1164677557


##########
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/GobblinYarnAppLauncher.java:
##########
@@ -331,6 +323,17 @@ public GobblinYarnAppLauncher(Config config, YarnConfiguration yarnConfiguration
     }
   }
 
+  protected void createPotentonYarnClients(Config config, Map<String, YarnClient> potentialYarnClients) {

Review Comment:
   Did you mean to name this `createPotentialYarnClients`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org