You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org> on 2021/08/16 22:17:34 UTC
[native-toolchain-CR] IMPALA-10857: Add curl 7.78.0 to native-toolchain
Wenzhe Zhou has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17772
Change subject: IMPALA-10857: Add curl 7.78.0 to native-toolchain
......................................................................
IMPALA-10857: Add curl 7.78.0 to native-toolchain
This patch adds curl 7.78.0 to native-toolchain.
Testing:
- Built native toolchain on local machine.
- Built native toolchain with Jenkins job without publishing to
S3 bucket.
Change-Id: Iab535ef20abb9790056ec22015f8d6d8d33cef6d
---
M buildall.sh
A source/curl/build.sh
2 files changed, 41 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/72/17772/1
--
To view, visit http://gerrit.cloudera.org:8080/17772
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iab535ef20abb9790056ec22015f8d6d8d33cef6d
Gerrit-Change-Number: 17772
Gerrit-PatchSet: 1
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
[native-toolchain-CR] IMPALA-10857: Add curl 7.78.0 to native-toolchain
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17772 )
Change subject: IMPALA-10857: Add curl 7.78.0 to native-toolchain
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
LGTM. BTW, did you verify that curl 7.78.0 satifies IMPALA-10853? in case we need some additional patches.
http://gerrit.cloudera.org:8080/#/c/17772/1/source/curl/build.sh
File source/curl/build.sh:
http://gerrit.cloudera.org:8080/#/c/17772/1/source/curl/build.sh@33
PS1, Line 33: --with-openssl
Good to see this! I think this also helps to resolve IMPALA-10853. Maybe we can let cmake build on top of this curl in future patch.
--
To view, visit http://gerrit.cloudera.org:8080/17772
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab535ef20abb9790056ec22015f8d6d8d33cef6d
Gerrit-Change-Number: 17772
Gerrit-PatchSet: 1
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 18 Aug 2021 12:18:13 +0000
Gerrit-HasComments: Yes
[native-toolchain-CR] IMPALA-10857: Add curl 7.78.0 to native-toolchain
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17772 )
Change subject: IMPALA-10857: Add curl 7.78.0 to native-toolchain
......................................................................
Patch Set 1: Code-Review+2
This looks good to me (not intended to preempt any other review comments)
--
To view, visit http://gerrit.cloudera.org:8080/17772
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab535ef20abb9790056ec22015f8d6d8d33cef6d
Gerrit-Change-Number: 17772
Gerrit-PatchSet: 1
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 18 Aug 2021 20:23:46 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-10857: Add curl 7.78.0 to native-toolchain
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/17772 )
Change subject: IMPALA-10857: Add curl 7.78.0 to native-toolchain
......................................................................
Patch Set 1:
curl 7.78.0 is the latest release version.
cmake-3.14.3 source code contains libcurl source code in directory Utilities/cmcurl. cmcurl/include/curl/curlver.h shows it's 7.62.0.
There is an option CMAKE_USE_SYSTEM_CURL in cmake-3.14.3/CMakeLists.txt. If the option is on, it will use curl installed on build machine, otherwise use its built-in libcurl.
I guess the cause for IMPALA-10853 is cmake use the libcurl on build machine.
--
To view, visit http://gerrit.cloudera.org:8080/17772
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab535ef20abb9790056ec22015f8d6d8d33cef6d
Gerrit-Change-Number: 17772
Gerrit-PatchSet: 1
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 18 Aug 2021 18:10:22 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-10857: Add curl 7.78.0 to native-toolchain
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/17772 )
Change subject: IMPALA-10857: Add curl 7.78.0 to native-toolchain
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17772/1/source/curl/build.sh
File source/curl/build.sh:
http://gerrit.cloudera.org:8080/#/c/17772/1/source/curl/build.sh@33
PS1, Line 33: --with-openssl
> Good to see this! I think this also helps to resolve IMPALA-10853. Maybe we
To change the libcurl for cmake, we have to change the make file for cmake.
--
To view, visit http://gerrit.cloudera.org:8080/17772
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab535ef20abb9790056ec22015f8d6d8d33cef6d
Gerrit-Change-Number: 17772
Gerrit-PatchSet: 1
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 18 Aug 2021 18:14:10 +0000
Gerrit-HasComments: Yes
[native-toolchain-CR] IMPALA-10857: Add curl 7.78.0 to native-toolchain
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/17772 )
Change subject: IMPALA-10857: Add curl 7.78.0 to native-toolchain
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/17772
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab535ef20abb9790056ec22015f8d6d8d33cef6d
Gerrit-Change-Number: 17772
Gerrit-PatchSet: 1
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 20 Aug 2021 04:49:12 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-10857: Add curl 7.78.0 to native-toolchain
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17772 )
Change subject: IMPALA-10857: Add curl 7.78.0 to native-toolchain
......................................................................
IMPALA-10857: Add curl 7.78.0 to native-toolchain
This patch adds curl 7.78.0 to native-toolchain.
Testing:
- Built native toolchain on local machine.
- Built native toolchain with Jenkins job without publishing to
S3 bucket.
Change-Id: Iab535ef20abb9790056ec22015f8d6d8d33cef6d
Reviewed-on: http://gerrit.cloudera.org:8080/17772
Reviewed-by: Quanlong Huang <hu...@gmail.com>
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Wenzhe Zhou <wz...@cloudera.com>
---
M buildall.sh
A source/curl/build.sh
2 files changed, 41 insertions(+), 0 deletions(-)
Approvals:
Quanlong Huang: Looks good to me, but someone else must approve
Joe McDonnell: Looks good to me, approved
Wenzhe Zhou: Verified
--
To view, visit http://gerrit.cloudera.org:8080/17772
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iab535ef20abb9790056ec22015f8d6d8d33cef6d
Gerrit-Change-Number: 17772
Gerrit-PatchSet: 2
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>