You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Josh McKenzie (Jira)" <ji...@apache.org> on 2022/07/20 16:30:00 UTC

[jira] [Commented] (CASSANDRA-17733) min_tracked_partition_size_bytes should not have the unit suffix

    [ https://issues.apache.org/jira/browse/CASSANDRA-17733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569116#comment-17569116 ] 

Josh McKenzie commented on CASSANDRA-17733:
-------------------------------------------

No new failures that look related to this ticket.

 

[CI Results]
Branch: 4.1, build number: 103
butler url: [https://butler.cassandra.apache.org/#/ci/upstream/compare/Cassandra-4.1/Cassandra-4.1]
jenkins url: [https://ci-cassandra.apache.org/job/Cassandra-4.1/103/]
JIRA: CASSANDRA-17733
commit url: [https://gitbox.apache.org/repos/asf?p=cassandra.git;a=commit;h=46d9cbe2f66b02cedf1b7961c4c1194488e1323b]
affected paths:
 * test/distributed/org/apache/cassandra/distributed/test/TopPartitionsTest.java
 * NEWS.txt
 * src/java/org/apache/cassandra/service/StorageService.java
 * src/java/org/apache/cassandra/config/DatabaseDescriptor.java
 * CHANGES.txt
 * src/java/org/apache/cassandra/metrics/TopPartitionTracker.java
 * src/java/org/apache/cassandra/config/Config.java
 * test/unit/org/apache/cassandra/db/TopPartitionTrackerTest.java

Build Result: UNSTABLE
Passing Tests: 48020
Failing Tests: 8
||Test|Failures|JIRA|
|org.apache.cassandra.distributed.test.TopPartitionsTest.basicRowTombstonesTest[Incremental]|1 of 102|CASSANDRA-17649?|
|org.apache.cassandra.net.ProxyHandlerConnectionsTest.testExpireSome-compression|12 of 102|[No JIRA found|https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=496&quickFilter=2252]|
|org.apache.cassandra.distributed.test.CASTest.testSucccessfulWriteDuringRangeMovementFollowedByRead|16 of 102|CASSANDRA-17461?|
|org.apache.cassandra.tools.TopPartitionsTest.testServiceTopPartitionsSingleTable|12 of 102|CASSANDRA-17649?|
|dtest-large-novnode.materialized_views_test.TestMaterializedViews.test_throttled_partition_update|1 of 102|CASSANDRA-11612?|
|junit.framework.TestSuite.org.apache.cassandra.distributed.test.TopPartitionsTest|2 of 102|[Multiple JIRAs found|https://issues.apache.org/jira/issues/?jql=project%20%3D%20CASSANDRA%20and%20resolution%20%3D%20unresolved%20and%20summary%20~%20%22*test*%22]|
|dtest-novnode.cqlsh_tests.test_cqlsh.TestCqlsh.test_describe|1 of 102|CASSANDRA-17322?|
|org.apache.cassandra.distributed.test.NetstatsBootstrapWithEntireSSTablesCompressionStreamingTest.testWithStreamingEntireSSTablesWithoutCompressionWithoutThrottling|1 of 102|[No JIRA found|https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=496&quickFilter=2252]|

> min_tracked_partition_size_bytes should not have the unit suffix
> ----------------------------------------------------------------
>
>                 Key: CASSANDRA-17733
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17733
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Local/Config
>            Reporter: Ekaterina Dimitrova
>            Assignee: Ekaterina Dimitrova
>            Priority: Normal
>             Fix For: 4.1-beta, 4.1
>
>
> min_tracked_partition_size_bytes was added in CASSANDRA-16310. It should have not been added with the unit suffix anymore as confirmed on the commit.
> It is also confusing now when users can add unit of their choice. 
> We have two options:
>  * keep it with annotation and add also version without the suffix
>  * rename it as we are still alpha and API changes can be done for bug fixing. Not sure whether we need an approval on the ML for this one.
> CC [~ycai] , [~marcuse] and [~dcapwell] 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org