[GitHub] [pulsar] SakaSun opened a new pull request #6963: [scripts] Variables not properly set in prepare and cleanup scripts

[GitBox <gi...@apache.org>]

SakaSun opened a new pull request #6963:
URL: https://github.com/apache/pulsar/pull/6963


   <!--
   ### Contribution Checklist
     
     - Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where *XYZ* should be replaced by the actual issue number.
       Skip *Issue XYZ* if there is no associated github issue for this pull request.
       Skip *component* if you are unsure about which is the best component. E.g. `[docs] Fix typo in produce method`.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   ### Motivation
   
   The script `prepare_helm_release.sh` was creating a asymmetric key unless I pass `--symmetric` as last parameter of the command line.
   
   It turns out that the variable is set to false in every step of the parameter parsing loop.
   
   ### Modifications
   
   Moved variable assignment outside of the loop.
   
   ### Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   But is verifiable through the output of the script execution. Passing the parameter `--symmetric` in any order, the output should be:
   ```
   The jwt token secret keys are generated under:
       - '${release}-token-symmetric-key'
   ```
   Instead of:
   ```
   The jwt token secret keys are generated under:
       - '${release}-token-asymmetric-key'
   ```
   
   ### Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API: no
     - The schema: no
     - The default values of configurations: no
     - The wire protocol: no
     - The rest endpoints: no
     - The admin cli options: no
     - Anything that affects deployment: **yes**
   
   ### Documentation
   
     - Does this pull request introduce a new feature? no
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] sijie merged pull request #6963: [scripts] Variables not properly set in prepare and cleanup scripts

[GitBox <gi...@apache.org>]

sijie merged pull request #6963:
URL: https://github.com/apache/pulsar/pull/6963


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] jiazhai commented on pull request #6963: [scripts] Variables not properly set in prepare and cleanup scripts

[GitBox <gi...@apache.org>]

jiazhai commented on pull request #6963:
URL: https://github.com/apache/pulsar/pull/6963#issuecomment-628975213


   @zymap Would you also please help review this？


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org