[GitHub] [arrow] westonpace commented on issue #33628: [C++] Review and sanitize const_cast usage

["westonpace (via GitHub)" <gi...@apache.org>]

westonpace commented on issue #33628:
URL: https://github.com/apache/arrow/issues/33628#issuecomment-1433642742

   I think @js8544 has a good point and so I'll expand on it a bit.  Scalars are immutable, they don't even have any non-const methods (some subtypes have mutable-data but usage of that is rare).
   
   The challenge is that we are very diligent about writing methods of the form `Foo(const Scalar&)` and not so diligent about writing things of the form `Foo(const std::shared_ptr<const Scalar>&)` or `Foo(std::shared_ptr<const Scalar>)`.
   
   I'm not sure the correct answer though.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org