[GitHub] [hadoop-ozone] mukul1987 commented on a change in pull request #871: HDDS-3487. Ozone start fails with NullPointerException in TLS enabled cluster

[GitBox <gi...@apache.org>]

mukul1987 commented on a change in pull request #871:
URL: https://github.com/apache/hadoop-ozone/pull/871#discussion_r415091934



##########
File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/utils/LegacyHadoopConfigurationSource.java
##########
@@ -39,6 +40,11 @@ public String get(String key) {
     return configuration.getRaw(key);
   }
 
+  @Override
+  public char[] getPassword(String key) throws IOException {

Review comment:
       Should we also remove the deault method on ConfigurationSource for getPassword, and have the get() method in OzoneConfiguration and the new method in LegacyHadoopConfig ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org