You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by dragon512 <gi...@git.apache.org> on 2015/10/27 15:32:38 UTC
[GitHub] trafficserver pull request: Fix issue with TS-3885. Changes to TSN...
GitHub user dragon512 opened a pull request:
https://github.com/apache/trafficserver/pull/313
Fix issue with TS-3885. Changes to TSNetVConn test to prevent it from…
… hanging when the defer_accept is set ( via config or kernel option)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dragon512/trafficserver master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/313.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #313
----
commit 1b06bf7f86a8d3fda29493bc68d0e82e4b89029d
Author: Jason Kenny <jk...@yahoo-inc.com>
Date: 2015-10-27T14:30:35Z
Fix issue with TS-3885. Changes to TSNetVConn test to prevent it from hanging when the defer_accept is set ( via config or kernel option)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: Fix issue with TS-3885. Changes to TSN...
Posted by SolidWallOfCode <gi...@git.apache.org>.
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/313#issuecomment-151529685
This is not the kind of code I'd put in production but this is just a test so it should be OK. In particular there are other regression tests that test the write and read logic so I see no point in duplicating that here - I agree we should do the absolute minimum thing necessary to force the accept.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: Fix issue with TS-3885. Changes to TSN...
Posted by SolidWallOfCode <gi...@git.apache.org>.
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/313#discussion_r43135478
--- Diff: proxy/InkAPITest.cc ---
@@ -321,12 +323,15 @@ client_handler(TSCont contp, TSEvent event, void *data)
// Fix me: how to deal with server side cont?
TSContDestroy(contp);
return 1;
- } else {
+ } else if (TS_EVENT_NET_CONNECT == event) {
sockaddr const *addr = TSNetVConnRemoteAddrGet(static_cast<TSVConn>(data));
uint16_t input_server_port = ats_ip_port_host_order(addr);
sleep(1); // XXX this sleep ensures the server end gets the accept event.
--- End diff --
I think the sleep should be after the `write` because the point is to give the kernel time to trigger the `accept`. I'll make that change as I merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: Fix issue with TS-3885. Changes to TSN...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/313
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---