You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by "codecov[bot] (via GitHub)" <gi...@apache.org> on 2023/05/15 18:34:40 UTC
[GitHub] [yunikorn-core] codecov[bot] commented on pull request #548: WIP [YUNIKORN-1716] Improve the performance of baseNodeCollection.getNodeIteratorInternal()
codecov[bot] commented on PR #548:
URL: https://github.com/apache/yunikorn-core/pull/548#issuecomment-1548360701
## [Codecov](https://app.codecov.io/gh/apache/yunikorn-core/pull/548?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#548](https://app.codecov.io/gh/apache/yunikorn-core/pull/548?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (ba7e0f8) into [master](https://app.codecov.io/gh/apache/yunikorn-core/commit/b1c04fdf47a0bf963a687718841798e61796aa84?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (b1c04fd) will **decrease** coverage by `0.15%`.
> The diff coverage is `59.70%`.
> :exclamation: Current head ba7e0f8 differs from pull request most recent head 3a4e59d. Consider uploading reports for the commit 3a4e59d to get more accurate results
```diff
@@ Coverage Diff @@
## master #548 +/- ##
==========================================
- Coverage 74.97% 74.82% -0.15%
==========================================
Files 70 70
Lines 11371 11405 +34
==========================================
+ Hits 8525 8534 +9
- Misses 2545 2571 +26
+ Partials 301 300 -1
```
| [Impacted Files](https://app.codecov.io/gh/apache/yunikorn-core/pull/548?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/objects/application.go](https://app.codecov.io/gh/apache/yunikorn-core/pull/548?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FwcGxpY2F0aW9uLmdv) | `64.57% <23.33%> (+0.15%)` | :arrow_up: |
| [pkg/scheduler/objects/node\_iterator.go](https://app.codecov.io/gh/apache/yunikorn-core/pull/548?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL25vZGVfaXRlcmF0b3IuZ28=) | `92.98% <77.77%> (-7.02%)` | :arrow_down: |
| [pkg/scheduler/objects/node\_collection.go](https://app.codecov.io/gh/apache/yunikorn-core/pull/548?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL25vZGVfY29sbGVjdGlvbi5nbw==) | `80.13% <100.00%> (-13.49%)` | :arrow_down: |
| [pkg/scheduler/objects/preemption.go](https://app.codecov.io/gh/apache/yunikorn-core/pull/548?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL3ByZWVtcHRpb24uZ28=) | `76.16% <100.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org