[GitHub] [solr] dsmiley commented on a change in pull request #2: SOLR-14185: introduce DocSet.iterator(LeafReaderContext), replacing Filter where possible

[GitBox <gi...@apache.org>]

dsmiley commented on a change in pull request #2:
URL: https://github.com/apache/solr/pull/2#discussion_r593167365



##########
File path: solr/core/src/java/org/apache/solr/search/join/GraphQuery.java
##########
@@ -268,13 +266,12 @@ private Automaton buildAutomaton(BytesRefHash termBytesHash) {
     
     @Override
     public Scorer scorer(LeafReaderContext context) throws IOException {
-      if (filter == null) {
+      if (resultSet == null) {
         resultSet = getDocSet();
-        filter = resultSet.getTopFilter();
       }
-      DocIdSet readerSet = filter.getDocIdSet(context,context.reader().getLiveDocs());
+      DocIdSetIterator disi = resultSet.iterator(context);

Review comment:
       Yes; there was a change in approach over the last decade as where filters are applied.  It used to be on top, then it was "pushed down" (in the form of acceptDocs here), and then was reverted to return back up top.  Meanwhile this Filter tech-debt didn't receive attention.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org