You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by jaassoon <gi...@git.apache.org> on 2016/10/18 02:54:20 UTC
[GitHub] cordova-plugin-statusbar pull request #68: CB-10158: (ios) StatusBar issue w...
GitHub user jaassoon opened a pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/68
CB-10158: (ios) StatusBar issue when recovering from fullscreen video playback in landscape mode
CB-10158: (ios) StatusBar issue when recovering from fullscreen video playback in landscape mode
following the comment of user 165573 in https://issues.apache.org/jira/browse/CB-10158
After trying several hacks (like hiding then showing, ...) I ended up changing the content of "setStatusBarOverlaysWebView" to avoid checking if we're setting a new value, and whenever I go back to my app after viewing a video, I call "StatusBar.overlaysWebView(false);".
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jaassoon/cordova-plugin-statusbar master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-statusbar/pull/68.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #68
----
commit 53d0b04ed69431139de1a1767a6d311d450211c3
Author: Steve Gill <st...@gmail.com>
Date: 2016-09-09T23:08:04Z
CB-11832 Incremented plugin version.
commit 940a8ee92045b365b11790aa5e3e55964ef913a2
Author: Shazron Abdullah <sh...@gmail.com>
Date: 2016-09-28T08:26:09Z
CB-11917 - Remove pull request template checklist item: "iCLA has been submitted\u2026"
This closes #66
commit 1f9ecb1936588e2ed7e4c8069d249d3220aac1cb
Author: jaassoon <li...@gmail.com>
Date: 2016-10-18T02:46:26Z
CB-10158: (ios)
CB-10158: (ios) StatusBar issue when recovering from fullscreen video playback in landscape mode
following the comment of user 165573 in https://issues.apache.org/jira/browse/CB-10158
After trying several hacks (like hiding then showing, ...) I ended up changing the content of "setStatusBarOverlaysWebView" to avoid checking if we're setting a new value, and whenever I go back to my app after viewing a video, I call "StatusBar.overlaysWebView(false);".
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-statusbar issue #68: CB-10158: (ios) StatusBar issue when rec...
Posted by cordova-qa <gi...@git.apache.org>.
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-statusbar/pull/68
Cordova CI Build has completed successfully.
**Commit** - [Link](https://github.com/apache/cordova-plugin-statusbar/pull/68/commits/1f9ecb1936588e2ed7e4c8069d249d3220aac1cb)
**Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/32/)
| Builder Name | Console Output | Test Report | Device Logs |
| :---: | :---: | :---: | :---: |
| [Windows 8.1 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/32//PLATFORM=windows-8.1-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/32//PLATFORM=windows-8.1-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/32//PLATFORM=windows-8.1-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/32//PLATFORM=windows-8.1-store/artifact/) |
| [Windows 10 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/32//PLATFORM=windows-10-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/32//PLATFORM=windows-10-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/32//PLATFORM=windows-10-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/32//PLATFORM=windows-10-store/artifact/) |
| [Windows 8.1 Phone]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/32//PLATFORM=windows-8.1-phone/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/32//PLATFORM=windows-8.1-phone/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/32//PLATFORM=windows-8.1-phone/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/32//PLATFORM=windows-8.1-phone/artifact/) |
| [iOS]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/32//PLATFORM=ios/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/32//PLATFORM=ios/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/32//PLATFORM=ios/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/32//PLATFORM=ios/artifact/) |
| [Android]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/32//PLATFORM=android/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/32//PLATFORM=android/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/32//PLATFORM=android/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/32//PLATFORM=android/artifact/) |
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-statusbar issue #68: CB-10158: (ios) StatusBar issue when rec...
Posted by jcesarmobile <gi...@git.apache.org>.
Github user jcesarmobile commented on the issue:
https://github.com/apache/cordova-plugin-statusbar/pull/68
Hi.
Thanks for the PR.
The PR should be agains master branch, not 2.2.x branch.
But I have been evaluating it and I won't merge it as it's not a real fix as you have to call `StatusBar.overlaysWebView(false);` when the video finish, you could also call `StatusBar.overlaysWebView(true);StatusBar.overlaysWebView(false);` and will have the same effect without code changes.
But I'm interested in knowing how do you know that you have finishing playing the video. is there any event you can listen to?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-statusbar issue #68: CB-10158: (ios) StatusBar issue when rec...
Posted by jaassoon <gi...@git.apache.org>.
Github user jaassoon commented on the issue:
https://github.com/apache/cordova-plugin-statusbar/pull/68
For example:
video.addEventListener('pause',pauseHandler,false);
function pauseHandler(){//ios only
if(this.webkitDisplayingFullscreen)return;
...
StatusBar.overlaysWebView(true);
StatusBar.overlaysWebView(false);
}
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-statusbar pull request #68: CB-10158: (ios) StatusBar issue w...
Posted by jaassoon <gi...@git.apache.org>.
Github user jaassoon closed the pull request at:
https://github.com/apache/cordova-plugin-statusbar/pull/68
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-statusbar issue #68: CB-10158: (ios) StatusBar issue when rec...
Posted by jcesarmobile <gi...@git.apache.org>.
Github user jcesarmobile commented on the issue:
https://github.com/apache/cordova-plugin-statusbar/pull/68
Ah, didn't think about the pause event and good to know about the webkitDisplayingFullscreen.
Anyway, I fixed the issue last weekend, you can close the PR now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org