You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Keith Wall (JIRA)" <ji...@apache.org> on 2012/07/19 14:10:34 UTC
[jira] [Created] (QPID-4152) Refactor coverage targets in Java
build system
Keith Wall created QPID-4152:
--------------------------------
Summary: Refactor coverage targets in Java build system
Key: QPID-4152
URL: https://issues.apache.org/jira/browse/QPID-4152
Project: Qpid
Issue Type: Improvement
Components: Ant Build System
Reporter: Keith Wall
Assignee: Keith Wall
Priority: Minor
Fix For: 0.19
1) Eliminate a hard-coded list used to determine those modules for which coverage is generated.
2) Eliminate duplication between the "test" target and the "cover-test" targets.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Assigned] (QPID-4152) Refactor coverage targets in Java
build system
Posted by "Keith Wall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Keith Wall reassigned QPID-4152:
--------------------------------
Assignee: Philip Harvey (was: Keith Wall)
Hi Phil, can you review this change please?
> Refactor coverage targets in Java build system
> ----------------------------------------------
>
> Key: QPID-4152
> URL: https://issues.apache.org/jira/browse/QPID-4152
> Project: Qpid
> Issue Type: Improvement
> Components: Ant Build System
> Reporter: Keith Wall
> Assignee: Philip Harvey
> Priority: Minor
> Labels: cobertura
> Fix For: 0.19
>
>
> 1) Eliminate a hard-coded list used to determine those modules for which coverage is generated.
> 2) Eliminate duplication between the "test" target and the "cover-test" targets.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Updated] (QPID-4152) Refactor coverage targets in Java
build system
Posted by "Keith Wall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Keith Wall updated QPID-4152:
-----------------------------
Status: Ready To Review (was: In Progress)
> Refactor coverage targets in Java build system
> ----------------------------------------------
>
> Key: QPID-4152
> URL: https://issues.apache.org/jira/browse/QPID-4152
> Project: Qpid
> Issue Type: Improvement
> Components: Ant Build System
> Reporter: Keith Wall
> Assignee: Keith Wall
> Priority: Minor
> Labels: cobertura
> Fix For: 0.19
>
>
> 1) Eliminate a hard-coded list used to determine those modules for which coverage is generated.
> 2) Eliminate duplication between the "test" target and the "cover-test" targets.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Updated] (QPID-4152) Refactor coverage targets in Java
build system
Posted by "Philip Harvey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Philip Harvey updated QPID-4152:
--------------------------------
Assignee: Keith Wall (was: Philip Harvey)
Status: Open (was: Ready To Review)
further change is required (see patch). Pls commit it if you're happy with it.
> Refactor coverage targets in Java build system
> ----------------------------------------------
>
> Key: QPID-4152
> URL: https://issues.apache.org/jira/browse/QPID-4152
> Project: Qpid
> Issue Type: Improvement
> Components: Ant Build System
> Reporter: Keith Wall
> Assignee: Keith Wall
> Priority: Minor
> Labels: cobertura
> Fix For: 0.19
>
> Attachments: 0001-QPID-4152-added-condition-to-cover-test-target-so-it.patch
>
>
> 1) Eliminate a hard-coded list used to determine those modules for which coverage is generated.
> 2) Eliminate duplication between the "test" target and the "cover-test" targets.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Commented] (QPID-4152) Refactor coverage targets in Java
build system
Posted by "Keith Wall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13426619#comment-13426619 ]
Keith Wall commented on QPID-4152:
----------------------------------
Reviewed, no comments. Patch applied.
> Refactor coverage targets in Java build system
> ----------------------------------------------
>
> Key: QPID-4152
> URL: https://issues.apache.org/jira/browse/QPID-4152
> Project: Qpid
> Issue Type: Improvement
> Components: Ant Build System
> Reporter: Keith Wall
> Assignee: Keith Wall
> Priority: Minor
> Labels: cobertura
> Fix For: 0.19
>
> Attachments: 0001-QPID-4152-added-condition-to-cover-test-target-so-it.patch
>
>
> 1) Eliminate a hard-coded list used to determine those modules for which coverage is generated.
> 2) Eliminate duplication between the "test" target and the "cover-test" targets.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Updated] (QPID-4152) Refactor coverage targets in Java
build system
Posted by "Philip Harvey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Philip Harvey updated QPID-4152:
--------------------------------
Attachment: 0001-QPID-4152-added-condition-to-cover-test-target-so-it.patch
Attached patch to fix problem running "ant cover-test".
Added condition to cover-test target so it only runs if units tests exist. Was previously choking trying to run amqp-1-0-common tests, because junit.jar wasn't on classpath.
> Refactor coverage targets in Java build system
> ----------------------------------------------
>
> Key: QPID-4152
> URL: https://issues.apache.org/jira/browse/QPID-4152
> Project: Qpid
> Issue Type: Improvement
> Components: Ant Build System
> Reporter: Keith Wall
> Assignee: Philip Harvey
> Priority: Minor
> Labels: cobertura
> Fix For: 0.19
>
> Attachments: 0001-QPID-4152-added-condition-to-cover-test-target-so-it.patch
>
>
> 1) Eliminate a hard-coded list used to determine those modules for which coverage is generated.
> 2) Eliminate duplication between the "test" target and the "cover-test" targets.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Resolved] (QPID-4152) Refactor coverage targets in Java
build system
Posted by "Keith Wall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Keith Wall resolved QPID-4152.
------------------------------
Resolution: Fixed
> Refactor coverage targets in Java build system
> ----------------------------------------------
>
> Key: QPID-4152
> URL: https://issues.apache.org/jira/browse/QPID-4152
> Project: Qpid
> Issue Type: Improvement
> Components: Ant Build System
> Reporter: Keith Wall
> Assignee: Keith Wall
> Priority: Minor
> Labels: cobertura
> Fix For: 0.19
>
> Attachments: 0001-QPID-4152-added-condition-to-cover-test-target-so-it.patch
>
>
> 1) Eliminate a hard-coded list used to determine those modules for which coverage is generated.
> 2) Eliminate duplication between the "test" target and the "cover-test" targets.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org