[GitHub] [calcite] a-rafay commented on a change in pull request #2422: [CALCITE-4635] Distinct on aggregate window functions produce wrong r…

[GitBox <gi...@apache.org>]

a-rafay commented on a change in pull request #2422:
URL: https://github.com/apache/calcite/pull/2422#discussion_r646966791



##########
File path: core/src/main/java/org/apache/calcite/sql/SqlOverOperator.java
##########
@@ -78,6 +78,12 @@ public SqlOverOperator() {
       throw validator.newValidationError(aggCall, RESOURCE.overNonAggregate());
     }
     final SqlNode window = call.operand(1);
+    SqlLiteral qualifier = aggCall.getFunctionQuantifier();

Review comment:
       Can we move this validation to a separate method? See this for reference: org.apache.calcite.sql.SqlFunction#validateQuantifier

##########
File path: core/src/test/java/org/apache/calcite/test/SqlToRelConverterTest.java
##########
@@ -657,6 +658,7 @@ public final Sql expr(String expr) {
     sql(sql).ok();
   }
 
+  @Disabled

Review comment:
       Nit. Lets stay consistent and add annotations after the comments.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org