[GitHub] [pinot] mcvsubbu commented on a change in pull request #8078: Segment retention for table

[GitBox <gi...@apache.org>]

mcvsubbu commented on a change in pull request #8078:
URL: https://github.com/apache/pinot/pull/8078#discussion_r799829053



##########
File path: pinot-spi/src/main/java/org/apache/pinot/spi/config/table/SegmentsValidationAndRetentionConfig.java
##########
@@ -102,6 +104,22 @@ public void setRetentionTimeValue(String retentionTimeValue) {
     _retentionTimeValue = retentionTimeValue;
   }
 
+  public String getDeletedSegmentRetentionTimeUnit() {

Review comment:
       Please do not introduce a time unit config here. Retention can be specified in time period like "2d" or "3h"
   We can use `TimeUtils.convertPeriodToMillis()` to translate




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org