You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/11/04 03:43:21 UTC
[GitHub] [inlong] bluewang opened a new pull request, #6400: [INLONG-6397][Dashboard] Node management to add MySQL data nodes
bluewang opened a new pull request, #6400:
URL: https://github.com/apache/inlong/pull/6400
### Prepare a Pull Request
*(Change the title refer to the following example)*
- Title Example: [INLONG-XYZ][Component] Title of the pull request
*(The following *XYZ* should be replaced by the actual [GitHub Issue](https://github.com/apache/inlong/issues) number)*
- Fixes https://github.com/apache/inlong/issues/6397
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] leezng commented on a diff in pull request #6400: [INLONG-6397][Dashboard] Node management to add MySQL data nodes
Posted by GitBox <gi...@apache.org>.
leezng commented on code in PR #6400:
URL: https://github.com/apache/inlong/pull/6400#discussion_r1013655123
##########
inlong-dashboard/src/metas/nodes/defaults/MySQL.ts:
##########
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import { RenderRow } from '@/metas/RenderRow';
+import { RenderList } from '@/metas/RenderList';
+import { NodeInfo } from '../common/NodeInfo';
+import { DataWithBackend } from '@/metas/DataWithBackend';
Review Comment:
Adjust the import order, this is in the first place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] leezng commented on a diff in pull request #6400: [INLONG-6397][Dashboard] Node management to add MySQL data nodes
Posted by GitBox <gi...@apache.org>.
leezng commented on code in PR #6400:
URL: https://github.com/apache/inlong/pull/6400#discussion_r1013655123
##########
inlong-dashboard/src/metas/nodes/defaults/MySQL.ts:
##########
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import { RenderRow } from '@/metas/RenderRow';
+import { RenderList } from '@/metas/RenderList';
+import { NodeInfo } from '../common/NodeInfo';
+import { DataWithBackend } from '@/metas/DataWithBackend';
Review Comment:
Adjust the import order and put the last import first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] leezng merged pull request #6400: [INLONG-6397][Dashboard] Support management for MySQL data node
Posted by GitBox <gi...@apache.org>.
leezng merged PR #6400:
URL: https://github.com/apache/inlong/pull/6400
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #6400: [INLONG-6397][Dashboard] Support management for MySQL data node
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #6400:
URL: https://github.com/apache/inlong/pull/6400#discussion_r1013673725
##########
inlong-dashboard/src/locales/cn.json:
##########
@@ -287,6 +287,10 @@
"meta.Nodes.Hive.DataPathHelp": "DB的存储路径，不包括表名，如：hdfs://127.0.0.1:9000/warehouse/inlong.db",
"meta.Nodes.Hive.ConfDir": "配置路径",
"meta.Nodes.Hive.ConfDirHelp": "将 Hive 集群的 hive-site.xml 文件上传到 HDFS 的某个目录下，如：/user/hive/conf",
+ "meta.Nodes.MySQL.UserName": "用户名",
Review Comment:
`UserName` -> `Username`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org