Re: svn commit: rev 7857 - in trunk/subversion: libsvn_client libsvn_ra_svn libsvn_subr mod_dav_svn svnserve

[Greg Hudson <gh...@MIT.EDU>]

On Mon, 2003-12-01 at 05:43, Greg Stein wrote:
> > -    editor->abort_edit (edit_baton, pool); /* ignore return value */
> > +    svn_error_clear (editor->abort_edit (edit_baton, pool));
> 
> You lost the comment here. I think it should stick around. The code is
> specifically ignoring an error result. The question that arises is: was
> that intended, or accidental?

I agree with Phillip; the svn_error_clear() makes it quite clear that
ignoring the result is intentional.  A comment is only necessary if it's
not obvious why the error is being ignored, and I think in this case
it's pretty obvious (we already have an error to return).


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org