You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2023/05/22 15:59:01 UTC
[tomcat] branch 10.1.x updated (a8e4e0e566 -> 653daebba1)
This is an automated email from the ASF dual-hosted git repository.
markt pushed a change to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
from a8e4e0e566 Use consistent default naming for virtual threads
new 5954764156 Fix SpotBugs warning
new 1a137b7c34 Follow naming conventions (reported by SpotBugs)
new 653daebba1 Fix a couple of new false positives
The 3 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
java/org/apache/catalina/filters/RateLimitFilter.java | 2 +-
res/spotbugs/filter-false-positives.xml | 12 ++++++++++++
test/org/apache/catalina/filters/TestRateLimitFilter.java | 2 +-
3 files changed, 14 insertions(+), 2 deletions(-)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[tomcat] 02/03: Follow naming conventions (reported by SpotBugs)
Posted by ma...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 1a137b7c3456fdf85ffcee0465d43522492e0212
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Mon May 22 16:54:47 2023 +0100
Follow naming conventions (reported by SpotBugs)
---
test/org/apache/catalina/filters/TestRateLimitFilter.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test/org/apache/catalina/filters/TestRateLimitFilter.java b/test/org/apache/catalina/filters/TestRateLimitFilter.java
index ac418726ce..2797b8cf9b 100644
--- a/test/org/apache/catalina/filters/TestRateLimitFilter.java
+++ b/test/org/apache/catalina/filters/TestRateLimitFilter.java
@@ -43,7 +43,7 @@ import org.apache.tomcat.util.descriptor.web.FilterMap;
public class TestRateLimitFilter extends TomcatBaseTest {
@Test
- public void TestRateLimitWith4Clients() throws Exception {
+ public void testRateLimitWith4Clients() throws Exception {
int bucketRequests = 40;
int bucketDuration = 4;
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[tomcat] 01/03: Fix SpotBugs warning
Posted by ma...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 5954764156c1b6c6af3c6e5218962c7ed8e7a19b
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Mon May 22 16:54:28 2023 +0100
Fix SpotBugs warning
---
java/org/apache/catalina/filters/RateLimitFilter.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/java/org/apache/catalina/filters/RateLimitFilter.java b/java/org/apache/catalina/filters/RateLimitFilter.java
index 8172fb1ae1..0d53891a67 100644
--- a/java/org/apache/catalina/filters/RateLimitFilter.java
+++ b/java/org/apache/catalina/filters/RateLimitFilter.java
@@ -130,7 +130,7 @@ public class RateLimitFilter extends GenericFilter {
*/
public static final String PARAM_STATUS_MESSAGE = "statusMessage";
- TimeBucketCounter bucketCounter;
+ transient TimeBucketCounter bucketCounter;
private int actualRequests;
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[tomcat] 03/03: Fix a couple of new false positives
Posted by ma...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 653daebba1dfee416530083762f93a25105b6917
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Mon May 22 16:55:00 2023 +0100
Fix a couple of new false positives
---
res/spotbugs/filter-false-positives.xml | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/res/spotbugs/filter-false-positives.xml b/res/spotbugs/filter-false-positives.xml
index ffd23482b1..d9c9a7e84e 100644
--- a/res/spotbugs/filter-false-positives.xml
+++ b/res/spotbugs/filter-false-positives.xml
@@ -140,6 +140,12 @@
<Field name="engine" />
<Bug pattern="IS2_INCONSISTENT_SYNC" />
</Match>
+ <Match>
+ </Match>
+ <!-- NPE is expected if Connector definition is invalid -->
+ <Class name="org.apache.catalina.connector.Connector"/>
+ <Method name="startInternal"/>
+ <Bug pattern="NP_NULL_ON_SOME_PATH"/>
<Match>
<!-- req.getRemoteUser(), req.getAuthType(), request.getQueryString() can
return null because o.a.t.util.buf.MessageBytes.toString() can return NULL
@@ -186,6 +192,12 @@
<Method name="logDebug"/>
<Bug code="RCN"/>
</Match>
+ <Match>
+ <!-- Sync isn't guarding this object -->
+ <Class name="org.apache.catalina.core.ContainerBase"/>
+ <Method name="setStartStopThreads"/>
+ <Bug pattern="IS2_INCONSISTENT_SYNC"/>
+ </Match>
<Match>
<!-- Exception caught deliberately -->
<Class name="org.apache.catalina.core.NamingContextListener" />
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org