Re: [PR] SPARK-45522: [WIP] Jetty 9 -12 upgrade [spark]

["HiuKwok (via GitHub)" <gi...@apache.org>]

HiuKwok commented on code in PR #43765:
URL: https://github.com/apache/spark/pull/43765#discussion_r1460811746


##########
pom.xml:
##########
@@ -487,12 +487,6 @@
         <version>${jetty.version}</version>
         <scope>provided</scope>
       </dependency>
-      <dependency>

Review Comment:
   Nope, I don't think since the Spark is not calling the module directly. I don't see any negative impact on this.
   For this I have asked on the Jetty project also, see the last reply from:
   https://github.com/jetty/jetty.project/issues/4934
   In the future, if we need any of the `continuation` functionality, we should call the method from Servlet API instead. 



##########
pom.xml:
##########
@@ -487,12 +487,6 @@
         <version>${jetty.version}</version>
         <scope>provided</scope>
       </dependency>
-      <dependency>

Review Comment:
   Nope, I don't think so, since the Spark is not calling the module directly. I don't see any negative impact on this.
   For this I have asked on the Jetty project also, see the last reply from:
   https://github.com/jetty/jetty.project/issues/4934
   In the future, if we need any of the `continuation` functionality, we should call the method from Servlet API instead. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org