[jira] [Commented] (BOOKKEEPER-862) Add tracing and stats to OrderedSafeExecutor for debugging slow tasks

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BOOKKEEPER-862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14651207#comment-14651207 ] 

Hadoop QA commented on BOOKKEEPER-862:
--------------------------------------

Testing JIRA BOOKKEEPER-862


Patch [ose_stats.patch|https://issues.apache.org/jira/secure/attachment/12748376/ose_stats.patch] downloaded at Sun Aug  2 22:01:15 UTC 2015

----------------------------

{color:red}-1{color} Patch failed to apply to head of branch

----------------------------

> Add tracing and stats to OrderedSafeExecutor for debugging slow tasks
> ---------------------------------------------------------------------
>
>                 Key: BOOKKEEPER-862
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-862
>             Project: Bookkeeper
>          Issue Type: Task
>          Components: bookkeeper-server
>            Reporter: Leigh Stewart
>            Priority: Minor
>         Attachments: ose_stats.patch
>
>
> Porting a change form the Twitter branch to improve stats and logging in OrderedSafeExecutor
> These changes have been helpful for us in debugging latency issues in Bookkeeper server/client 
> Summary of changes is
> * add a config option for op stats
> * add stats for task execution time, task pending time
> * add a config option for logging a warning when an op takes longer than x micros
> * add toString implementations for submitted tasks so make it easier to track down slow ops
> * start using Builder for OrderedSafeExecutor
> * add a very simple test to make sure that the slow op logging path is exercised
> Most of this came from Sijie originally, with some changes from me
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)