You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Uwe Schindler (JIRA)" <ji...@apache.org> on 2010/04/18 23:19:49 UTC
[jira] Updated: (LUCENE-2401) Improve performance of
CharTermAttribute(Impl) and also fully implement Appendable
[ https://issues.apache.org/jira/browse/LUCENE-2401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler updated LUCENE-2401:
----------------------------------
Attachment: LUCENE-2401.patch
Attached the patch.
This also makes all implementation methods in the implementation class final (the non-deprecated, new ones), to help the hotspot optimizer.
Also the tests were partly rewriten, and one test bug removed.
All tests pass.
> Improve performance of CharTermAttribute(Impl) and also fully implement Appendable
> ----------------------------------------------------------------------------------
>
> Key: LUCENE-2401
> URL: https://issues.apache.org/jira/browse/LUCENE-2401
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Analysis
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Fix For: 3.1
>
> Attachments: LUCENE-2401.patch
>
>
> The Appendable.append(CharSequence) method in CharTermAttributes is good for general use. But like StringBuilder has for some common use cases specialized methods, this does the same and adds separate append methods for String, StringBuilder and CharTermAttribute itsself. This methods enable the compiler to directly link the specialized methods and don't use the instanceof checks. The unspecialized method only does the instanceof checks for longer CharSequences (>8 chars), else it simply iterates.
> This patch also fixes the required special "null" handling. append() methods are required by Appendable to append "null", if the argument is null. I dont like this, but its required. Maybe we should document, that we dont dont support it. Otherwise, JDK's formatter fails with formatting null.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org