[GitHub] [calcite] zoudan commented on a diff in pull request #3192: [CALCITE-5602] Implement CSC and SEC function

["zoudan (via GitHub)" <gi...@apache.org>]

zoudan commented on code in PR #3192:
URL: https://github.com/apache/calcite/pull/3192#discussion_r1188654267


##########
core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java:
##########
@@ -1219,6 +1219,20 @@ static RelDataType deriveTypeSplit(SqlOperatorBinding operatorBinding,
           OperandTypes.NUMERIC,
           SqlFunctionCategory.NUMERIC);
 
+  @LibraryOperator(libraries = {ALL})
+  public static final SqlFunction CSC =
+      SqlBasicFunction.create("CSC",
+          ReturnTypes.DOUBLE_NULLABLE,

Review Comment:
   As we discussed in [CALCITE-5599](https://issues.apache.org/jira/browse/CALCITE-5599), we think trigonometric functions are very common, so we add all these functions to library ALL. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org