[GitHub] cgivre commented on issue #6610: Add support to Apache Drill

[GitBox <gi...@apache.org>]

cgivre commented on issue #6610: Add support to Apache Drill
URL: https://github.com/apache/incubator-superset/pull/6610#issuecomment-457622047
 
 
   
   There is one small issue with this PR that I would really like to resolve but I'm a little stuck on. 
   I have Superset connected to Drill and Drill connected to a MySQL database.  Superset is correctly getting the tables, and schemata!
   (Yay!)
   When you try to access a file-based table via Drill, there’s one small problem.
   As I mentioned in the PR, the issue is that filenames have dots in them, so when the schema was being passed to Superset you might have something like this
   `dfs.test.somefile.csv`
   The problem being that when Superset parses that, it parses that fourth period as a part of the namespace rather than a file extension
   So… the workaround I found was, in the dropdown in sqllab, replace the value (not the label) with `@@@` so that it gets parsed correctly.
   This works as shown below:
   
   ![screen shot 2019-01-21 at 16 46 51](https://user-images.githubusercontent.com/5513150/51756888-099a5700-2090-11e9-9ece-4c54cc397535.png)
   
   Here's where I'm stuck. 
   
   In all the other functions where I could find this, I added a hook to clean up the file name, specifically, to look for `@@@` and replace it with a `.`.
   I can’t seem to find the code that generates the heading for the table preview and the heading for the column listing.   Once I can figure this out, I think Drill will pretty much work perfectly with Superset!!  Any suggestions would be greatly appreciated.  @mistercrunch @kristw 
   
   ![screen shot 2019-01-21 at 16 48 10](https://user-images.githubusercontent.com/5513150/51757144-a4933100-2090-11e9-8c0f-567080542a7e.png)
   
   Thanks!!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org