[GitHub] [skywalking] wu-sheng commented on issue #5653: http async client does not create span

[GitBox <gi...@apache.org>]

wu-sheng commented on issue #5653:
URL: https://github.com/apache/skywalking/issues/5653#issuecomment-756467286


   Hi, I am not very familiar with the codes of this part, so the following answer would be based on your description only.
   ____
   The key usage of `SessionRequestConstructorInterceptor` is for propagating the tracing context into the async thread through `#setSkyWalkingDynamicField`. When(no matter what is the right way to use httpclient) you do from a connection pool, the execution should be also in another thread(right?). You need to find a place the thread-switch happens, and update `SessionRequestImpl`. `SessionRequestImpl` should only be used in one thread at once, right?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org