You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@avro.apache.org by GitBox <gi...@apache.org> on 2020/12/11 16:41:04 UTC

[GitHub] [avro] tjwp commented on a change in pull request #1037: AVRO-2999: Optimize Ruby union encoding

tjwp commented on a change in pull request #1037:
URL: https://github.com/apache/avro/pull/1037#discussion_r541077947



##########
File path: lang/ruby/lib/avro/schema_validator.rb
##########
@@ -62,12 +70,11 @@ def to_s
     TypeMismatchError = Class.new(ValidationError)
 
     class << self
-      def validate!(expected_schema, logical_datum, options = { recursive: true, encoded: false, fail_on_extra_fields: false })
+      def validate!(expected_schema, logical_datum, options = DEFAULT_VALIDATION_OPTIONS)
         options ||= {}

Review comment:
       Should the default here be replaced with a frozen constant, or should the line be removed entirely? It would only be used if `options` is explicitly passed as something falsey.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org