You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2021/03/03 14:40:09 UTC
[GitHub] [servicecomb-pack] coolbeevip opened a new pull request #703: WIP: [SCB-2205] Fix pull request and push trigger condition
coolbeevip opened a new pull request #703:
URL: https://github.com/apache/servicecomb-pack/pull/703
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-pack] coveralls commented on pull request #703: WIP: [SCB-2205] Polishing Github actions workflow
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #703:
URL: https://github.com/apache/servicecomb-pack/pull/703#issuecomment-789791427
[](https://coveralls.io/builds/37618848)
Coverage decreased (-0.02%) to 80.677% when pulling **ddadcce8d3c934c383e036e9b5aa152da6a1b3cd on coolbeevip:SCB-2205** into **6033905e3d71ea4586dbbd75c418c50fd5bd2638 on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-pack] coolbeevip closed pull request #703: WIP: [SCB-2205] Polishing Github actions workflow
Posted by GitBox <gi...@apache.org>.
coolbeevip closed pull request #703:
URL: https://github.com/apache/servicecomb-pack/pull/703
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-pack] coolbeevip commented on a change in pull request #703: [SCB-2205] Polishing Github actions workflow
Posted by GitBox <gi...@apache.org>.
coolbeevip commented on a change in pull request #703:
URL: https://github.com/apache/servicecomb-pack/pull/703#discussion_r594883774
##########
File path: .github/workflows/master-pr-build.yaml
##########
@@ -0,0 +1,68 @@
+## ---------------------------------------------------------------------------
+## Licensed to the Apache Software Foundation (ASF) under one or more
+## contributor license agreements. See the NOTICE file distributed with
+## this work for additional information regarding copyright ownership.
+## The ASF licenses this file to You under the Apache License, Version 2.0
+## (the "License"); you may not use this file except in compliance with
+## the License. You may obtain a copy of the License at
+##
+## http://www.apache.org/licenses/LICENSE-2.0
+##
+## Unless required by applicable law or agreed to in writing, software
+## distributed under the License is distributed on an "AS IS" BASIS,
+## WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+## See the License for the specific language governing permissions and
+## limitations under the License.
+## ---------------------------------------------------------------------------
+
+name: master pr build
+
+on:
+ pull_request:
+ branches:
+ - master
+
+env:
+ MAVEN_OPTS: -Xmx4g -Xms1g -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false -Dmaven.wagon.http.retryHandler.count=3
+
+jobs:
+ mvn:
+ timeout-minutes: 180
+ runs-on: ubuntu-20.04
+ strategy:
+ matrix:
+ java: [ '1.8' ]
+ steps:
+ - uses: actions/checkout@v2
+ with:
+ persist-credentials: false
+ - name: Set up JDK ${{ matrix.java }}
+ uses: actions/setup-java@v1
+ with:
+ java-version: ${{ matrix.java }}
+ - name: Cache Maven Repository
+ uses: actions/cache@v2
+ with:
+ path: |
+ ~/.m2/repository/
+ !~/.m2/repository/org/apache/servicecomb
+ key: ${{ runner.os }}-m2-${{ hashFiles('**/pom.xml') }}
+ restore-keys: ${{ runner.os }}-m2
+ - name: Show the first log message
+ run: git log -n1
+ - name: Build and test
+ if: ${{ success() }}
+ run: ./mvnw clean install -B -Pjacoco -Pdocker coveralls:report -DrepoToken=ftogh57jTQ0GRa4AaOgFfltiUrwnO8tw9
Review comment:
> The token string should be used in environment variables ?
secrets are not passed to the runner when a workflow is triggered from a forked repository.
As GitHub stuff answered [here](https://github.community/t/make-secrets-available-to-builds-of-forks/16166/14)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-pack] coveralls edited a comment on pull request #703: WIP: [SCB-2205] Polishing Github actions workflow
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #703:
URL: https://github.com/apache/servicecomb-pack/pull/703#issuecomment-789791427
[](https://coveralls.io/builds/37913028)
Coverage decreased (-0.02%) to 80.677% when pulling **1645d2dee0d0140c1922b91fbb7a85fc3b9fa633 on coolbeevip:SCB-2205** into **6033905e3d71ea4586dbbd75c418c50fd5bd2638 on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-pack] WillemJiang commented on a change in pull request #703: [SCB-2205] Polishing Github actions workflow
Posted by GitBox <gi...@apache.org>.
WillemJiang commented on a change in pull request #703:
URL: https://github.com/apache/servicecomb-pack/pull/703#discussion_r594881779
##########
File path: .github/workflows/master-pr-build.yaml
##########
@@ -0,0 +1,68 @@
+## ---------------------------------------------------------------------------
+## Licensed to the Apache Software Foundation (ASF) under one or more
+## contributor license agreements. See the NOTICE file distributed with
+## this work for additional information regarding copyright ownership.
+## The ASF licenses this file to You under the Apache License, Version 2.0
+## (the "License"); you may not use this file except in compliance with
+## the License. You may obtain a copy of the License at
+##
+## http://www.apache.org/licenses/LICENSE-2.0
+##
+## Unless required by applicable law or agreed to in writing, software
+## distributed under the License is distributed on an "AS IS" BASIS,
+## WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+## See the License for the specific language governing permissions and
+## limitations under the License.
+## ---------------------------------------------------------------------------
+
+name: master pr build
+
+on:
+ pull_request:
+ branches:
+ - master
+
+env:
+ MAVEN_OPTS: -Xmx4g -Xms1g -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false -Dmaven.wagon.http.retryHandler.count=3
+
+jobs:
+ mvn:
+ timeout-minutes: 180
+ runs-on: ubuntu-20.04
Review comment:
it's better to specify the ubuntu version.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-pack] coveralls edited a comment on pull request #703: WIP: [SCB-2205] Polishing Github actions workflow
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #703:
URL: https://github.com/apache/servicecomb-pack/pull/703#issuecomment-789791427
[](https://coveralls.io/builds/37912844)
Coverage decreased (-0.04%) to 80.656% when pulling **1efee774274d965d7e176594fe30f449f3fd77a5 on coolbeevip:SCB-2205** into **6033905e3d71ea4586dbbd75c418c50fd5bd2638 on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-pack] coveralls edited a comment on pull request #703: WIP: [SCB-2205] Polishing Github actions workflow
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #703:
URL: https://github.com/apache/servicecomb-pack/pull/703#issuecomment-789791427
[](https://coveralls.io/builds/37644996)
Coverage remained the same at 80.698% when pulling **6545528b86c0138e9bcf016875b23ceddcd86f2f on coolbeevip:SCB-2205** into **6033905e3d71ea4586dbbd75c418c50fd5bd2638 on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-pack] coolbeevip commented on a change in pull request #703: [SCB-2205] Polishing Github actions workflow
Posted by GitBox <gi...@apache.org>.
coolbeevip commented on a change in pull request #703:
URL: https://github.com/apache/servicecomb-pack/pull/703#discussion_r594896929
##########
File path: acceptance-tests/acceptance-pack-akka-spring-demo/src/test/resources/alpha_records_transaction_events.feature
##########
@@ -168,27 +168,28 @@ Feature: Alpha records transaction events
Then Hotel Service contains the following booking orders
| id | name | amount | confirmed | cancelled |
- Scenario: 7.Hotel sub-transaction failed and Car sub-transaction compensate failed and global transaction suspended
- Given Car Service is up and running
- And Hotel Service is up and running
- And Booking Service is up and running
- And Alpha is up and running
- Given Install the byteman script car_compensate_failed_retry.btm to Car Service
- When User Sean requests to book 5 cars and 3 rooms fail
- Then Alpha records the following events
- | serviceName | type |
- | booking | SagaStartedEvent |
- | car | TxStartedEvent |
- | car | TxEndedEvent |
- | hotel | TxStartedEvent |
- | hotel | TxAbortedEvent |
- | booking | SagaAbortedEvent |
- | car | TxCompensateAckFailedEvent |
- | car | TxCompensateAckFailedEvent |
-
- Then Car Service contains the following booking orders
- | id | name | amount | confirmed | cancelled |
- | 1 | Sean | 5 | true | false |
-
- Then Hotel Service contains the following booking orders
- | id | name | amount | confirmed | cancelled |
+# Scenario: 7.Hotel sub-transaction failed and Car sub-transaction compensate failed and global transaction suspended
+# Given Car Service is up and running
+# And Hotel Service is up and running
+# And Booking Service is up and running
+# And Alpha is up and running
+# Given Install the byteman script car_compensate_failed_retry.btm to Car Service
+# When User Sean requests to book 5 cars and 3 rooms fail
+# Then Alpha records the following events
+# | serviceName | type |
+# | booking | SagaStartedEvent |
+# | car | TxStartedEvent |
+# | car | TxEndedEvent |
+# | hotel | TxStartedEvent |
+# | hotel | TxAbortedEvent |
+# | booking | SagaAbortedEvent |
+# | car | TxCompensateAckFailedEvent |
+# | car | TxCompensateAckFailedEvent |
+# | car | TxCompensateAckFailedEvent |
+#
+# Then Car Service contains the following booking orders
+# | id | name | amount | confirmed | cancelled |
+# | 1 | Sean | 5 | true | false |
+#
+# Then Hotel Service contains the following booking orders
+# | id | name | amount | confirmed | cancelled |
Review comment:
> Thanks - please add the JIRA issue link here and we can track it easier
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-pack] coolbeevip commented on a change in pull request #703: [SCB-2205] Polishing Github actions workflow
Posted by GitBox <gi...@apache.org>.
coolbeevip commented on a change in pull request #703:
URL: https://github.com/apache/servicecomb-pack/pull/703#discussion_r594891984
##########
File path: .github/workflows/master-pr-build.yaml
##########
@@ -0,0 +1,68 @@
+## ---------------------------------------------------------------------------
+## Licensed to the Apache Software Foundation (ASF) under one or more
+## contributor license agreements. See the NOTICE file distributed with
+## this work for additional information regarding copyright ownership.
+## The ASF licenses this file to You under the Apache License, Version 2.0
+## (the "License"); you may not use this file except in compliance with
+## the License. You may obtain a copy of the License at
+##
+## http://www.apache.org/licenses/LICENSE-2.0
+##
+## Unless required by applicable law or agreed to in writing, software
+## distributed under the License is distributed on an "AS IS" BASIS,
+## WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+## See the License for the specific language governing permissions and
+## limitations under the License.
+## ---------------------------------------------------------------------------
+
+name: master pr build
+
+on:
+ pull_request:
+ branches:
+ - master
+
+env:
+ MAVEN_OPTS: -Xmx4g -Xms1g -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false -Dmaven.wagon.http.retryHandler.count=3
+
+jobs:
+ mvn:
+ timeout-minutes: 180
+ runs-on: ubuntu-20.04
+ strategy:
+ matrix:
+ java: [ '1.8' ]
+ steps:
+ - uses: actions/checkout@v2
+ with:
+ persist-credentials: false
+ - name: Set up JDK ${{ matrix.java }}
+ uses: actions/setup-java@v1
+ with:
+ java-version: ${{ matrix.java }}
+ - name: Cache Maven Repository
+ uses: actions/cache@v2
+ with:
+ path: |
+ ~/.m2/repository/
+ !~/.m2/repository/org/apache/servicecomb
+ key: ${{ runner.os }}-m2-${{ hashFiles('**/pom.xml') }}
+ restore-keys: ${{ runner.os }}-m2
+ - name: Show the first log message
+ run: git log -n1
+ - name: Build and test
+ if: ${{ success() }}
+ run: ./mvnw clean install -B -Pjacoco -Pdocker coveralls:report -DrepoToken=ftogh57jTQ0GRa4AaOgFfltiUrwnO8tw9
Review comment:
The token has been set to GitHub secrets with https://issues.apache.org/jira/browse/INFRA-21569 and uses secrets.COVERALLS_TOKEN in push workflow.
If we do not analyze the coverage in the pull request, we can remove the plaintext token
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-pack] coveralls edited a comment on pull request #703: WIP: [SCB-2205] Polishing Github actions workflow
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #703:
URL: https://github.com/apache/servicecomb-pack/pull/703#issuecomment-789791427
[](https://coveralls.io/builds/37636693)
Coverage remained the same at 80.698% when pulling **4f01281ccf019a86299283ddefeed4bb334da01c on coolbeevip:SCB-2205** into **6033905e3d71ea4586dbbd75c418c50fd5bd2638 on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-pack] chanjarster commented on pull request #703: [SCB-2205] Polishing Github actions workflow
Posted by GitBox <gi...@apache.org>.
chanjarster commented on pull request #703:
URL: https://github.com/apache/servicecomb-pack/pull/703#issuecomment-799965886
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-pack] coveralls edited a comment on pull request #703: WIP: [SCB-2205] Polishing Github actions workflow
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #703:
URL: https://github.com/apache/servicecomb-pack/pull/703#issuecomment-789791427
[](https://coveralls.io/builds/37913093)
Coverage decreased (-0.02%) to 80.677% when pulling **1645d2dee0d0140c1922b91fbb7a85fc3b9fa633 on coolbeevip:SCB-2205** into **6033905e3d71ea4586dbbd75c418c50fd5bd2638 on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-pack] zhfeng commented on a change in pull request #703: [SCB-2205] Polishing Github actions workflow
Posted by GitBox <gi...@apache.org>.
zhfeng commented on a change in pull request #703:
URL: https://github.com/apache/servicecomb-pack/pull/703#discussion_r594896321
##########
File path: .github/workflows/master-pr-build.yaml
##########
@@ -0,0 +1,68 @@
+## ---------------------------------------------------------------------------
+## Licensed to the Apache Software Foundation (ASF) under one or more
+## contributor license agreements. See the NOTICE file distributed with
+## this work for additional information regarding copyright ownership.
+## The ASF licenses this file to You under the Apache License, Version 2.0
+## (the "License"); you may not use this file except in compliance with
+## the License. You may obtain a copy of the License at
+##
+## http://www.apache.org/licenses/LICENSE-2.0
+##
+## Unless required by applicable law or agreed to in writing, software
+## distributed under the License is distributed on an "AS IS" BASIS,
+## WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+## See the License for the specific language governing permissions and
+## limitations under the License.
+## ---------------------------------------------------------------------------
+
+name: master pr build
+
+on:
+ pull_request:
+ branches:
+ - master
+
+env:
+ MAVEN_OPTS: -Xmx4g -Xms1g -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false -Dmaven.wagon.http.retryHandler.count=3
+
+jobs:
+ mvn:
+ timeout-minutes: 180
+ runs-on: ubuntu-20.04
+ strategy:
+ matrix:
+ java: [ '1.8' ]
+ steps:
+ - uses: actions/checkout@v2
+ with:
+ persist-credentials: false
+ - name: Set up JDK ${{ matrix.java }}
+ uses: actions/setup-java@v1
+ with:
+ java-version: ${{ matrix.java }}
+ - name: Cache Maven Repository
+ uses: actions/cache@v2
+ with:
+ path: |
+ ~/.m2/repository/
+ !~/.m2/repository/org/apache/servicecomb
+ key: ${{ runner.os }}-m2-${{ hashFiles('**/pom.xml') }}
+ restore-keys: ${{ runner.os }}-m2
+ - name: Show the first log message
+ run: git log -n1
+ - name: Build and test
+ if: ${{ success() }}
+ run: ./mvnw clean install -B -Pjacoco -Pdocker coveralls:report -DrepoToken=ftogh57jTQ0GRa4AaOgFfltiUrwnO8tw9
Review comment:
hmm, I prefer to disable the coverage in PR now and see if we can have a better solution in the future. How do you think @WillemJiang
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-pack] zhfeng merged pull request #703: [SCB-2205] Polishing Github actions workflow
Posted by GitBox <gi...@apache.org>.
zhfeng merged pull request #703:
URL: https://github.com/apache/servicecomb-pack/pull/703
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-pack] coveralls edited a comment on pull request #703: WIP: [SCB-2205] Polishing Github actions workflow
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #703:
URL: https://github.com/apache/servicecomb-pack/pull/703#issuecomment-789791427
[](https://coveralls.io/builds/37912806)
Coverage increased (+0.02%) to 80.718% when pulling **f2e89a646be8d71eab454dbc2925a98e7332aa73 on coolbeevip:SCB-2205** into **6033905e3d71ea4586dbbd75c418c50fd5bd2638 on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-pack] zhfeng commented on a change in pull request #703: [SCB-2205] Polishing Github actions workflow
Posted by GitBox <gi...@apache.org>.
zhfeng commented on a change in pull request #703:
URL: https://github.com/apache/servicecomb-pack/pull/703#discussion_r594887080
##########
File path: .github/workflows/master-pr-build.yaml
##########
@@ -0,0 +1,68 @@
+## ---------------------------------------------------------------------------
+## Licensed to the Apache Software Foundation (ASF) under one or more
+## contributor license agreements. See the NOTICE file distributed with
+## this work for additional information regarding copyright ownership.
+## The ASF licenses this file to You under the Apache License, Version 2.0
+## (the "License"); you may not use this file except in compliance with
+## the License. You may obtain a copy of the License at
+##
+## http://www.apache.org/licenses/LICENSE-2.0
+##
+## Unless required by applicable law or agreed to in writing, software
+## distributed under the License is distributed on an "AS IS" BASIS,
+## WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+## See the License for the specific language governing permissions and
+## limitations under the License.
+## ---------------------------------------------------------------------------
+
+name: master pr build
+
+on:
+ pull_request:
+ branches:
+ - master
+
+env:
+ MAVEN_OPTS: -Xmx4g -Xms1g -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false -Dmaven.wagon.http.retryHandler.count=3
+
+jobs:
+ mvn:
+ timeout-minutes: 180
+ runs-on: ubuntu-20.04
+ strategy:
+ matrix:
+ java: [ '1.8' ]
+ steps:
+ - uses: actions/checkout@v2
+ with:
+ persist-credentials: false
+ - name: Set up JDK ${{ matrix.java }}
+ uses: actions/setup-java@v1
+ with:
+ java-version: ${{ matrix.java }}
+ - name: Cache Maven Repository
+ uses: actions/cache@v2
+ with:
+ path: |
+ ~/.m2/repository/
+ !~/.m2/repository/org/apache/servicecomb
+ key: ${{ runner.os }}-m2-${{ hashFiles('**/pom.xml') }}
+ restore-keys: ${{ runner.os }}-m2
+ - name: Show the first log message
+ run: git log -n1
+ - name: Build and test
+ if: ${{ success() }}
+ run: ./mvnw clean install -B -Pjacoco -Pdocker coveralls:report -DrepoToken=ftogh57jTQ0GRa4AaOgFfltiUrwnO8tw9
Review comment:
OK, I see. so is there any other problem we provide the token in plain text here ? this token could be changed in the future ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-pack] coveralls edited a comment on pull request #703: WIP: [SCB-2205] Polishing Github actions workflow
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #703:
URL: https://github.com/apache/servicecomb-pack/pull/703#issuecomment-789791427
[](https://coveralls.io/builds/37623351)
Coverage decreased (-0.04%) to 80.656% when pulling **4f01281ccf019a86299283ddefeed4bb334da01c on coolbeevip:SCB-2205** into **6033905e3d71ea4586dbbd75c418c50fd5bd2638 on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-pack] coolbeevip commented on a change in pull request #703: [SCB-2205] Polishing Github actions workflow
Posted by GitBox <gi...@apache.org>.
coolbeevip commented on a change in pull request #703:
URL: https://github.com/apache/servicecomb-pack/pull/703#discussion_r594884533
##########
File path: acceptance-tests/acceptance-pack-akka-spring-demo/src/test/resources/alpha_records_transaction_events.feature
##########
@@ -168,27 +168,28 @@ Feature: Alpha records transaction events
Then Hotel Service contains the following booking orders
| id | name | amount | confirmed | cancelled |
- Scenario: 7.Hotel sub-transaction failed and Car sub-transaction compensate failed and global transaction suspended
- Given Car Service is up and running
- And Hotel Service is up and running
- And Booking Service is up and running
- And Alpha is up and running
- Given Install the byteman script car_compensate_failed_retry.btm to Car Service
- When User Sean requests to book 5 cars and 3 rooms fail
- Then Alpha records the following events
- | serviceName | type |
- | booking | SagaStartedEvent |
- | car | TxStartedEvent |
- | car | TxEndedEvent |
- | hotel | TxStartedEvent |
- | hotel | TxAbortedEvent |
- | booking | SagaAbortedEvent |
- | car | TxCompensateAckFailedEvent |
- | car | TxCompensateAckFailedEvent |
-
- Then Car Service contains the following booking orders
- | id | name | amount | confirmed | cancelled |
- | 1 | Sean | 5 | true | false |
-
- Then Hotel Service contains the following booking orders
- | id | name | amount | confirmed | cancelled |
+# Scenario: 7.Hotel sub-transaction failed and Car sub-transaction compensate failed and global transaction suspended
+# Given Car Service is up and running
+# And Hotel Service is up and running
+# And Booking Service is up and running
+# And Alpha is up and running
+# Given Install the byteman script car_compensate_failed_retry.btm to Car Service
+# When User Sean requests to book 5 cars and 3 rooms fail
+# Then Alpha records the following events
+# | serviceName | type |
+# | booking | SagaStartedEvent |
+# | car | TxStartedEvent |
+# | car | TxEndedEvent |
+# | hotel | TxStartedEvent |
+# | hotel | TxAbortedEvent |
+# | booking | SagaAbortedEvent |
+# | car | TxCompensateAckFailedEvent |
+# | car | TxCompensateAckFailedEvent |
+# | car | TxCompensateAckFailedEvent |
+#
+# Then Car Service contains the following booking orders
+# | id | name | amount | confirmed | cancelled |
+# | 1 | Sean | 5 | true | false |
+#
+# Then Hotel Service contains the following booking orders
+# | id | name | amount | confirmed | cancelled |
Review comment:
This is an unstable test case, I created a JIRA https://issues.apache.org/jira/browse/SCB-2204 for it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-pack] coolbeevip commented on a change in pull request #703: [SCB-2205] Polishing Github actions workflow
Posted by GitBox <gi...@apache.org>.
coolbeevip commented on a change in pull request #703:
URL: https://github.com/apache/servicecomb-pack/pull/703#discussion_r594885235
##########
File path: .github/workflows/master-pr-build.yaml
##########
@@ -0,0 +1,68 @@
+## ---------------------------------------------------------------------------
+## Licensed to the Apache Software Foundation (ASF) under one or more
+## contributor license agreements. See the NOTICE file distributed with
+## this work for additional information regarding copyright ownership.
+## The ASF licenses this file to You under the Apache License, Version 2.0
+## (the "License"); you may not use this file except in compliance with
+## the License. You may obtain a copy of the License at
+##
+## http://www.apache.org/licenses/LICENSE-2.0
+##
+## Unless required by applicable law or agreed to in writing, software
+## distributed under the License is distributed on an "AS IS" BASIS,
+## WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+## See the License for the specific language governing permissions and
+## limitations under the License.
+## ---------------------------------------------------------------------------
+
+name: master pr build
+
+on:
+ pull_request:
+ branches:
+ - master
+
+env:
+ MAVEN_OPTS: -Xmx4g -Xms1g -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false -Dmaven.wagon.http.retryHandler.count=3
+
+jobs:
+ mvn:
+ timeout-minutes: 180
+ runs-on: ubuntu-20.04
Review comment:
Yep, Ubuntu-latest workflows will use Ubuntu-20.04
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-pack] zhfeng commented on a change in pull request #703: [SCB-2205] Polishing Github actions workflow
Posted by GitBox <gi...@apache.org>.
zhfeng commented on a change in pull request #703:
URL: https://github.com/apache/servicecomb-pack/pull/703#discussion_r594881037
##########
File path: acceptance-tests/acceptance-pack-akka-spring-demo/src/test/resources/alpha_records_transaction_events.feature
##########
@@ -168,27 +168,28 @@ Feature: Alpha records transaction events
Then Hotel Service contains the following booking orders
| id | name | amount | confirmed | cancelled |
- Scenario: 7.Hotel sub-transaction failed and Car sub-transaction compensate failed and global transaction suspended
- Given Car Service is up and running
- And Hotel Service is up and running
- And Booking Service is up and running
- And Alpha is up and running
- Given Install the byteman script car_compensate_failed_retry.btm to Car Service
- When User Sean requests to book 5 cars and 3 rooms fail
- Then Alpha records the following events
- | serviceName | type |
- | booking | SagaStartedEvent |
- | car | TxStartedEvent |
- | car | TxEndedEvent |
- | hotel | TxStartedEvent |
- | hotel | TxAbortedEvent |
- | booking | SagaAbortedEvent |
- | car | TxCompensateAckFailedEvent |
- | car | TxCompensateAckFailedEvent |
-
- Then Car Service contains the following booking orders
- | id | name | amount | confirmed | cancelled |
- | 1 | Sean | 5 | true | false |
-
- Then Hotel Service contains the following booking orders
- | id | name | amount | confirmed | cancelled |
+# Scenario: 7.Hotel sub-transaction failed and Car sub-transaction compensate failed and global transaction suspended
+# Given Car Service is up and running
+# And Hotel Service is up and running
+# And Booking Service is up and running
+# And Alpha is up and running
+# Given Install the byteman script car_compensate_failed_retry.btm to Car Service
+# When User Sean requests to book 5 cars and 3 rooms fail
+# Then Alpha records the following events
+# | serviceName | type |
+# | booking | SagaStartedEvent |
+# | car | TxStartedEvent |
+# | car | TxEndedEvent |
+# | hotel | TxStartedEvent |
+# | hotel | TxAbortedEvent |
+# | booking | SagaAbortedEvent |
+# | car | TxCompensateAckFailedEvent |
+# | car | TxCompensateAckFailedEvent |
+# | car | TxCompensateAckFailedEvent |
+#
+# Then Car Service contains the following booking orders
+# | id | name | amount | confirmed | cancelled |
+# | 1 | Sean | 5 | true | false |
+#
+# Then Hotel Service contains the following booking orders
+# | id | name | amount | confirmed | cancelled |
Review comment:
why we disable this scenario ?
##########
File path: .github/workflows/master-pr-build.yaml
##########
@@ -0,0 +1,68 @@
+## ---------------------------------------------------------------------------
+## Licensed to the Apache Software Foundation (ASF) under one or more
+## contributor license agreements. See the NOTICE file distributed with
+## this work for additional information regarding copyright ownership.
+## The ASF licenses this file to You under the Apache License, Version 2.0
+## (the "License"); you may not use this file except in compliance with
+## the License. You may obtain a copy of the License at
+##
+## http://www.apache.org/licenses/LICENSE-2.0
+##
+## Unless required by applicable law or agreed to in writing, software
+## distributed under the License is distributed on an "AS IS" BASIS,
+## WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+## See the License for the specific language governing permissions and
+## limitations under the License.
+## ---------------------------------------------------------------------------
+
+name: master pr build
+
+on:
+ pull_request:
+ branches:
+ - master
+
+env:
+ MAVEN_OPTS: -Xmx4g -Xms1g -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false -Dmaven.wagon.http.retryHandler.count=3
+
+jobs:
+ mvn:
+ timeout-minutes: 180
+ runs-on: ubuntu-20.04
+ strategy:
+ matrix:
+ java: [ '1.8' ]
+ steps:
+ - uses: actions/checkout@v2
+ with:
+ persist-credentials: false
+ - name: Set up JDK ${{ matrix.java }}
+ uses: actions/setup-java@v1
+ with:
+ java-version: ${{ matrix.java }}
+ - name: Cache Maven Repository
+ uses: actions/cache@v2
+ with:
+ path: |
+ ~/.m2/repository/
+ !~/.m2/repository/org/apache/servicecomb
+ key: ${{ runner.os }}-m2-${{ hashFiles('**/pom.xml') }}
+ restore-keys: ${{ runner.os }}-m2
+ - name: Show the first log message
+ run: git log -n1
+ - name: Build and test
+ if: ${{ success() }}
+ run: ./mvnw clean install -B -Pjacoco -Pdocker coveralls:report -DrepoToken=ftogh57jTQ0GRa4AaOgFfltiUrwnO8tw9
Review comment:
The token string should be used in environment variables ?
##########
File path: .github/workflows/master-pr-build.yaml
##########
@@ -0,0 +1,68 @@
+## ---------------------------------------------------------------------------
+## Licensed to the Apache Software Foundation (ASF) under one or more
+## contributor license agreements. See the NOTICE file distributed with
+## this work for additional information regarding copyright ownership.
+## The ASF licenses this file to You under the Apache License, Version 2.0
+## (the "License"); you may not use this file except in compliance with
+## the License. You may obtain a copy of the License at
+##
+## http://www.apache.org/licenses/LICENSE-2.0
+##
+## Unless required by applicable law or agreed to in writing, software
+## distributed under the License is distributed on an "AS IS" BASIS,
+## WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+## See the License for the specific language governing permissions and
+## limitations under the License.
+## ---------------------------------------------------------------------------
+
+name: master pr build
+
+on:
+ pull_request:
+ branches:
+ - master
+
+env:
+ MAVEN_OPTS: -Xmx4g -Xms1g -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false -Dmaven.wagon.http.retryHandler.count=3
+
+jobs:
+ mvn:
+ timeout-minutes: 180
+ runs-on: ubuntu-20.04
Review comment:
why we stick on this ubuntu version 20.04, it can be the 'lastest' ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-pack] coveralls edited a comment on pull request #703: WIP: [SCB-2205] Polishing Github actions workflow
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #703:
URL: https://github.com/apache/servicecomb-pack/pull/703#issuecomment-789791427
[](https://coveralls.io/builds/37619930)
Coverage remained the same at 80.698% when pulling **fde5f1d546c595538f6ba0c5d5ca8d4665482db9 on coolbeevip:SCB-2205** into **6033905e3d71ea4586dbbd75c418c50fd5bd2638 on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-pack] zhfeng commented on a change in pull request #703: [SCB-2205] Polishing Github actions workflow
Posted by GitBox <gi...@apache.org>.
zhfeng commented on a change in pull request #703:
URL: https://github.com/apache/servicecomb-pack/pull/703#discussion_r594887693
##########
File path: acceptance-tests/acceptance-pack-akka-spring-demo/src/test/resources/alpha_records_transaction_events.feature
##########
@@ -168,27 +168,28 @@ Feature: Alpha records transaction events
Then Hotel Service contains the following booking orders
| id | name | amount | confirmed | cancelled |
- Scenario: 7.Hotel sub-transaction failed and Car sub-transaction compensate failed and global transaction suspended
- Given Car Service is up and running
- And Hotel Service is up and running
- And Booking Service is up and running
- And Alpha is up and running
- Given Install the byteman script car_compensate_failed_retry.btm to Car Service
- When User Sean requests to book 5 cars and 3 rooms fail
- Then Alpha records the following events
- | serviceName | type |
- | booking | SagaStartedEvent |
- | car | TxStartedEvent |
- | car | TxEndedEvent |
- | hotel | TxStartedEvent |
- | hotel | TxAbortedEvent |
- | booking | SagaAbortedEvent |
- | car | TxCompensateAckFailedEvent |
- | car | TxCompensateAckFailedEvent |
-
- Then Car Service contains the following booking orders
- | id | name | amount | confirmed | cancelled |
- | 1 | Sean | 5 | true | false |
-
- Then Hotel Service contains the following booking orders
- | id | name | amount | confirmed | cancelled |
+# Scenario: 7.Hotel sub-transaction failed and Car sub-transaction compensate failed and global transaction suspended
+# Given Car Service is up and running
+# And Hotel Service is up and running
+# And Booking Service is up and running
+# And Alpha is up and running
+# Given Install the byteman script car_compensate_failed_retry.btm to Car Service
+# When User Sean requests to book 5 cars and 3 rooms fail
+# Then Alpha records the following events
+# | serviceName | type |
+# | booking | SagaStartedEvent |
+# | car | TxStartedEvent |
+# | car | TxEndedEvent |
+# | hotel | TxStartedEvent |
+# | hotel | TxAbortedEvent |
+# | booking | SagaAbortedEvent |
+# | car | TxCompensateAckFailedEvent |
+# | car | TxCompensateAckFailedEvent |
+# | car | TxCompensateAckFailedEvent |
+#
+# Then Car Service contains the following booking orders
+# | id | name | amount | confirmed | cancelled |
+# | 1 | Sean | 5 | true | false |
+#
+# Then Hotel Service contains the following booking orders
+# | id | name | amount | confirmed | cancelled |
Review comment:
Thanks - please add the JIRA issue link here and we can track it easier
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-pack] coolbeevip commented on a change in pull request #703: [SCB-2205] Polishing Github actions workflow
Posted by GitBox <gi...@apache.org>.
coolbeevip commented on a change in pull request #703:
URL: https://github.com/apache/servicecomb-pack/pull/703#discussion_r594940200
##########
File path: .github/workflows/master-pr-build.yaml
##########
@@ -0,0 +1,68 @@
+## ---------------------------------------------------------------------------
+## Licensed to the Apache Software Foundation (ASF) under one or more
+## contributor license agreements. See the NOTICE file distributed with
+## this work for additional information regarding copyright ownership.
+## The ASF licenses this file to You under the Apache License, Version 2.0
+## (the "License"); you may not use this file except in compliance with
+## the License. You may obtain a copy of the License at
+##
+## http://www.apache.org/licenses/LICENSE-2.0
+##
+## Unless required by applicable law or agreed to in writing, software
+## distributed under the License is distributed on an "AS IS" BASIS,
+## WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+## See the License for the specific language governing permissions and
+## limitations under the License.
+## ---------------------------------------------------------------------------
+
+name: master pr build
+
+on:
+ pull_request:
+ branches:
+ - master
+
+env:
+ MAVEN_OPTS: -Xmx4g -Xms1g -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false -Dmaven.wagon.http.retryHandler.count=3
+
+jobs:
+ mvn:
+ timeout-minutes: 180
+ runs-on: ubuntu-20.04
+ strategy:
+ matrix:
+ java: [ '1.8' ]
+ steps:
+ - uses: actions/checkout@v2
+ with:
+ persist-credentials: false
+ - name: Set up JDK ${{ matrix.java }}
+ uses: actions/setup-java@v1
+ with:
+ java-version: ${{ matrix.java }}
+ - name: Cache Maven Repository
+ uses: actions/cache@v2
+ with:
+ path: |
+ ~/.m2/repository/
+ !~/.m2/repository/org/apache/servicecomb
+ key: ${{ runner.os }}-m2-${{ hashFiles('**/pom.xml') }}
+ restore-keys: ${{ runner.os }}-m2
+ - name: Show the first log message
+ run: git log -n1
+ - name: Build and test
+ if: ${{ success() }}
+ run: ./mvnw clean install -B -Pjacoco -Pdocker coveralls:report -DrepoToken=ftogh57jTQ0GRa4AaOgFfltiUrwnO8tw9
Review comment:
> hmm, I prefer to disable the coverage in PR now and see if we can have a better solution in the future. How do you think @WillemJiang
I removed the Coveralls report token from the pull request script
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org