You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by du...@apache.org on 2022/02/23 06:54:52 UTC

[shardingsphere] branch master updated: Reduce allocations in SubqueryExtractUtil (#15577)

This is an automated email from the ASF dual-hosted git repository.

duanzhengqiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new 79c3c2e  Reduce allocations in SubqueryExtractUtil (#15577)
79c3c2e is described below

commit 79c3c2e898e98f20758412f281745c36c1144333
Author: 吴伟杰 <wu...@apache.org>
AuthorDate: Wed Feb 23 14:53:58 2022 +0800

    Reduce allocations in SubqueryExtractUtil (#15577)
---
 .../sql/common/util/SubqueryExtractUtil.java       | 58 +++++++++++-----------
 1 file changed, 28 insertions(+), 30 deletions(-)

diff --git a/shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/util/SubqueryExtractUtil.java b/shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/util/SubqueryExtractUtil.java
index bde0a6e..be261ba 100644
--- a/shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/util/SubqueryExtractUtil.java
+++ b/shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/util/SubqueryExtractUtil.java
@@ -37,8 +37,8 @@ import org.apache.shardingsphere.sql.parser.sql.common.segment.generic.table.Tab
 import org.apache.shardingsphere.sql.parser.sql.common.statement.dml.SelectStatement;
 
 import java.util.Collection;
-import java.util.Collections;
 import java.util.LinkedList;
+import java.util.List;
 
 /**
  * Subquery extract utility class.
@@ -53,20 +53,23 @@ public final class SubqueryExtractUtil {
      * @return subquery segment collection
      */
     public static Collection<SubquerySegment> getSubquerySegments(final SelectStatement selectStatement) {
-        Collection<SubquerySegment> result = new LinkedList<>();
-        result.addAll(getSubquerySegmentsFromProjections(selectStatement.getProjections()));
-        result.addAll(getSubquerySegmentsFromTableSegment(selectStatement.getFrom()));
+        List<SubquerySegment> result = new LinkedList<>();
+        extractSubquerySegments(result, selectStatement);
+        return result;
+    }
+    
+    private static void extractSubquerySegments(final List<SubquerySegment> result, final SelectStatement selectStatement) {
+        extractSubquerySegmentsFromProjections(result, selectStatement.getProjections());
+        extractSubquerySegmentsFromTableSegment(result, selectStatement.getFrom());
         if (selectStatement.getWhere().isPresent()) {
-            result.addAll(getSubquerySegmentsFromExpression(selectStatement.getWhere().get().getExpr()));
+            extractSubquerySegmentsFromExpression(result, selectStatement.getWhere().get().getExpr());
         }
-        return result;
     }
     
-    private static Collection<SubquerySegment> getSubquerySegmentsFromProjections(final ProjectionsSegment projections) {
+    private static void extractSubquerySegmentsFromProjections(final List<SubquerySegment> result, final ProjectionsSegment projections) {
         if (null == projections || projections.getProjections().isEmpty()) {
-            return Collections.emptyList();
+            return;
         }
-        Collection<SubquerySegment> result = new LinkedList<>();
         for (ProjectionSegment each : projections.getProjections()) {
             if (!(each instanceof SubqueryProjectionSegment)) {
                 continue;
@@ -74,60 +77,55 @@ public final class SubqueryExtractUtil {
             SubquerySegment subquery = ((SubqueryProjectionSegment) each).getSubquery();
             subquery.setSubqueryType(SubqueryType.PROJECTION_SUBQUERY);
             result.add(subquery);
-            result.addAll(getSubquerySegments(subquery.getSelect()));
+            extractSubquerySegments(result, subquery.getSelect());
         }
-        return result;
     }
     
-    private static Collection<SubquerySegment> getSubquerySegmentsFromTableSegment(final TableSegment tableSegment) {
+    private static void extractSubquerySegmentsFromTableSegment(final List<SubquerySegment> result, final TableSegment tableSegment) {
         if (null == tableSegment) {
-            return Collections.emptyList();
+            return;
         }
-        Collection<SubquerySegment> result = new LinkedList<>();
         if (tableSegment instanceof SubqueryTableSegment) {
             SubquerySegment subquery = ((SubqueryTableSegment) tableSegment).getSubquery();
             subquery.setSubqueryType(SubqueryType.TABLE_SUBQUERY);
             result.add(subquery);
-            result.addAll(getSubquerySegments(subquery.getSelect()));
+            extractSubquerySegments(result, subquery.getSelect());
         }
         if (tableSegment instanceof JoinTableSegment) {
-            result.addAll(getSubquerySegmentsFromTableSegment(((JoinTableSegment) tableSegment).getLeft()));
-            result.addAll(getSubquerySegmentsFromTableSegment(((JoinTableSegment) tableSegment).getRight()));
+            extractSubquerySegmentsFromTableSegment(result, ((JoinTableSegment) tableSegment).getLeft());
+            extractSubquerySegmentsFromTableSegment(result, ((JoinTableSegment) tableSegment).getRight());
         }
-        return result;
     }
     
-    private static Collection<SubquerySegment> getSubquerySegmentsFromExpression(final ExpressionSegment expressionSegment) {
-        Collection<SubquerySegment> result = new LinkedList<>();
+    private static void extractSubquerySegmentsFromExpression(final List<SubquerySegment> result, final ExpressionSegment expressionSegment) {
         if (expressionSegment instanceof SubqueryExpressionSegment) {
             SubquerySegment subquery = ((SubqueryExpressionSegment) expressionSegment).getSubquery();
             subquery.setSubqueryType(SubqueryType.PREDICATE_SUBQUERY);
             result.add(subquery);
-            result.addAll(getSubquerySegments(subquery.getSelect()));
+            extractSubquerySegments(result, subquery.getSelect());
         }
         if (expressionSegment instanceof ListExpression) {
             for (ExpressionSegment each : ((ListExpression) expressionSegment).getItems()) {
-                result.addAll(getSubquerySegmentsFromExpression(each));
+                extractSubquerySegmentsFromExpression(result, each);
             }
         }
         if (expressionSegment instanceof BinaryOperationExpression) {
-            result.addAll(getSubquerySegmentsFromExpression(((BinaryOperationExpression) expressionSegment).getLeft()));
-            result.addAll(getSubquerySegmentsFromExpression(((BinaryOperationExpression) expressionSegment).getRight()));
+            extractSubquerySegmentsFromExpression(result, ((BinaryOperationExpression) expressionSegment).getLeft());
+            extractSubquerySegmentsFromExpression(result, ((BinaryOperationExpression) expressionSegment).getRight());
         }
         if (expressionSegment instanceof InExpression) {
-            result.addAll(getSubquerySegmentsFromExpression(((InExpression) expressionSegment).getLeft()));
-            result.addAll(getSubquerySegmentsFromExpression(((InExpression) expressionSegment).getRight()));
+            extractSubquerySegmentsFromExpression(result, ((InExpression) expressionSegment).getLeft());
+            extractSubquerySegmentsFromExpression(result, ((InExpression) expressionSegment).getRight());
         }
         if (expressionSegment instanceof BetweenExpression) {
-            result.addAll(getSubquerySegmentsFromExpression(((BetweenExpression) expressionSegment).getBetweenExpr()));
-            result.addAll(getSubquerySegmentsFromExpression(((BetweenExpression) expressionSegment).getAndExpr()));
+            extractSubquerySegmentsFromExpression(result, ((BetweenExpression) expressionSegment).getBetweenExpr());
+            extractSubquerySegmentsFromExpression(result, ((BetweenExpression) expressionSegment).getAndExpr());
         }
         if (expressionSegment instanceof ExistsSubqueryExpression) {
             SubquerySegment subquery = ((ExistsSubqueryExpression) expressionSegment).getSubquery();
             subquery.setSubqueryType(SubqueryType.EXISTS_SUBQUERY);
             result.add(subquery);
-            result.addAll(getSubquerySegments(subquery.getSelect()));
+            extractSubquerySegments(result, subquery.getSelect());
         }
-        return result;
     }
 }