You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Mark Miller (JIRA)" <ji...@apache.org> on 2009/09/27 18:19:16 UTC
[jira] Created: (LUCENE-1929) Highlighter doesn't support
NumericQuery
Highlighter doesn't support NumericQuery
----------------------------------------
Key: LUCENE-1929
URL: https://issues.apache.org/jira/browse/LUCENE-1929
Project: Lucene - Java
Issue Type: Bug
Components: contrib/highlighter
Affects Versions: 2.9
Reporter: Mark Miller
Assignee: Mark Miller
Sucks. Will throw a NullPointer exception.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1929) Highlighter doesn't support
NumericRangeQuery or deprecated RangeQuery
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Miller updated LUCENE-1929:
--------------------------------
Fix Version/s: 2.9.1
> Highlighter doesn't support NumericRangeQuery or deprecated RangeQuery
> ----------------------------------------------------------------------
>
> Key: LUCENE-1929
> URL: https://issues.apache.org/jira/browse/LUCENE-1929
> Project: Lucene - Java
> Issue Type: Bug
> Components: contrib/highlighter
> Affects Versions: 2.9
> Reporter: Mark Miller
> Assignee: Mark Miller
> Fix For: 2.9.1
>
> Attachments: LUCENE-1929.patch
>
>
> Sucks. Will throw a NullPointer exception.
> Only NumericRangeQuery will throw the exception.
> RangeQuery just won't highlight.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1929) Highlighter doesn't support
NumericQuery
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760061#action_12760061 ]
Uwe Schindler commented on LUCENE-1929:
---------------------------------------
I read what stands in SOLR-1221: It calls MTQ.getTerm() which is deprecated. The getTerm() method is moved downto the sub classes, so MTQ.getTerm() will be removed in 3.0. Because of this there was no intention to implement it in NumericRQ.
> Highlighter doesn't support NumericQuery
> ----------------------------------------
>
> Key: LUCENE-1929
> URL: https://issues.apache.org/jira/browse/LUCENE-1929
> Project: Lucene - Java
> Issue Type: Bug
> Components: contrib/highlighter
> Affects Versions: 2.9
> Reporter: Mark Miller
> Assignee: Mark Miller
>
> Sucks. Will throw a NullPointer exception.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1929) Highlighter doesn't support
NumericQuery
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760068#action_12760068 ]
Mark Miller commented on LUCENE-1929:
-------------------------------------
bq. and not a backwards break, as both classes are new in 2.9
I didn't claim its back compat break - but any method on a base class than can return null really needs to be documented as such. I should have caught that and done a better doc job on MulitTermQuery. I'm not claiming back compat issues, I'm claiming its wrong.
On a side note, its a bummer we seem to have lost the history on RangeQuery.
> Highlighter doesn't support NumericQuery
> ----------------------------------------
>
> Key: LUCENE-1929
> URL: https://issues.apache.org/jira/browse/LUCENE-1929
> Project: Lucene - Java
> Issue Type: Bug
> Components: contrib/highlighter
> Affects Versions: 2.9
> Reporter: Mark Miller
> Assignee: Mark Miller
>
> Sucks. Will throw a NullPointer exception.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1929) Highlighter doesn't support
NumericQuery
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760071#action_12760071 ]
Mark Miller commented on LUCENE-1929:
-------------------------------------
Ah, thanks - didn't catch that. Wondered how it could happen - looked weird. Faint memory of the whole thing returning though.
> Highlighter doesn't support NumericQuery
> ----------------------------------------
>
> Key: LUCENE-1929
> URL: https://issues.apache.org/jira/browse/LUCENE-1929
> Project: Lucene - Java
> Issue Type: Bug
> Components: contrib/highlighter
> Affects Versions: 2.9
> Reporter: Mark Miller
> Assignee: Mark Miller
>
> Sucks. Will throw a NullPointer exception.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1929) Highlighter doesn't support
NumericQuery
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760067#action_12760067 ]
Mark Miller commented on LUCENE-1929:
-------------------------------------
I realize the difficulties - I wasn't blaming you for the problem - but it is/was a problem.
We deprecated getTerm() because of the problem (I think I did it? Don't remember though).
However, unless it was documented to return null, just deprecating it doesn't really fix things. Code thats trying to use it on the base MultiTermQuery isn't going
to be checking if its null unless its documented as such.
I agree its screwed and it will be nice when its gone.
Like I said, its a moot point. But I'll argue any point, moot or not ;)
> Highlighter doesn't support NumericQuery
> ----------------------------------------
>
> Key: LUCENE-1929
> URL: https://issues.apache.org/jira/browse/LUCENE-1929
> Project: Lucene - Java
> Issue Type: Bug
> Components: contrib/highlighter
> Affects Versions: 2.9
> Reporter: Mark Miller
> Assignee: Mark Miller
>
> Sucks. Will throw a NullPointer exception.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1929) Highlighter doesn't support
NumericRangeQuery or deprecated RangeQuery
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12767394#action_12767394 ]
Mark Miller commented on LUCENE-1929:
-------------------------------------
Yeah - sorry - has been for some time. I can commit it shortly.
> Highlighter doesn't support NumericRangeQuery or deprecated RangeQuery
> ----------------------------------------------------------------------
>
> Key: LUCENE-1929
> URL: https://issues.apache.org/jira/browse/LUCENE-1929
> Project: Lucene - Java
> Issue Type: Bug
> Components: contrib/highlighter
> Affects Versions: 2.9
> Reporter: Mark Miller
> Assignee: Mark Miller
> Fix For: 2.9.1
>
> Attachments: LUCENE-1929.patch
>
>
> Sucks. Will throw a NullPointer exception.
> Only NumericRangeQuery will throw the exception.
> RangeQuery just won't highlight.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1929) Highlighter doesn't support
NumericQuery
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760070#action_12760070 ]
Uwe Schindler commented on LUCENE-1929:
---------------------------------------
bq. On a side note, its a bummer we seem to have lost the history on RangeQuery.
No we didn't. As RangeQuery is just a wrapper and will be removed in 3.0, I renamed the old RangeQuery to the new TermRangeQuery (so the history is there) and created a new class RangeQuery for the BW compatibility. This is better than loosing the history in 3.0.
> Highlighter doesn't support NumericQuery
> ----------------------------------------
>
> Key: LUCENE-1929
> URL: https://issues.apache.org/jira/browse/LUCENE-1929
> Project: Lucene - Java
> Issue Type: Bug
> Components: contrib/highlighter
> Affects Versions: 2.9
> Reporter: Mark Miller
> Assignee: Mark Miller
>
> Sucks. Will throw a NullPointer exception.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1929) Highlighter doesn't support
NumericQuery
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760062#action_12760062 ]
Mark Miller commented on LUCENE-1929:
-------------------------------------
Yeah - eventually (as in when getTerm() is removed), the Highlighter was going to have to deal with that anyway. Deprecated methods should still work though - so whether return null from getTerm is right or wrong, I dunno.
But thats the issue - except for TermRangeQuery, the Highlighter looks for the Field by calling getTerm and asking for the field - made the exception for TermRangeQuery, but not NumericRangeQuery - so it throw a nullpointer exception. Easy to sidestep in Lucene, more of a pain in Solr (as the plan is to release with 2.9.0)
> Highlighter doesn't support NumericQuery
> ----------------------------------------
>
> Key: LUCENE-1929
> URL: https://issues.apache.org/jira/browse/LUCENE-1929
> Project: Lucene - Java
> Issue Type: Bug
> Components: contrib/highlighter
> Affects Versions: 2.9
> Reporter: Mark Miller
> Assignee: Mark Miller
>
> Sucks. Will throw a NullPointer exception.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1929) Highlighter doesn't support
NumericRangeQuery or deprecated RangeQuery
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765082#action_12765082 ]
Uwe Schindler commented on LUCENE-1929:
---------------------------------------
This is fixed also in trunk, but different where MTQ.getTerm() is not available.
> Highlighter doesn't support NumericRangeQuery or deprecated RangeQuery
> ----------------------------------------------------------------------
>
> Key: LUCENE-1929
> URL: https://issues.apache.org/jira/browse/LUCENE-1929
> Project: Lucene - Java
> Issue Type: Bug
> Components: contrib/highlighter
> Affects Versions: 2.9
> Reporter: Mark Miller
> Assignee: Mark Miller
> Fix For: 2.9.1
>
> Attachments: LUCENE-1929.patch
>
>
> Sucks. Will throw a NullPointer exception.
> Only NumericRangeQuery will throw the exception.
> RangeQuery just won't highlight.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1929) Highlighter doesn't support
NumericQuery
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760076#action_12760076 ]
Mark Miller commented on LUCENE-1929:
-------------------------------------
bq. Another option to fix Solr's highlighter is to fix this in lucene and release solr with 2.9.0, but an updated highlighter package. As it is contrib, that shouldn't be a problem?
Thats a good point and prob the way to go.
bq. In my opinion, the whole highlighter stuff should somehow be implemented without tons of instanceof checks (thats really wired). Maybe we extend Query by some highligther addons in future. I think we had an issue about that?
Yes - would be wonderful to lose all of the instanceOf - its just kind of legacy - how its worked in the past. Getting away from it would be *fantastic*.
> Highlighter doesn't support NumericQuery
> ----------------------------------------
>
> Key: LUCENE-1929
> URL: https://issues.apache.org/jira/browse/LUCENE-1929
> Project: Lucene - Java
> Issue Type: Bug
> Components: contrib/highlighter
> Affects Versions: 2.9
> Reporter: Mark Miller
> Assignee: Mark Miller
>
> Sucks. Will throw a NullPointer exception.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1929) Highlighter doesn't support
NumericQuery
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760056#action_12760056 ]
Mark Miller commented on LUCENE-1929:
-------------------------------------
So making NumericQuery Hilightable is not going to be so quick and easy - best first step is prob just make it be skipped, rather than throwing a NullPointer exception. Highlight support can come later.
> Highlighter doesn't support NumericQuery
> ----------------------------------------
>
> Key: LUCENE-1929
> URL: https://issues.apache.org/jira/browse/LUCENE-1929
> Project: Lucene - Java
> Issue Type: Bug
> Components: contrib/highlighter
> Affects Versions: 2.9
> Reporter: Mark Miller
> Assignee: Mark Miller
>
> Sucks. Will throw a NullPointer exception.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Issue Comment Edited: (LUCENE-1929) Highlighter doesn't
support NumericRangeQuery or deprecated RangeQuery
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765082#action_12765082 ]
Uwe Schindler edited comment on LUCENE-1929 at 10/13/09 7:11 AM:
-----------------------------------------------------------------
This is fixed also in trunk, but different where MTQ.getTerm() is not available (LUCENE-1977)
was (Author: thetaphi):
This is fixed also in trunk, but different where MTQ.getTerm() is not available.
> Highlighter doesn't support NumericRangeQuery or deprecated RangeQuery
> ----------------------------------------------------------------------
>
> Key: LUCENE-1929
> URL: https://issues.apache.org/jira/browse/LUCENE-1929
> Project: Lucene - Java
> Issue Type: Bug
> Components: contrib/highlighter
> Affects Versions: 2.9
> Reporter: Mark Miller
> Assignee: Mark Miller
> Fix For: 2.9.1
>
> Attachments: LUCENE-1929.patch
>
>
> Sucks. Will throw a NullPointer exception.
> Only NumericRangeQuery will throw the exception.
> RangeQuery just won't highlight.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1929) Highlighter doesn't support
NumericQuery
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760072#action_12760072 ]
Mark Miller commented on LUCENE-1929:
-------------------------------------
bq. I wasn't blaming you for the problem
In fact, now that I can see the history to remember, if you go back and look, I am completely to blame :)
> Highlighter doesn't support NumericQuery
> ----------------------------------------
>
> Key: LUCENE-1929
> URL: https://issues.apache.org/jira/browse/LUCENE-1929
> Project: Lucene - Java
> Issue Type: Bug
> Components: contrib/highlighter
> Affects Versions: 2.9
> Reporter: Mark Miller
> Assignee: Mark Miller
>
> Sucks. Will throw a NullPointer exception.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Resolved: (LUCENE-1929) Highlighter doesn't support
NumericRangeQuery or deprecated RangeQuery
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Miller resolved LUCENE-1929.
---------------------------------
Resolution: Fixed
Lucene Fields: [New, Patch Available] (was: [New])
> Highlighter doesn't support NumericRangeQuery or deprecated RangeQuery
> ----------------------------------------------------------------------
>
> Key: LUCENE-1929
> URL: https://issues.apache.org/jira/browse/LUCENE-1929
> Project: Lucene - Java
> Issue Type: Bug
> Components: contrib/highlighter
> Affects Versions: 2.9
> Reporter: Mark Miller
> Assignee: Mark Miller
> Fix For: 2.9.1
>
> Attachments: LUCENE-1929.patch
>
>
> Sucks. Will throw a NullPointer exception.
> Only NumericRangeQuery will throw the exception.
> RangeQuery just won't highlight.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1929) Highlighter doesn't support
NumericRangeQuery or deprecated RangeQuery
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Miller updated LUCENE-1929:
--------------------------------
Summary: Highlighter doesn't support NumericRangeQuery or deprecated RangeQuery (was: Highlighter doesn't support NumericQuery or deprecated RangeQuery)
> Highlighter doesn't support NumericRangeQuery or deprecated RangeQuery
> ----------------------------------------------------------------------
>
> Key: LUCENE-1929
> URL: https://issues.apache.org/jira/browse/LUCENE-1929
> Project: Lucene - Java
> Issue Type: Bug
> Components: contrib/highlighter
> Affects Versions: 2.9
> Reporter: Mark Miller
> Assignee: Mark Miller
>
> Sucks. Will throw a NullPointer exception.
> Only NumericRangeQuery will throw the exception.
> RangeQuery just won't highlight.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1929) Highlighter doesn't support
NumericRangeQuery or deprecated RangeQuery
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Miller updated LUCENE-1929:
--------------------------------
Attachment: LUCENE-1929.patch
The 2.9.1 fix
> Highlighter doesn't support NumericRangeQuery or deprecated RangeQuery
> ----------------------------------------------------------------------
>
> Key: LUCENE-1929
> URL: https://issues.apache.org/jira/browse/LUCENE-1929
> Project: Lucene - Java
> Issue Type: Bug
> Components: contrib/highlighter
> Affects Versions: 2.9
> Reporter: Mark Miller
> Assignee: Mark Miller
> Attachments: LUCENE-1929.patch
>
>
> Sucks. Will throw a NullPointer exception.
> Only NumericRangeQuery will throw the exception.
> RangeQuery just won't highlight.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1929) Highlighter doesn't support
NumericRangeQuery or deprecated RangeQuery
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12767392#action_12767392 ]
Michael McCandless commented on LUCENE-1929:
--------------------------------------------
Mark is this one reading to go into 2.9.1?
> Highlighter doesn't support NumericRangeQuery or deprecated RangeQuery
> ----------------------------------------------------------------------
>
> Key: LUCENE-1929
> URL: https://issues.apache.org/jira/browse/LUCENE-1929
> Project: Lucene - Java
> Issue Type: Bug
> Components: contrib/highlighter
> Affects Versions: 2.9
> Reporter: Mark Miller
> Assignee: Mark Miller
> Fix For: 2.9.1
>
> Attachments: LUCENE-1929.patch
>
>
> Sucks. Will throw a NullPointer exception.
> Only NumericRangeQuery will throw the exception.
> RangeQuery just won't highlight.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1929) Highlighter doesn't support
NumericQuery
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760066#action_12760066 ]
Uwe Schindler commented on LUCENE-1929:
---------------------------------------
bq. In fact, its probably wrong - but at this point its a moot point.
It can only return a "pattern term" if there is one. What is the pattern term for TermRangeQuery or NumericRangeQuery. Both return null and that is fine (and not a backwards break, as both classes are new in 2.9). That was exactly the discussion behind removing the getTerm() stuff from MTQ.
Solr could maybe remove the NRQ from the highligter query.
> Highlighter doesn't support NumericQuery
> ----------------------------------------
>
> Key: LUCENE-1929
> URL: https://issues.apache.org/jira/browse/LUCENE-1929
> Project: Lucene - Java
> Issue Type: Bug
> Components: contrib/highlighter
> Affects Versions: 2.9
> Reporter: Mark Miller
> Assignee: Mark Miller
>
> Sucks. Will throw a NullPointer exception.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1929) Highlighter doesn't support
NumericQuery
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760064#action_12760064 ]
Mark Miller commented on LUCENE-1929:
-------------------------------------
bq. so whether return null from getTerm is right or wrong, I dunno.
In fact, its probably wrong - but at this point its a moot point.
> Highlighter doesn't support NumericQuery
> ----------------------------------------
>
> Key: LUCENE-1929
> URL: https://issues.apache.org/jira/browse/LUCENE-1929
> Project: Lucene - Java
> Issue Type: Bug
> Components: contrib/highlighter
> Affects Versions: 2.9
> Reporter: Mark Miller
> Assignee: Mark Miller
>
> Sucks. Will throw a NullPointer exception.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1929) Highlighter doesn't support
NumericQuery
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760074#action_12760074 ]
Uwe Schindler commented on LUCENE-1929:
---------------------------------------
Another option to fix Solr's highlighter is to fix this in lucene and release solr with 2.9.0, but an updated highlighter package. As it is contrib, that shouldn't be a problem?
In my opinion, the whole highlighter stuff should somehow be implemented without tons of instanceof checks (thats really wired). Maybe we extend Query by some highligther addons in future. I think we had an issue about that?
> Highlighter doesn't support NumericQuery
> ----------------------------------------
>
> Key: LUCENE-1929
> URL: https://issues.apache.org/jira/browse/LUCENE-1929
> Project: Lucene - Java
> Issue Type: Bug
> Components: contrib/highlighter
> Affects Versions: 2.9
> Reporter: Mark Miller
> Assignee: Mark Miller
>
> Sucks. Will throw a NullPointer exception.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1929) Highlighter doesn't support
NumericQuery
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760060#action_12760060 ]
Uwe Schindler commented on LUCENE-1929:
---------------------------------------
Does it throw a NPE for every "unknown" query type? Or is this because of it is a subclass of MTQ?
> Highlighter doesn't support NumericQuery
> ----------------------------------------
>
> Key: LUCENE-1929
> URL: https://issues.apache.org/jira/browse/LUCENE-1929
> Project: Lucene - Java
> Issue Type: Bug
> Components: contrib/highlighter
> Affects Versions: 2.9
> Reporter: Mark Miller
> Assignee: Mark Miller
>
> Sucks. Will throw a NullPointer exception.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1929) Highlighter doesn't support
NumericQuery or deprecated RangeQuery
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Miller updated LUCENE-1929:
--------------------------------
Summary: Highlighter doesn't support NumericQuery or deprecated RangeQuery (was: Highlighter doesn't support NumericQuery)
> Highlighter doesn't support NumericQuery or deprecated RangeQuery
> -----------------------------------------------------------------
>
> Key: LUCENE-1929
> URL: https://issues.apache.org/jira/browse/LUCENE-1929
> Project: Lucene - Java
> Issue Type: Bug
> Components: contrib/highlighter
> Affects Versions: 2.9
> Reporter: Mark Miller
> Assignee: Mark Miller
>
> Sucks. Will throw a NullPointer exception.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1929) Highlighter doesn't support
NumericQuery or deprecated RangeQuery
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Miller updated LUCENE-1929:
--------------------------------
Description:
Sucks. Will throw a NullPointer exception.
Only NumericRangeQuery will throw the exception.
RangeQuery just won't highlight.
was:Sucks. Will throw a NullPointer exception.
> Highlighter doesn't support NumericQuery or deprecated RangeQuery
> -----------------------------------------------------------------
>
> Key: LUCENE-1929
> URL: https://issues.apache.org/jira/browse/LUCENE-1929
> Project: Lucene - Java
> Issue Type: Bug
> Components: contrib/highlighter
> Affects Versions: 2.9
> Reporter: Mark Miller
> Assignee: Mark Miller
>
> Sucks. Will throw a NullPointer exception.
> Only NumericRangeQuery will throw the exception.
> RangeQuery just won't highlight.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org