You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/08/12 08:10:01 UTC
[GitHub] [lucene-solr] MarcusSorealheis opened a new pull request #1744: SOLR-14731: Add SingleThreaded Annotation to Class
MarcusSorealheis opened a new pull request #1744:
URL: https://github.com/apache/lucene-solr/pull/1744
<!--
_(If you are a project committer then you may remove some/all of the following template.)_
Before creating a pull request, please file an issue in the ASF Jira system for Lucene or Solr:
* https://issues.apache.org/jira/projects/LUCENE
* https://issues.apache.org/jira/projects/SOLR
You will need to create an account in Jira in order to create an issue.
The title of the PR should reference the Jira issue number in the form:
* LUCENE-####: <short description of problem or changes>
* SOLR-####: <short description of problem or changes>
LUCENE and SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
# Description
Makes use of @anshumg and @markrmiller's single threaded annotation so that it is more obvious to maintainers.
# Solution
adds it.
# Tests
Tests do not change for this one.
# Checklist
Please review the following and check all that apply:
- [ ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [ ] I have created a Jira issue and added the issue ID to my pull request title.
- [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [ ] I have developed this patch against the `master` branch.
- [ ] I have run `ant precommit` and the appropriate test suite.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] MarcusSorealheis commented on pull request #1744: SOLR-14731: Add SingleThreaded Annotation to Class
Posted by GitBox <gi...@apache.org>.
MarcusSorealheis commented on pull request #1744:
URL: https://github.com/apache/lucene-solr/pull/1744#issuecomment-679311034
are we able to first the tests to run again?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] MarcusSorealheis commented on pull request #1744: SOLR-14731: Add SingleThreaded Annotation to Class
Posted by GitBox <gi...@apache.org>.
MarcusSorealheis commented on pull request #1744:
URL: https://github.com/apache/lucene-solr/pull/1744#issuecomment-676730145
@chatman Can you re-run this test and commit this one as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] chatman commented on pull request #1744: SOLR-14731: Add SingleThreaded Annotation to Class
Posted by GitBox <gi...@apache.org>.
chatman commented on pull request #1744:
URL: https://github.com/apache/lucene-solr/pull/1744#issuecomment-675403326
Looks good. I'll merge this soon. Thanks @MarcusSorealheis.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] MarcusSorealheis commented on pull request #1744: SOLR-14731: Add SingleThreaded Annotation to Class
Posted by GitBox <gi...@apache.org>.
MarcusSorealheis commented on pull request #1744:
URL: https://github.com/apache/lucene-solr/pull/1744#issuecomment-674179100
I'm not sure what the end result is of adding all these annotations in the short term, but if it is very challenging to get them reviewed for something as simple as this one, do you think I should invest the time? Also, maybe @noblepaul but feels like he is doing a lot in Solr atm..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] MarcusSorealheis commented on pull request #1744: SOLR-14731: Add SingleThreaded Annotation to Class
Posted by GitBox <gi...@apache.org>.
MarcusSorealheis commented on pull request #1744:
URL: https://github.com/apache/lucene-solr/pull/1744#issuecomment-674178586
@anshumg
> The annotation usage is correct, however I haven't taken a look at the code itself to validate if it's meant to be single threaded or not. Perhaps other folks who've been in here can chime in on that.
@anshumg are you unable to look at it? It's one file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] MarcusSorealheis commented on pull request #1744: SOLR-14731: Add SingleThreaded Annotation to Class
Posted by GitBox <gi...@apache.org>.
MarcusSorealheis commented on pull request #1744:
URL: https://github.com/apache/lucene-solr/pull/1744#issuecomment-672714337
simple PR here, will the package masters @chatman and @noblepaul please take a look, as well as @anshumg. I'll use this annotation going forward as applicable. Thanks for adding it! ☺️
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] madrob commented on pull request #1744: SOLR-14731: Add SingleThreaded Annotation to Class
Posted by GitBox <gi...@apache.org>.
madrob commented on pull request #1744:
URL: https://github.com/apache/lucene-solr/pull/1744#issuecomment-673461640
Rome was not built in one day, so too our code documentation Is in not finished in one PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] anshumg commented on pull request #1744: SOLR-14731: Add SingleThreaded Annotation to Class
Posted by GitBox <gi...@apache.org>.
anshumg commented on pull request #1744:
URL: https://github.com/apache/lucene-solr/pull/1744#issuecomment-673180596
The annotation usage is correct, however I haven't taken a look at the code itself to validate if it's meant to be single threaded or not. Perhaps other folks who've been in here can chime in on that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] noblepaul commented on pull request #1744: SOLR-14731: Add SingleThreaded Annotation to Class
Posted by GitBox <gi...@apache.org>.
noblepaul commented on pull request #1744:
URL: https://github.com/apache/lucene-solr/pull/1744#issuecomment-673330445
I don't really know what purpose is solved by this annotation. If it is for documentation purpose, this may make sense. But, there are a million other places where the classes are not thread-safe. What's the point of just adding it here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org