You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cloudstack.apache.org by Ewan Mellor <ew...@citrix.com> on 2012/07/27 23:26:25 UTC

Review Request: Use failonerror=true

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6149/
-----------------------------------------------------------

Review request for cloudstack.


Description
-------

Use failonerror=true for the exec calls used in the deploy-cloudstack-db, deploydb-simulator, and build-apidocs targets.


Diffs
-----

  build/developer.xml ecd6939 

Diff: https://reviews.apache.org/r/6149/diff/


Testing
-------


Thanks,

Ewan Mellor

Re: Review Request: Use failonerror=true

Posted by Prasanna Santhanam <Pr...@citrix.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6149/#review9584
-----------------------------------------------------------

Ship it!


Looks good to me. Tested the simulator and apidoc targets after applying the diff.

- Prasanna Santhanam


On July 27, 2012, 9:26 p.m., Ewan Mellor wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6149/
> -----------------------------------------------------------
> 
> (Updated July 27, 2012, 9:26 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> Use failonerror=true for the exec calls used in the deploy-cloudstack-db, deploydb-simulator, and build-apidocs targets.
> 
> 
> Diffs
> -----
> 
>   build/developer.xml ecd6939 
> 
> Diff: https://reviews.apache.org/r/6149/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ewan Mellor
> 
>