[jira] [Commented] (YARN-4155) TestLogAggregationService.testLogAggregationServiceWithInterval failing

["Steve Loughran (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-4155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14743296#comment-14743296 ] 

Steve Loughran commented on YARN-4155:
--------------------------------------

{code}
java.lang.AssertionError: expected:<-1> but was:<1>
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.failNotEquals(Assert.java:743)
	at org.junit.Assert.assertEquals(Assert.java:118)
	at org.junit.Assert.assertEquals(Assert.java:555)
	at org.junit.Assert.assertEquals(Assert.java:542)
	at org.apache.hadoop.yarn.server.nodemanager.containermanager.logaggregation.TestLogAggregationService.testLogAggregationService(TestLogAggregationService.java:1993)
	at org.apache.hadoop.yarn.server.nodemanager.containermanager.logaggregation.TestLogAggregationService.testLogAggregationServiceWithInterval(TestLogAggregationService.java:1887)

{code}

Note that in the assertion in the source, the expected and actual arguments are in the wrong order. This assert expected "1", but got "-1". 

The patch should include reversing these arguments, and adding some explanatory message to the assert

> TestLogAggregationService.testLogAggregationServiceWithInterval failing
> -----------------------------------------------------------------------
>
>                 Key: YARN-4155
>                 URL: https://issues.apache.org/jira/browse/YARN-4155
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 3.0.0
>         Environment: Jenkins
>            Reporter: Steve Loughran
>            Priority: Critical
>
> Test failing on Jenkins: {{TestLogAggregationService.testLogAggregationServiceWithInterval}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)