You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by byamthev <gi...@git.apache.org> on 2017/08/25 09:25:05 UTC
[GitHub] zeppelin pull request #2551: [ZEPPELIN-2880] - Fix username output when OIDC...
GitHub user byamthev opened a pull request:
https://github.com/apache/zeppelin/pull/2551
[ZEPPELIN-2880] - Fix username output when OIDC is enabled
### What is this PR for?
When OIDC is enabled, user's roles/permissions/tokens are sent to Zeppelin's client via websocket and appears in the web browser when running a paragraph in a notebook.
### What type of PR is it?
[Bug Fix]
### What is the Jira issue?
* [ZEPPELIN-2880](https://issues.apache.org/jira/browse/ZEPPELIN-2880)
### How should this be tested?
Enable OIDC , login to Zeppelin and run a paragraph. Check the text "Last updated by".
### Questions:
* Does the licenses files need update? N/A
* Is there breaking changes for older versions? N/A
* Does this needs documentation? N/A
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nokia/zeppelin zeppelin_2880
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2551.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2551
----
commit 72636897ca17d8702a79decc4cbdf9a024d70ab5
Author: byamthev <by...@gmail.com>
Date: 2017-08-25T08:04:52Z
[ZEPPELIN-2880] - Fix username output when OIDC is enabled
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2551: [ZEPPELIN-2880] - Fix username output when OIDC is ena...
Posted by byamthev <gi...@git.apache.org>.
Github user byamthev commented on the issue:
https://github.com/apache/zeppelin/pull/2551
Yes, I have now added a JUnit test.
---
[GitHub] zeppelin pull request #2551: [ZEPPELIN-2880] - Fix username output when OIDC...
Posted by byamthev <gi...@git.apache.org>.
Github user byamthev closed the pull request at:
https://github.com/apache/zeppelin/pull/2551
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2551: [ZEPPELIN-2880] - Fix username output when OIDC...
Posted by byamthev <gi...@git.apache.org>.
GitHub user byamthev reopened a pull request:
https://github.com/apache/zeppelin/pull/2551
[ZEPPELIN-2880] - Fix username output when OIDC is enabled
### What is this PR for?
When OIDC is enabled, user's roles/permissions/tokens are sent to Zeppelin's client via websocket and appears in the web browser when running a paragraph in a notebook.
### What type of PR is it?
[Bug Fix]
### What is the Jira issue?
* [ZEPPELIN-2880](https://issues.apache.org/jira/browse/ZEPPELIN-2880)
### How should this be tested?
Enable OIDC , login to Zeppelin and run a paragraph. Check the text "Last updated by".
### Questions:
* Does the licenses files need update? N/A
* Is there breaking changes for older versions? N/A
* Does this needs documentation? N/A
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nokia/zeppelin zeppelin_2880
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2551.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2551
----
commit 72636897ca17d8702a79decc4cbdf9a024d70ab5
Author: byamthev <by...@gmail.com>
Date: 2017-08-25T08:04:52Z
[ZEPPELIN-2880] - Fix username output when OIDC is enabled
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2551: [ZEPPELIN-2880] - Fix username output when OIDC is ena...
Posted by andreaTP <gi...@git.apache.org>.
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2551
ping, probably this is good to merge
---
[GitHub] zeppelin issue #2551: [ZEPPELIN-2880] - Fix username output when OIDC is ena...
Posted by andreaTP <gi...@git.apache.org>.
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2551
@felixcheung I think that docs improvements have sense in this case only on top of #2552 , could post-pone them?
---
[GitHub] zeppelin issue #2551: [ZEPPELIN-2880] - Fix username output when OIDC is ena...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2551
merged, do you have a JIRA user on ASF JIRA, @byamthev ?
---
[GitHub] zeppelin issue #2551: [ZEPPELIN-2880] - Fix username output when OIDC is ena...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2551
ok, how about this question
https://github.com/apache/zeppelin/pull/2551/files/cb6ec7047a8abc1a79da3c1261178e1a9e0b4f17#diff-0d6ccf388c8aa67062870388536ed274
---
[GitHub] zeppelin issue #2551: [ZEPPELIN-2880] - Fix username output when OIDC is ena...
Posted by andreaTP <gi...@git.apache.org>.
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2551
> should we consider returning/displaying more than just the principal name?
now the name field is configurable via `shiro.ini`, basically you can return different values in that field depending on configuration (e.g. look at tests https://github.com/bujiio/buji-pac4j/pull/63/files)
---
[GitHub] zeppelin pull request #2551: [ZEPPELIN-2880] - Fix username output when OIDC...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2551
---
[GitHub] zeppelin issue #2551: [ZEPPELIN-2880] - Fix username output when OIDC is ena...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2551
LGTM
any more comment?
---
[GitHub] zeppelin issue #2551: [ZEPPELIN-2880] - Fix username output when OIDC is ena...
Posted by byamthev <gi...@git.apache.org>.
Github user byamthev commented on the issue:
https://github.com/apache/zeppelin/pull/2551
ping @felixchang
---
[GitHub] zeppelin issue #2551: [ZEPPELIN-2880] - Fix username output when OIDC is ena...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2551
I see, it would be great to add some example in /docs/setup/security?
---
[GitHub] zeppelin issue #2551: [ZEPPELIN-2880] - Fix username output when OIDC is ena...
Posted by andreaTP <gi...@git.apache.org>.
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2551
this is possible since this PR from @volumeint to bujiio:
https://github.com/bujiio/buji-pac4j/pull/63
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---