You are viewing a plain text version of this content. The canonical link for it is here.
Posted to builds@fluss.apache.org by GitBox <gi...@apache.org> on 2026/01/05 10:51:25 UTC
[GH] (fluss/rocksmetrics): Workflow run "Check Documentation" is working again!
The GitHub Actions job "Check Documentation" on fluss.git/rocksmetrics has succeeded.
Run started by GitHub user platinumhamburg (triggered by platinumhamburg).
Head commit for run:
afc353255bff67f3ae79ac8b512014381592908a / ocean.wy <oc...@alibaba-inc.com>
重构: 优化 RocksDB 指标管理架构
主要变更:
1. 重命名 RocksDBMetrics -> RocksDBStatistics,明确其职责为统计收集而非指标注册
2. 将 RocksDBStatistics 管理权从 TableMetricGroup 移交给 BucketMetricGroup,实现更清晰的封装
3. 简化注册流程:Replica 直接向 BucketMetricGroup 注册,无需跨层级调用
4. 完善生命周期管理:
- 注册:KvTablet 创建后在 Replica.initKvTablet() 中调用
- 注销:KvTablet 销毁前在 Replica.dropKv() 中显式调用
- 新增 BucketMetricGroup.unregisterRocksDBStatistics() 确保成对调用
5. 动态聚合优化:
- 移除 TableMetricGroup.rocksDBStatisticsMap 冗余数据结构
- 新增 allRocksDBStatistics() 方法动态从 BucketMetricGroup 获取
6. 提高并发安全性:将 TableMetricGroup.buckets 改为 ConcurrentHashMap
收益:
- 代码更简洁:减少 50+ 行冗余代码
- 架构更清晰:RocksDBStatistics 归属明确
- 资源更安全:注册/注销成对,防止泄漏
- 维护性更好:单一职责,修改影响面小
测试验证:
- ✅ RocksDBResourceContainerTest: 7/7 通过
- ✅ KvTabletTest: 13/13 通过
- ✅ 编译通过,无 linter 错误
Report URL: https://github.com/apache/fluss/actions/runs/20713023440
With regards,
GitHub Actions via GitBox