[GitHub] [hadoop-ozone] smengcl commented on pull request #941: HDDS-3574. Implement ofs://: Override getTrashRoot

[GitBox <gi...@apache.org>]

smengcl commented on pull request #941:
URL: https://github.com/apache/hadoop-ozone/pull/941#issuecomment-637068626


   > > > Just one thought about permissions. How will we ensure data deleted by one user and moved to `.Trash` is not made visible to another user who doesn't have permissions to see it?
   > > 
   > > 
   > > I think key ACL already kind of solves this problem.
   > > When a user moves a key, the ACL should, in theory, be kept as-is?
   > > But we might need to set the ACL on `/.Trash/<username>/` to that user only though. @xiaoyuyao Thoughts?
   > 
   > Yes. TrashPolicyDefault has those the parent path of the deleted file created under the trash root with owner has ALL access and group/others has NONE access.
   
   Thanks for the insight. So `TrashPolicyDefault` has already handled the trash directory permission logic: https://github.com/apache/hadoop/blob/branch-3.2.1/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/TrashPolicyDefault.java#L153


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org