You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/13 04:17:26 UTC
[GitHub] [spark] gengliangwang opened a new pull request #32141: [Minor][Test] Enhance the test instruction of ThriftServerQueryTestSuite
gengliangwang opened a new pull request #32141:
URL: https://github.com/apache/spark/pull/32141
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Enhance the test instruction of ThriftServerQueryTestSuite:
1. how to run a single test case
2. how to regenerate golden file for a single test
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Better documentation.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
No, just enhance the comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a change in pull request #32141: [MINOR][TESTS] Enhance the test instruction of ThriftServerQueryTestSuite
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on a change in pull request #32141:
URL: https://github.com/apache/spark/pull/32141#discussion_r612165409
##########
File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/ThriftServerQueryTestSuite.scala
##########
@@ -36,16 +36,31 @@ import org.apache.spark.sql.types._
/**
* Re-run all the tests in SQLQueryTestSuite via Thrift Server.
*
+ * Each case is loaded from a file in "spark/sql/core/src/test/resources/sql-tests/inputs".
+ * Each case has a golden result file in "spark/sql/core/src/test/resources/sql-tests/results".
+ *
* To run the entire test suite:
* {{{
- * build/sbt "hive-thriftserver/testOnly *ThriftServerQueryTestSuite" -Phive-thriftserver
+ * build/sbt -Phive-thriftserver "hive-thriftserver/testOnly *ThriftServerQueryTestSuite"
+ * }}}
+ *
+ * To run a single test file upon change:
+ * {{{
+ * build/sbt -Phive-thriftserver \
Review comment:
Thanks, updated!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang closed pull request #32141: [MINOR][TESTS] Enhance the test instruction of ThriftServerQueryTestSuite
Posted by GitBox <gi...@apache.org>.
gengliangwang closed pull request #32141:
URL: https://github.com/apache/spark/pull/32141
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #32141: [MINOR][TEST] Enhance the test instruction of ThriftServerQueryTestSuite
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #32141:
URL: https://github.com/apache/spark/pull/32141#discussion_r612139252
##########
File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/ThriftServerQueryTestSuite.scala
##########
@@ -36,16 +36,31 @@ import org.apache.spark.sql.types._
/**
* Re-run all the tests in SQLQueryTestSuite via Thrift Server.
*
+ * Each case is loaded from a file in "spark/sql/core/src/test/resources/sql-tests/inputs".
+ * Each case has a golden result file in "spark/sql/core/src/test/resources/sql-tests/results".
+ *
* To run the entire test suite:
* {{{
- * build/sbt "hive-thriftserver/testOnly *ThriftServerQueryTestSuite" -Phive-thriftserver
+ * build/sbt -Phive-thriftserver "hive-thriftserver/testOnly *ThriftServerQueryTestSuite"
+ * }}}
+ *
+ * To run a single test file upon change:
+ * {{{
+ * build/sbt -Phive-thriftserver \
+ * "hive-thriftserver/testOnly *ThriftServerQueryTestSuite -- -z inline-table.sql"
+ *
* }}}
*
* This test suite won't generate golden files. To re-generate golden files for entire suite, run:
* {{{
* SPARK_GENERATE_GOLDEN_FILES=1 build/sbt "sql/testOnly *SQLQueryTestSuite"
* }}}
*
+ * To re-generate golden file for a single test, run:
Review comment:
**"a single test"** - Such command can run multiple tests, for example:
```
SPARK_GENERATE_GOLDEN_FILES=1 build/sbt "sql/testOnly *SQLQueryTestSuite -- -z datetime.sql"
```
updates:
```
./sql/core/src/test/resources/sql-tests/inputs/ansi/datetime.sql
./sql/core/src/test/resources/sql-tests/inputs/datetime.sql
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32141: [MINOR][TESTS] Enhance the test instruction of ThriftServerQueryTestSuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32141:
URL: https://github.com/apache/spark/pull/32141#issuecomment-818566916
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41859/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32141: [MINOR][TEST] Enhance the test instruction of ThriftServerQueryTestSuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32141:
URL: https://github.com/apache/spark/pull/32141#issuecomment-818449567
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137275/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32141: [MINOR][TEST] Enhance the test instruction of ThriftServerQueryTestSuite
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32141:
URL: https://github.com/apache/spark/pull/32141#issuecomment-818448898
**[Test build #137275 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137275/testReport)** for PR 32141 at commit [`acc8108`](https://github.com/apache/spark/commit/acc8108dc0cb655e3a469d9e7a2dc7664270967f).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32141: [MINOR][TEST] Enhance the test instruction of ThriftServerQueryTestSuite
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32141:
URL: https://github.com/apache/spark/pull/32141#issuecomment-818429876
**[Test build #137275 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137275/testReport)** for PR 32141 at commit [`acc8108`](https://github.com/apache/spark/commit/acc8108dc0cb655e3a469d9e7a2dc7664270967f).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #32141: [Minor][Test] Enhance the test instruction of ThriftServerQueryTestSuite
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #32141:
URL: https://github.com/apache/spark/pull/32141#issuecomment-818443091
I am not sure is there a strict rule about the case of the tags. Should be `[MINOR][TEST]`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32141: [Minor][Test] Enhance the test instruction of ThriftServerQueryTestSuite
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32141:
URL: https://github.com/apache/spark/pull/32141#issuecomment-818429876
**[Test build #137275 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137275/testReport)** for PR 32141 at commit [`acc8108`](https://github.com/apache/spark/commit/acc8108dc0cb655e3a469d9e7a2dc7664270967f).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #32141: [MINOR][TEST] Enhance the test instruction of ThriftServerQueryTestSuite
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #32141:
URL: https://github.com/apache/spark/pull/32141#issuecomment-818452382
@gengliangwang `[TEST]` -> `[TESTS]`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #32141: [Minor][Test] Enhance the test instruction of ThriftServerQueryTestSuite
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #32141:
URL: https://github.com/apache/spark/pull/32141#discussion_r612134221
##########
File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/ThriftServerQueryTestSuite.scala
##########
@@ -36,16 +36,31 @@ import org.apache.spark.sql.types._
/**
* Re-run all the tests in SQLQueryTestSuite via Thrift Server.
*
+ * Each case is loaded from a file in "spark/sql/core/src/test/resources/sql-tests/inputs".
+ * Each case has a golden result file in "spark/sql/core/src/test/resources/sql-tests/results".
+ *
* To run the entire test suite:
* {{{
- * build/sbt "hive-thriftserver/testOnly *ThriftServerQueryTestSuite" -Phive-thriftserver
+ * build/sbt -Phive-thriftserver "hive-thriftserver/testOnly *ThriftServerQueryTestSuite"
+ * }}}
+ *
+ * To run a single test file upon change:
+ * {{{
+ * build/sbt -Phive-thriftserver \
Review comment:
Would be nice to put the example in one line. This would make life easier, so, devs could just copy-past it.
##########
File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/ThriftServerQueryTestSuite.scala
##########
@@ -36,16 +36,31 @@ import org.apache.spark.sql.types._
/**
* Re-run all the tests in SQLQueryTestSuite via Thrift Server.
*
+ * Each case is loaded from a file in "spark/sql/core/src/test/resources/sql-tests/inputs".
+ * Each case has a golden result file in "spark/sql/core/src/test/resources/sql-tests/results".
+ *
* To run the entire test suite:
* {{{
- * build/sbt "hive-thriftserver/testOnly *ThriftServerQueryTestSuite" -Phive-thriftserver
+ * build/sbt -Phive-thriftserver "hive-thriftserver/testOnly *ThriftServerQueryTestSuite"
Review comment:
Should we specify hive: `-Phive` or `-Phive-2.3`? I usually do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32141: [MINOR][TESTS] Enhance the test instruction of ThriftServerQueryTestSuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32141:
URL: https://github.com/apache/spark/pull/32141#issuecomment-818566916
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41859/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32141: [MINOR][TEST] Enhance the test instruction of ThriftServerQueryTestSuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32141:
URL: https://github.com/apache/spark/pull/32141#issuecomment-818449567
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137275/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a change in pull request #32141: [MINOR][TEST] Enhance the test instruction of ThriftServerQueryTestSuite
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on a change in pull request #32141:
URL: https://github.com/apache/spark/pull/32141#discussion_r612143413
##########
File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/ThriftServerQueryTestSuite.scala
##########
@@ -36,16 +36,31 @@ import org.apache.spark.sql.types._
/**
* Re-run all the tests in SQLQueryTestSuite via Thrift Server.
*
+ * Each case is loaded from a file in "spark/sql/core/src/test/resources/sql-tests/inputs".
+ * Each case has a golden result file in "spark/sql/core/src/test/resources/sql-tests/results".
+ *
* To run the entire test suite:
* {{{
- * build/sbt "hive-thriftserver/testOnly *ThriftServerQueryTestSuite" -Phive-thriftserver
+ * build/sbt -Phive-thriftserver "hive-thriftserver/testOnly *ThriftServerQueryTestSuite"
+ * }}}
+ *
+ * To run a single test file upon change:
+ * {{{
+ * build/sbt -Phive-thriftserver \
+ * "hive-thriftserver/testOnly *ThriftServerQueryTestSuite -- -z inline-table.sql"
+ *
* }}}
*
* This test suite won't generate golden files. To re-generate golden files for entire suite, run:
* {{{
* SPARK_GENERATE_GOLDEN_FILES=1 build/sbt "sql/testOnly *SQLQueryTestSuite"
* }}}
*
+ * To re-generate golden file for a single test, run:
Review comment:
Yeah I know. This is copied from `SQLQueryTestSuite`.
If the developer really wants to update the single test only, he/she has to use the exact test case name. Otherwise, "-z e.sql" can update multiple test outputs too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a change in pull request #32141: [MINOR][TEST] Enhance the test instruction of ThriftServerQueryTestSuite
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on a change in pull request #32141:
URL: https://github.com/apache/spark/pull/32141#discussion_r612142323
##########
File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/ThriftServerQueryTestSuite.scala
##########
@@ -36,16 +36,31 @@ import org.apache.spark.sql.types._
/**
* Re-run all the tests in SQLQueryTestSuite via Thrift Server.
*
+ * Each case is loaded from a file in "spark/sql/core/src/test/resources/sql-tests/inputs".
+ * Each case has a golden result file in "spark/sql/core/src/test/resources/sql-tests/results".
+ *
* To run the entire test suite:
* {{{
- * build/sbt "hive-thriftserver/testOnly *ThriftServerQueryTestSuite" -Phive-thriftserver
+ * build/sbt -Phive-thriftserver "hive-thriftserver/testOnly *ThriftServerQueryTestSuite"
Review comment:
`-Phive-thriftserver` is enough. Let's make it simple here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #32141: [MINOR][TESTS] Enhance the test instruction of ThriftServerQueryTestSuite
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #32141:
URL: https://github.com/apache/spark/pull/32141#discussion_r612162964
##########
File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/ThriftServerQueryTestSuite.scala
##########
@@ -36,16 +36,31 @@ import org.apache.spark.sql.types._
/**
* Re-run all the tests in SQLQueryTestSuite via Thrift Server.
*
+ * Each case is loaded from a file in "spark/sql/core/src/test/resources/sql-tests/inputs".
+ * Each case has a golden result file in "spark/sql/core/src/test/resources/sql-tests/results".
+ *
* To run the entire test suite:
* {{{
- * build/sbt "hive-thriftserver/testOnly *ThriftServerQueryTestSuite" -Phive-thriftserver
+ * build/sbt -Phive-thriftserver "hive-thriftserver/testOnly *ThriftServerQueryTestSuite"
+ * }}}
+ *
+ * To run a single test file upon change:
+ * {{{
+ * build/sbt -Phive-thriftserver \
Review comment:
```diff
diff --git a/sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/ThriftServerQueryTestSuite.scala b/sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/ThriftServerQueryTestSuite.scala
index dd008f738e..2cee97f31e 100644
--- a/sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/ThriftServerQueryTestSuite.scala
+++ b/sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/ThriftServerQueryTestSuite.scala
@@ -33,6 +33,7 @@ import org.apache.spark.sql.execution.HiveResult.{getTimeFormatters, toHiveStrin
import org.apache.spark.sql.internal.SQLConf
import org.apache.spark.sql.types._
+// scalastyle:off line.size.limit
/**
* Re-run all the tests in SQLQueryTestSuite via Thrift Server.
*
@@ -45,12 +46,17 @@ import org.apache.spark.sql.types._
* {{{
* SPARK_GENERATE_GOLDEN_FILES=1 build/sbt "sql/testOnly *SQLQueryTestSuite"
* }}}
+ * To run a single test file upon change:
+ * {{{
+ * build/sbt -Phive-thriftserver "hive-thriftserver/testOnly *ThriftServerQueryTestSuite -- -z inline-table.sql"
+ * }}}
*
* TODO:
* 1. Support UDF testing.
* 2. Support DESC command.
* 3. Support SHOW command.
*/
+// scalastyle:on line.size.limit
class ThriftServerQueryTestSuite extends SQLQueryTestSuite with SharedThriftServer {
```
```
$ ./dev/scalastyle
Scalastyle checks passed.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #32141: [MINOR][TESTS] Enhance the test instruction of ThriftServerQueryTestSuite
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #32141:
URL: https://github.com/apache/spark/pull/32141#discussion_r612144538
##########
File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/ThriftServerQueryTestSuite.scala
##########
@@ -36,16 +36,31 @@ import org.apache.spark.sql.types._
/**
* Re-run all the tests in SQLQueryTestSuite via Thrift Server.
*
+ * Each case is loaded from a file in "spark/sql/core/src/test/resources/sql-tests/inputs".
+ * Each case has a golden result file in "spark/sql/core/src/test/resources/sql-tests/results".
+ *
* To run the entire test suite:
* {{{
- * build/sbt "hive-thriftserver/testOnly *ThriftServerQueryTestSuite" -Phive-thriftserver
+ * build/sbt -Phive-thriftserver "hive-thriftserver/testOnly *ThriftServerQueryTestSuite"
+ * }}}
+ *
+ * To run a single test file upon change:
+ * {{{
+ * build/sbt -Phive-thriftserver \
Review comment:
Could you put `// scalastyle:off line.size.limit` around the comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #32141: [MINOR][TESTS] Enhance the test instruction of ThriftServerQueryTestSuite
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #32141:
URL: https://github.com/apache/spark/pull/32141#issuecomment-818565478
Merging to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32141: [MINOR][TESTS] Enhance the test instruction of ThriftServerQueryTestSuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32141:
URL: https://github.com/apache/spark/pull/32141#issuecomment-818512660
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32141: [MINOR][TESTS] Enhance the test instruction of ThriftServerQueryTestSuite
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32141:
URL: https://github.com/apache/spark/pull/32141#issuecomment-818502912
**[Test build #137279 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137279/testReport)** for PR 32141 at commit [`590632c`](https://github.com/apache/spark/commit/590632cc8486dd2610302aa11584a73981bf0342).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32141: [MINOR][TESTS] Enhance the test instruction of ThriftServerQueryTestSuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32141:
URL: https://github.com/apache/spark/pull/32141#issuecomment-818512658
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a change in pull request #32141: [MINOR][TEST] Enhance the test instruction of ThriftServerQueryTestSuite
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on a change in pull request #32141:
URL: https://github.com/apache/spark/pull/32141#discussion_r612142520
##########
File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/ThriftServerQueryTestSuite.scala
##########
@@ -36,16 +36,31 @@ import org.apache.spark.sql.types._
/**
* Re-run all the tests in SQLQueryTestSuite via Thrift Server.
*
+ * Each case is loaded from a file in "spark/sql/core/src/test/resources/sql-tests/inputs".
+ * Each case has a golden result file in "spark/sql/core/src/test/resources/sql-tests/results".
+ *
* To run the entire test suite:
* {{{
- * build/sbt "hive-thriftserver/testOnly *ThriftServerQueryTestSuite" -Phive-thriftserver
+ * build/sbt -Phive-thriftserver "hive-thriftserver/testOnly *ThriftServerQueryTestSuite"
+ * }}}
+ *
+ * To run a single test file upon change:
+ * {{{
+ * build/sbt -Phive-thriftserver \
Review comment:
It will exceed 100 chars.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32141: [MINOR][TESTS] Enhance the test instruction of ThriftServerQueryTestSuite
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32141:
URL: https://github.com/apache/spark/pull/32141#issuecomment-818479679
**[Test build #137279 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137279/testReport)** for PR 32141 at commit [`590632c`](https://github.com/apache/spark/commit/590632cc8486dd2610302aa11584a73981bf0342).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32141: [MINOR][TESTS] Enhance the test instruction of ThriftServerQueryTestSuite
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32141:
URL: https://github.com/apache/spark/pull/32141#issuecomment-818479679
**[Test build #137279 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137279/testReport)** for PR 32141 at commit [`590632c`](https://github.com/apache/spark/commit/590632cc8486dd2610302aa11584a73981bf0342).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32141: [MINOR][TESTS] Enhance the test instruction of ThriftServerQueryTestSuite
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32141:
URL: https://github.com/apache/spark/pull/32141#issuecomment-818566869
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32141: [MINOR][TESTS] Enhance the test instruction of ThriftServerQueryTestSuite
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32141:
URL: https://github.com/apache/spark/pull/32141#issuecomment-818509316
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #32141: [MINOR][TEST] Enhance the test instruction of ThriftServerQueryTestSuite
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #32141:
URL: https://github.com/apache/spark/pull/32141#discussion_r612139252
##########
File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/ThriftServerQueryTestSuite.scala
##########
@@ -36,16 +36,31 @@ import org.apache.spark.sql.types._
/**
* Re-run all the tests in SQLQueryTestSuite via Thrift Server.
*
+ * Each case is loaded from a file in "spark/sql/core/src/test/resources/sql-tests/inputs".
+ * Each case has a golden result file in "spark/sql/core/src/test/resources/sql-tests/results".
+ *
* To run the entire test suite:
* {{{
- * build/sbt "hive-thriftserver/testOnly *ThriftServerQueryTestSuite" -Phive-thriftserver
+ * build/sbt -Phive-thriftserver "hive-thriftserver/testOnly *ThriftServerQueryTestSuite"
+ * }}}
+ *
+ * To run a single test file upon change:
+ * {{{
+ * build/sbt -Phive-thriftserver \
+ * "hive-thriftserver/testOnly *ThriftServerQueryTestSuite -- -z inline-table.sql"
+ *
* }}}
*
* This test suite won't generate golden files. To re-generate golden files for entire suite, run:
* {{{
* SPARK_GENERATE_GOLDEN_FILES=1 build/sbt "sql/testOnly *SQLQueryTestSuite"
* }}}
*
+ * To re-generate golden file for a single test, run:
Review comment:
Such command can run multiple tests, for example:
```
SPARK_GENERATE_GOLDEN_FILES=1 build/sbt "sql/testOnly *SQLQueryTestSuite -- -z datetime.sql"
```
updates:
```
./sql/core/src/test/resources/sql-tests/inputs/ansi/datetime.sql
./sql/core/src/test/resources/sql-tests/inputs/datetime.sql
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a change in pull request #32141: [MINOR][TESTS] Enhance the test instruction of ThriftServerQueryTestSuite
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on a change in pull request #32141:
URL: https://github.com/apache/spark/pull/32141#discussion_r612155145
##########
File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/ThriftServerQueryTestSuite.scala
##########
@@ -36,16 +36,31 @@ import org.apache.spark.sql.types._
/**
* Re-run all the tests in SQLQueryTestSuite via Thrift Server.
*
+ * Each case is loaded from a file in "spark/sql/core/src/test/resources/sql-tests/inputs".
+ * Each case has a golden result file in "spark/sql/core/src/test/resources/sql-tests/results".
+ *
* To run the entire test suite:
* {{{
- * build/sbt "hive-thriftserver/testOnly *ThriftServerQueryTestSuite" -Phive-thriftserver
+ * build/sbt -Phive-thriftserver "hive-thriftserver/testOnly *ThriftServerQueryTestSuite"
+ * }}}
+ *
+ * To run a single test file upon change:
+ * {{{
+ * build/sbt -Phive-thriftserver \
Review comment:
@MaxGekk I tried but it won't pass the scala style check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org