You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/09/11 21:08:23 UTC

[GitHub] [beam] tvalentyn commented on pull request #12811: [BEAM-10705] Fixes a bug when passing whl files in --sdk_location from https locations

tvalentyn commented on pull request #12811:
URL: https://github.com/apache/beam/pull/12811#issuecomment-691312707


   Thanks a lot, @samatix ! Overall the change looks good. There is a linter error:
   ```
   09:40:28 apache_beam/runners/portability/stager_test.py:451:0: C0301: Line too long (81/80) (line-too-long)
   ```
   Also, we will need to Drop Py2 and Py35 support before we can merge this (Py2, Py 3.5.2 tests are failing on this change right now).
   
   This should happen before next release.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org