You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/02/09 06:23:46 UTC

[GitHub] [druid] LakshSingla opened a new pull request #12243: Initial commit, explain plan for custom insert syntax working

LakshSingla opened a new pull request #12243:
URL: https://github.com/apache/druid/pull/12243


   Follow up to https://github.com/apache/druid/pull/12163. 
   
   ### Description
   
   This PR adds the capability of running `EXPLAIN PLAN FOR` queries for statements with syntax having PARTITIONED BY and CLUSTERED BY clauses. Also, as a result, it disallows parsing insert statements that do not have a PARTITIONED BY.
   `explain.ftl` encapsulates the logic to do so.
   
   Code cleanup is also done since after this change, there is no need to handle SqlInsert and DruidSqlInsert separately in DruidPlanner's ParsedNodes.
   
   <hr>
   
   ##### Key changed/added classes in this PR
    * `explain.ftl`
   
   <hr>
   
   <!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist below are strictly necessary, but it would be very helpful if you at least self-review the PR. -->
   
   This PR has:
   - [ ] been self-reviewed.
      - [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
   - [ ] added documentation for new or modified features or behaviors.
   - [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
   - [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
   - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
   - [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
   - [ ] added integration tests.
   - [ ] been tested in a test Druid cluster.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] gianm merged pull request #12243: Explain plan for custom insert syntax

Posted by GitBox <gi...@apache.org>.
gianm merged pull request #12243:
URL: https://github.com/apache/druid/pull/12243


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org