You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/02/13 23:04:48 UTC
[GitHub] [nifi] granthenke opened a new pull request #4054: NIFI-6551:
Improve PutKudu timestamp handling
granthenke opened a new pull request #4054: NIFI-6551: Improve PutKudu timestamp handling
URL: https://github.com/apache/nifi/pull/4054
Uses `DataTypeUtils.toTimestamp` when writing to Kudu
timestamp (`UNIXTIME_MICROS`) columns. This allows
us to use the `row.addTimestamp` API and get much more
intuitive and predictable timestamp ingest behavior.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] pvillard31 commented on a change in pull request #4054:
NIFI-6551: Improve PutKudu timestamp handling
Posted by GitBox <gi...@apache.org>.
pvillard31 commented on a change in pull request #4054: NIFI-6551: Improve PutKudu timestamp handling
URL: https://github.com/apache/nifi/pull/4054#discussion_r379219224
##########
File path: nifi-nar-bundles/nifi-kudu-bundle/nifi-kudu-processors/src/main/java/org/apache/nifi/processors/kudu/AbstractKuduProcessor.java
##########
@@ -181,47 +184,50 @@ protected void buildPartialRow(Schema schema, PartialRow row, Record record, Lis
if (schema.getColumnByIndex(colIdx).isKey()) {
throw new IllegalArgumentException(String.format("Can't set primary key column %s to null ", colName));
} else if(!schema.getColumnByIndex(colIdx).isNullable()) {
- throw new IllegalArgumentException(String.format("Can't set primary key column %s to null ", colName));
+ throw new IllegalArgumentException(String.format("Can't column %s to null ", colName));
Review comment:
```suggestion
throw new IllegalArgumentException(String.format("Can't set column %s to null ", colName));
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] granthenke commented on issue #4054: NIFI-6551: Improve
PutKudu timestamp handling
Posted by GitBox <gi...@apache.org>.
granthenke commented on issue #4054: NIFI-6551: Improve PutKudu timestamp handling
URL: https://github.com/apache/nifi/pull/4054#issuecomment-587926541
I will rebase this after #4063 gets in.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] asfgit closed pull request #4054: NIFI-6551: Improve PutKudu
timestamp handling
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4054: NIFI-6551: Improve PutKudu timestamp handling
URL: https://github.com/apache/nifi/pull/4054
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] granthenke commented on issue #4054: NIFI-6551: Improve
PutKudu timestamp handling
Posted by GitBox <gi...@apache.org>.
granthenke commented on issue #4054: NIFI-6551: Improve PutKudu timestamp handling
URL: https://github.com/apache/nifi/pull/4054#issuecomment-587554209
I rebased onto the latest master changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] pvillard31 commented on issue #4054: NIFI-6551: Improve
PutKudu timestamp handling
Posted by GitBox <gi...@apache.org>.
pvillard31 commented on issue #4054: NIFI-6551: Improve PutKudu timestamp handling
URL: https://github.com/apache/nifi/pull/4054#issuecomment-587956332
LGTM.
- I updated the [Migration Guidance page](https://cwiki.apache.org/confluence/display/NIFI/Migration+Guidance) to reflect this change
- merged this PR into master
Thanks @granthenke
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] granthenke commented on issue #4054: NIFI-6551: Improve
PutKudu timestamp handling
Posted by GitBox <gi...@apache.org>.
granthenke commented on issue #4054: NIFI-6551: Improve PutKudu timestamp handling
URL: https://github.com/apache/nifi/pull/4054#issuecomment-586294205
It would potentially break workflows which convert milliseconds into microseconds manually before sending to kudu today.
We could release note it, or I could specially handling long RecordFieldTypes to keep treating them as micros. We could also put the special micros handling behind a configuration flag. I suspect the least surprising behavior is to treat all numerical values as milliseconds though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] pvillard31 commented on issue #4054: NIFI-6551: Improve
PutKudu timestamp handling
Posted by GitBox <gi...@apache.org>.
pvillard31 commented on issue #4054: NIFI-6551: Improve PutKudu timestamp handling
URL: https://github.com/apache/nifi/pull/4054#issuecomment-587804999
@granthenke - can you rebase now that I merged #4053?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services