You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hawq.apache.org by Gmail <xu...@gmail.com> on 2016/07/12 11:31:10 UTC
Rename "greenplum" to "hawq"
Hi hawq developers,
I am a little confused with the greenplum strings(code, file, comment) inside hawq code base. Does these codes still rely on upstream gpdb? If not, could it possible to rename them with "hawq"?
Also, if these strings are left, as a developer, sometimes I think that the bugs in that forked version of greenplum might also be a issue in latest HAWQ. Another uncomfortable experience is that before running HAWQ, users should source "greenplum.sh".
Best
xunzhang
Send from my iPhone
Re: Rename "greenplum" to "hawq"
Posted by Jiali Yao <jy...@pivotal.io>.
I think it would be more confusing since there are two files and
environment variables have same purpose.
I think it is worth to investigate the impact from code and user and to
replace greenplum.
Jiali
On Wed, Jul 13, 2016 at 2:01 PM, Lili Ma <li...@apache.org> wrote:
> For the command line tools name, what about we keep greenplum_path.sh and
> add a hawq_env.sh and inside hawq_env.sh, we call greenplum_path.sh. So the
> already user won't need to change their behavior, and new user can directly
> use the new hawq named script?
>
> For the environment variable, for example GPHOME，can we create a new
> variable HAWQHOME, and set it the same value as GPHOME?
>
>
> Thanks
> Lili
>
> 2016-07-13 13:55 GMT+08:00 Yi Jin <yj...@pivotal.io>:
>
> > I think it is a must-do, but some concerns of customer using convention
> and
> > legacy applications, scripts etc.
> >
> > On Wed, Jul 13, 2016 at 1:44 PM, 陶征霖 <zt...@apache.org> wrote:
> >
> > > Good idea, but need quite a lot of effort and may also affect custormer
> > > behavior. Should handle it carefully.
> > >
> > > 2016-07-13 9:54 GMT+08:00 Ivan Weng <iw...@pivotal.io>:
> > >
> > > > Agree with this good idea. But as Paul said, there are maybe already
> > many
> > > > users use greeenplum_path.sh or something else in their environment.
> So
> > > we
> > > > need to think about it.
> > > >
> > > >
> > > > Regards,
> > > > Ivan
> > > >
> > > > On Wed, Jul 13, 2016 at 9:31 AM, Paul Guo <pa...@gmail.com> wrote:
> > > >
> > > > > I've asked this before. Seems that affects some old users. I'm not
> > sure
> > > > > about the details.
> > > > > I agree that we should change it to a better name in a release.
> > > > >
> > > > > 2016-07-13 9:25 GMT+08:00 Roman Shaposhnik <ro...@shaposhnik.org>:
> > > > >
> > > > > > On Tue, Jul 12, 2016 at 6:21 PM, Xiang Sheng <xs...@pivotal.io>
> > > > wrote:
> > > > > > > Agree . @xunzhang.
> > > > > > > However , some greenplum strings can be easily replaced , but
> > there
> > > > are
> > > > > > too
> > > > > > > many in the code or comments. Changing all of them costs too
> > much
> > > > > > efforts.
> > > > > > >
> > > > > > > So changing the strings that users can see is enough.
> > > > > >
> > > > > > Huge +1 to this! Btw, is this something we may be able to tackle
> in
> > > our
> > > > > > next Apache release?
> > > > > >
> > > > > > Thanks,
> > > > > > Roman.
> > > > > >
> > > > >
> > > >
> > >
> > >
> > >
> > > --
> > > Thanks,
> > > Zhenglin
> > >
> >
>
Re: Rename "greenplum" to "hawq"
Posted by Hong Wu <xu...@gmail.com>.
Thank you for comments.
I think LILI's suggestion is like a workaround or a temporary version which
is not that neat.
From user's perspective, we should list all usage changes for them if we
rename, then have a further discussion/decision. Also, I think they should
be evolving too. Take a little effect to have great upgrade is worthy. Of
course, we should give them a buffer to transfer.
Best
xunzhang
2016-07-13 14:01 GMT+08:00 Lili Ma <li...@apache.org>:
> For the command line tools name, what about we keep greenplum_path.sh and
> add a hawq_env.sh and inside hawq_env.sh, we call greenplum_path.sh. So the
> already user won't need to change their behavior, and new user can directly
> use the new hawq named script?
>
> For the environment variable, for example GPHOME，can we create a new
> variable HAWQHOME, and set it the same value as GPHOME?
>
>
> Thanks
> Lili
>
> 2016-07-13 13:55 GMT+08:00 Yi Jin <yj...@pivotal.io>:
>
> > I think it is a must-do, but some concerns of customer using convention
> and
> > legacy applications, scripts etc.
> >
> > On Wed, Jul 13, 2016 at 1:44 PM, 陶征霖 <zt...@apache.org> wrote:
> >
> > > Good idea, but need quite a lot of effort and may also affect custormer
> > > behavior. Should handle it carefully.
> > >
> > > 2016-07-13 9:54 GMT+08:00 Ivan Weng <iw...@pivotal.io>:
> > >
> > > > Agree with this good idea. But as Paul said, there are maybe already
> > many
> > > > users use greeenplum_path.sh or something else in their environment.
> So
> > > we
> > > > need to think about it.
> > > >
> > > >
> > > > Regards,
> > > > Ivan
> > > >
> > > > On Wed, Jul 13, 2016 at 9:31 AM, Paul Guo <pa...@gmail.com> wrote:
> > > >
> > > > > I've asked this before. Seems that affects some old users. I'm not
> > sure
> > > > > about the details.
> > > > > I agree that we should change it to a better name in a release.
> > > > >
> > > > > 2016-07-13 9:25 GMT+08:00 Roman Shaposhnik <ro...@shaposhnik.org>:
> > > > >
> > > > > > On Tue, Jul 12, 2016 at 6:21 PM, Xiang Sheng <xs...@pivotal.io>
> > > > wrote:
> > > > > > > Agree . @xunzhang.
> > > > > > > However , some greenplum strings can be easily replaced , but
> > there
> > > > are
> > > > > > too
> > > > > > > many in the code or comments. Changing all of them costs too
> > much
> > > > > > efforts.
> > > > > > >
> > > > > > > So changing the strings that users can see is enough.
> > > > > >
> > > > > > Huge +1 to this! Btw, is this something we may be able to tackle
> in
> > > our
> > > > > > next Apache release?
> > > > > >
> > > > > > Thanks,
> > > > > > Roman.
> > > > > >
> > > > >
> > > >
> > >
> > >
> > >
> > > --
> > > Thanks,
> > > Zhenglin
> > >
> >
>
Re: Rename "greenplum" to "hawq"
Posted by Lili Ma <li...@apache.org>.
For the command line tools name, what about we keep greenplum_path.sh and
add a hawq_env.sh and inside hawq_env.sh, we call greenplum_path.sh. So the
already user won't need to change their behavior, and new user can directly
use the new hawq named script?
For the environment variable, for example GPHOME，can we create a new
variable HAWQHOME, and set it the same value as GPHOME?
Thanks
Lili
2016-07-13 13:55 GMT+08:00 Yi Jin <yj...@pivotal.io>:
> I think it is a must-do, but some concerns of customer using convention and
> legacy applications, scripts etc.
>
> On Wed, Jul 13, 2016 at 1:44 PM, 陶征霖 <zt...@apache.org> wrote:
>
> > Good idea, but need quite a lot of effort and may also affect custormer
> > behavior. Should handle it carefully.
> >
> > 2016-07-13 9:54 GMT+08:00 Ivan Weng <iw...@pivotal.io>:
> >
> > > Agree with this good idea. But as Paul said, there are maybe already
> many
> > > users use greeenplum_path.sh or something else in their environment. So
> > we
> > > need to think about it.
> > >
> > >
> > > Regards,
> > > Ivan
> > >
> > > On Wed, Jul 13, 2016 at 9:31 AM, Paul Guo <pa...@gmail.com> wrote:
> > >
> > > > I've asked this before. Seems that affects some old users. I'm not
> sure
> > > > about the details.
> > > > I agree that we should change it to a better name in a release.
> > > >
> > > > 2016-07-13 9:25 GMT+08:00 Roman Shaposhnik <ro...@shaposhnik.org>:
> > > >
> > > > > On Tue, Jul 12, 2016 at 6:21 PM, Xiang Sheng <xs...@pivotal.io>
> > > wrote:
> > > > > > Agree . @xunzhang.
> > > > > > However , some greenplum strings can be easily replaced , but
> there
> > > are
> > > > > too
> > > > > > many in the code or comments. Changing all of them costs too
> much
> > > > > efforts.
> > > > > >
> > > > > > So changing the strings that users can see is enough.
> > > > >
> > > > > Huge +1 to this! Btw, is this something we may be able to tackle in
> > our
> > > > > next Apache release?
> > > > >
> > > > > Thanks,
> > > > > Roman.
> > > > >
> > > >
> > >
> >
> >
> >
> > --
> > Thanks,
> > Zhenglin
> >
>
Re: Rename "greenplum" to "hawq"
Posted by "Ting(Goden) Yao" <ty...@pivotal.io>.
Thanks, I've update the JIRA with more info and corrected versions. I think
we have the consensus that this needs to be done.
Please add more details in the JIRA or add tasks as appropriate.
On Wed, Jul 13, 2016 at 10:33 AM Lisa Owen <lo...@pivotal.io> wrote:
> there is an existing JIRA related to renaming greenplum references:
>
> https://issues.apache.org/jira/browse/HAWQ-902
>
>
> On Wed, Jul 13, 2016 at 10:20 AM, Ting(Goden) Yao <ty...@pivotal.io> wrote:
>
> > can anyone who knows details start filing jira and mark the version to
> > "2.0.1.0-incubating" or backlog?
> >
> > On Tue, Jul 12, 2016 at 11:56 PM Hubert Zhang <hz...@pivotal.io> wrote:
> >
> > > +1 This is a legacy problem. Clear GUCs including "GP" may be the first
> > > step.
> > >
> > > On Wed, Jul 13, 2016 at 2:07 PM, Wen Lin <wl...@pivotal.io> wrote:
> > >
> > > > It's definitely a good thing, but needs very careful thought on
> effects
> > > to
> > > > customers.
> > > > We can try to list these effects as much as possile.
> > > >
> > > > On Wed, Jul 13, 2016 at 1:55 PM, Yi Jin <yj...@pivotal.io> wrote:
> > > >
> > > > > I think it is a must-do, but some concerns of customer using
> > convention
> > > > and
> > > > > legacy applications, scripts etc.
> > > > >
> > > > > On Wed, Jul 13, 2016 at 1:44 PM, 陶征霖 <zt...@apache.org> wrote:
> > > > >
> > > > > > Good idea, but need quite a lot of effort and may also affect
> > > custormer
> > > > > > behavior. Should handle it carefully.
> > > > > >
> > > > > > 2016-07-13 9:54 GMT+08:00 Ivan Weng <iw...@pivotal.io>:
> > > > > >
> > > > > > > Agree with this good idea. But as Paul said, there are maybe
> > > already
> > > > > many
> > > > > > > users use greeenplum_path.sh or something else in their
> > > environment.
> > > > So
> > > > > > we
> > > > > > > need to think about it.
> > > > > > >
> > > > > > >
> > > > > > > Regards,
> > > > > > > Ivan
> > > > > > >
> > > > > > > On Wed, Jul 13, 2016 at 9:31 AM, Paul Guo <pa...@gmail.com>
> > > wrote:
> > > > > > >
> > > > > > > > I've asked this before. Seems that affects some old users.
> I'm
> > > not
> > > > > sure
> > > > > > > > about the details.
> > > > > > > > I agree that we should change it to a better name in a
> release.
> > > > > > > >
> > > > > > > > 2016-07-13 9:25 GMT+08:00 Roman Shaposhnik <
> > roman@shaposhnik.org
> > > >:
> > > > > > > >
> > > > > > > > > On Tue, Jul 12, 2016 at 6:21 PM, Xiang Sheng <
> > > xsheng@pivotal.io>
> > > > > > > wrote:
> > > > > > > > > > Agree . @xunzhang.
> > > > > > > > > > However , some greenplum strings can be easily replaced ,
> > but
> > > > > there
> > > > > > > are
> > > > > > > > > too
> > > > > > > > > > many in the code or comments. Changing all of them costs
> > too
> > > > > much
> > > > > > > > > efforts.
> > > > > > > > > >
> > > > > > > > > > So changing the strings that users can see is enough.
> > > > > > > > >
> > > > > > > > > Huge +1 to this! Btw, is this something we may be able to
> > > tackle
> > > > in
> > > > > > our
> > > > > > > > > next Apache release?
> > > > > > > > >
> > > > > > > > > Thanks,
> > > > > > > > > Roman.
> > > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > > > --
> > > > > > Thanks,
> > > > > > Zhenglin
> > > > > >
> > > > >
> > > >
> > >
> > >
> > >
> > > --
> > > Thanks
> > >
> > > Hubert Zhang
> > >
> >
>
Re: Rename "greenplum" to "hawq"
Posted by Lisa Owen <lo...@pivotal.io>.
there is an existing JIRA related to renaming greenplum references:
https://issues.apache.org/jira/browse/HAWQ-902
On Wed, Jul 13, 2016 at 10:20 AM, Ting(Goden) Yao <ty...@pivotal.io> wrote:
> can anyone who knows details start filing jira and mark the version to
> "2.0.1.0-incubating" or backlog?
>
> On Tue, Jul 12, 2016 at 11:56 PM Hubert Zhang <hz...@pivotal.io> wrote:
>
> > +1 This is a legacy problem. Clear GUCs including "GP" may be the first
> > step.
> >
> > On Wed, Jul 13, 2016 at 2:07 PM, Wen Lin <wl...@pivotal.io> wrote:
> >
> > > It's definitely a good thing, but needs very careful thought on effects
> > to
> > > customers.
> > > We can try to list these effects as much as possile.
> > >
> > > On Wed, Jul 13, 2016 at 1:55 PM, Yi Jin <yj...@pivotal.io> wrote:
> > >
> > > > I think it is a must-do, but some concerns of customer using
> convention
> > > and
> > > > legacy applications, scripts etc.
> > > >
> > > > On Wed, Jul 13, 2016 at 1:44 PM, 陶征霖 <zt...@apache.org> wrote:
> > > >
> > > > > Good idea, but need quite a lot of effort and may also affect
> > custormer
> > > > > behavior. Should handle it carefully.
> > > > >
> > > > > 2016-07-13 9:54 GMT+08:00 Ivan Weng <iw...@pivotal.io>:
> > > > >
> > > > > > Agree with this good idea. But as Paul said, there are maybe
> > already
> > > > many
> > > > > > users use greeenplum_path.sh or something else in their
> > environment.
> > > So
> > > > > we
> > > > > > need to think about it.
> > > > > >
> > > > > >
> > > > > > Regards,
> > > > > > Ivan
> > > > > >
> > > > > > On Wed, Jul 13, 2016 at 9:31 AM, Paul Guo <pa...@gmail.com>
> > wrote:
> > > > > >
> > > > > > > I've asked this before. Seems that affects some old users. I'm
> > not
> > > > sure
> > > > > > > about the details.
> > > > > > > I agree that we should change it to a better name in a release.
> > > > > > >
> > > > > > > 2016-07-13 9:25 GMT+08:00 Roman Shaposhnik <
> roman@shaposhnik.org
> > >:
> > > > > > >
> > > > > > > > On Tue, Jul 12, 2016 at 6:21 PM, Xiang Sheng <
> > xsheng@pivotal.io>
> > > > > > wrote:
> > > > > > > > > Agree . @xunzhang.
> > > > > > > > > However , some greenplum strings can be easily replaced ,
> but
> > > > there
> > > > > > are
> > > > > > > > too
> > > > > > > > > many in the code or comments. Changing all of them costs
> too
> > > > much
> > > > > > > > efforts.
> > > > > > > > >
> > > > > > > > > So changing the strings that users can see is enough.
> > > > > > > >
> > > > > > > > Huge +1 to this! Btw, is this something we may be able to
> > tackle
> > > in
> > > > > our
> > > > > > > > next Apache release?
> > > > > > > >
> > > > > > > > Thanks,
> > > > > > > > Roman.
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Thanks,
> > > > > Zhenglin
> > > > >
> > > >
> > >
> >
> >
> >
> > --
> > Thanks
> >
> > Hubert Zhang
> >
>
Re: Rename "greenplum" to "hawq"
Posted by "Ting(Goden) Yao" <ty...@pivotal.io>.
can anyone who knows details start filing jira and mark the version to
"2.0.1.0-incubating" or backlog?
On Tue, Jul 12, 2016 at 11:56 PM Hubert Zhang <hz...@pivotal.io> wrote:
> +1 This is a legacy problem. Clear GUCs including "GP" may be the first
> step.
>
> On Wed, Jul 13, 2016 at 2:07 PM, Wen Lin <wl...@pivotal.io> wrote:
>
> > It's definitely a good thing, but needs very careful thought on effects
> to
> > customers.
> > We can try to list these effects as much as possile.
> >
> > On Wed, Jul 13, 2016 at 1:55 PM, Yi Jin <yj...@pivotal.io> wrote:
> >
> > > I think it is a must-do, but some concerns of customer using convention
> > and
> > > legacy applications, scripts etc.
> > >
> > > On Wed, Jul 13, 2016 at 1:44 PM, 陶征霖 <zt...@apache.org> wrote:
> > >
> > > > Good idea, but need quite a lot of effort and may also affect
> custormer
> > > > behavior. Should handle it carefully.
> > > >
> > > > 2016-07-13 9:54 GMT+08:00 Ivan Weng <iw...@pivotal.io>:
> > > >
> > > > > Agree with this good idea. But as Paul said, there are maybe
> already
> > > many
> > > > > users use greeenplum_path.sh or something else in their
> environment.
> > So
> > > > we
> > > > > need to think about it.
> > > > >
> > > > >
> > > > > Regards,
> > > > > Ivan
> > > > >
> > > > > On Wed, Jul 13, 2016 at 9:31 AM, Paul Guo <pa...@gmail.com>
> wrote:
> > > > >
> > > > > > I've asked this before. Seems that affects some old users. I'm
> not
> > > sure
> > > > > > about the details.
> > > > > > I agree that we should change it to a better name in a release.
> > > > > >
> > > > > > 2016-07-13 9:25 GMT+08:00 Roman Shaposhnik <roman@shaposhnik.org
> >:
> > > > > >
> > > > > > > On Tue, Jul 12, 2016 at 6:21 PM, Xiang Sheng <
> xsheng@pivotal.io>
> > > > > wrote:
> > > > > > > > Agree . @xunzhang.
> > > > > > > > However , some greenplum strings can be easily replaced , but
> > > there
> > > > > are
> > > > > > > too
> > > > > > > > many in the code or comments. Changing all of them costs too
> > > much
> > > > > > > efforts.
> > > > > > > >
> > > > > > > > So changing the strings that users can see is enough.
> > > > > > >
> > > > > > > Huge +1 to this! Btw, is this something we may be able to
> tackle
> > in
> > > > our
> > > > > > > next Apache release?
> > > > > > >
> > > > > > > Thanks,
> > > > > > > Roman.
> > > > > > >
> > > > > >
> > > > >
> > > >
> > > >
> > > >
> > > > --
> > > > Thanks,
> > > > Zhenglin
> > > >
> > >
> >
>
>
>
> --
> Thanks
>
> Hubert Zhang
>
Re: Rename "greenplum" to "hawq"
Posted by Hubert Zhang <hz...@pivotal.io>.
+1 This is a legacy problem. Clear GUCs including "GP" may be the first
step.
On Wed, Jul 13, 2016 at 2:07 PM, Wen Lin <wl...@pivotal.io> wrote:
> It's definitely a good thing, but needs very careful thought on effects to
> customers.
> We can try to list these effects as much as possile.
>
> On Wed, Jul 13, 2016 at 1:55 PM, Yi Jin <yj...@pivotal.io> wrote:
>
> > I think it is a must-do, but some concerns of customer using convention
> and
> > legacy applications, scripts etc.
> >
> > On Wed, Jul 13, 2016 at 1:44 PM, 陶征霖 <zt...@apache.org> wrote:
> >
> > > Good idea, but need quite a lot of effort and may also affect custormer
> > > behavior. Should handle it carefully.
> > >
> > > 2016-07-13 9:54 GMT+08:00 Ivan Weng <iw...@pivotal.io>:
> > >
> > > > Agree with this good idea. But as Paul said, there are maybe already
> > many
> > > > users use greeenplum_path.sh or something else in their environment.
> So
> > > we
> > > > need to think about it.
> > > >
> > > >
> > > > Regards,
> > > > Ivan
> > > >
> > > > On Wed, Jul 13, 2016 at 9:31 AM, Paul Guo <pa...@gmail.com> wrote:
> > > >
> > > > > I've asked this before. Seems that affects some old users. I'm not
> > sure
> > > > > about the details.
> > > > > I agree that we should change it to a better name in a release.
> > > > >
> > > > > 2016-07-13 9:25 GMT+08:00 Roman Shaposhnik <ro...@shaposhnik.org>:
> > > > >
> > > > > > On Tue, Jul 12, 2016 at 6:21 PM, Xiang Sheng <xs...@pivotal.io>
> > > > wrote:
> > > > > > > Agree . @xunzhang.
> > > > > > > However , some greenplum strings can be easily replaced , but
> > there
> > > > are
> > > > > > too
> > > > > > > many in the code or comments. Changing all of them costs too
> > much
> > > > > > efforts.
> > > > > > >
> > > > > > > So changing the strings that users can see is enough.
> > > > > >
> > > > > > Huge +1 to this! Btw, is this something we may be able to tackle
> in
> > > our
> > > > > > next Apache release?
> > > > > >
> > > > > > Thanks,
> > > > > > Roman.
> > > > > >
> > > > >
> > > >
> > >
> > >
> > >
> > > --
> > > Thanks,
> > > Zhenglin
> > >
> >
>
--
Thanks
Hubert Zhang
Re: Rename "greenplum" to "hawq"
Posted by Wen Lin <wl...@pivotal.io>.
It's definitely a good thing, but needs very careful thought on effects to
customers.
We can try to list these effects as much as possile.
On Wed, Jul 13, 2016 at 1:55 PM, Yi Jin <yj...@pivotal.io> wrote:
> I think it is a must-do, but some concerns of customer using convention and
> legacy applications, scripts etc.
>
> On Wed, Jul 13, 2016 at 1:44 PM, 陶征霖 <zt...@apache.org> wrote:
>
> > Good idea, but need quite a lot of effort and may also affect custormer
> > behavior. Should handle it carefully.
> >
> > 2016-07-13 9:54 GMT+08:00 Ivan Weng <iw...@pivotal.io>:
> >
> > > Agree with this good idea. But as Paul said, there are maybe already
> many
> > > users use greeenplum_path.sh or something else in their environment. So
> > we
> > > need to think about it.
> > >
> > >
> > > Regards,
> > > Ivan
> > >
> > > On Wed, Jul 13, 2016 at 9:31 AM, Paul Guo <pa...@gmail.com> wrote:
> > >
> > > > I've asked this before. Seems that affects some old users. I'm not
> sure
> > > > about the details.
> > > > I agree that we should change it to a better name in a release.
> > > >
> > > > 2016-07-13 9:25 GMT+08:00 Roman Shaposhnik <ro...@shaposhnik.org>:
> > > >
> > > > > On Tue, Jul 12, 2016 at 6:21 PM, Xiang Sheng <xs...@pivotal.io>
> > > wrote:
> > > > > > Agree . @xunzhang.
> > > > > > However , some greenplum strings can be easily replaced , but
> there
> > > are
> > > > > too
> > > > > > many in the code or comments. Changing all of them costs too
> much
> > > > > efforts.
> > > > > >
> > > > > > So changing the strings that users can see is enough.
> > > > >
> > > > > Huge +1 to this! Btw, is this something we may be able to tackle in
> > our
> > > > > next Apache release?
> > > > >
> > > > > Thanks,
> > > > > Roman.
> > > > >
> > > >
> > >
> >
> >
> >
> > --
> > Thanks,
> > Zhenglin
> >
>
Re: Rename "greenplum" to "hawq"
Posted by Yi Jin <yj...@pivotal.io>.
I think it is a must-do, but some concerns of customer using convention and
legacy applications, scripts etc.
On Wed, Jul 13, 2016 at 1:44 PM, 陶征霖 <zt...@apache.org> wrote:
> Good idea, but need quite a lot of effort and may also affect custormer
> behavior. Should handle it carefully.
>
> 2016-07-13 9:54 GMT+08:00 Ivan Weng <iw...@pivotal.io>:
>
> > Agree with this good idea. But as Paul said, there are maybe already many
> > users use greeenplum_path.sh or something else in their environment. So
> we
> > need to think about it.
> >
> >
> > Regards,
> > Ivan
> >
> > On Wed, Jul 13, 2016 at 9:31 AM, Paul Guo <pa...@gmail.com> wrote:
> >
> > > I've asked this before. Seems that affects some old users. I'm not sure
> > > about the details.
> > > I agree that we should change it to a better name in a release.
> > >
> > > 2016-07-13 9:25 GMT+08:00 Roman Shaposhnik <ro...@shaposhnik.org>:
> > >
> > > > On Tue, Jul 12, 2016 at 6:21 PM, Xiang Sheng <xs...@pivotal.io>
> > wrote:
> > > > > Agree . @xunzhang.
> > > > > However , some greenplum strings can be easily replaced , but there
> > are
> > > > too
> > > > > many in the code or comments. Changing all of them costs too much
> > > > efforts.
> > > > >
> > > > > So changing the strings that users can see is enough.
> > > >
> > > > Huge +1 to this! Btw, is this something we may be able to tackle in
> our
> > > > next Apache release?
> > > >
> > > > Thanks,
> > > > Roman.
> > > >
> > >
> >
>
>
>
> --
> Thanks,
> Zhenglin
>
Re: Rename "greenplum" to "hawq"
Posted by 陶征霖 <zt...@apache.org>.
Good idea, but need quite a lot of effort and may also affect custormer
behavior. Should handle it carefully.
2016-07-13 9:54 GMT+08:00 Ivan Weng <iw...@pivotal.io>:
> Agree with this good idea. But as Paul said, there are maybe already many
> users use greeenplum_path.sh or something else in their environment. So we
> need to think about it.
>
>
> Regards,
> Ivan
>
> On Wed, Jul 13, 2016 at 9:31 AM, Paul Guo <pa...@gmail.com> wrote:
>
> > I've asked this before. Seems that affects some old users. I'm not sure
> > about the details.
> > I agree that we should change it to a better name in a release.
> >
> > 2016-07-13 9:25 GMT+08:00 Roman Shaposhnik <ro...@shaposhnik.org>:
> >
> > > On Tue, Jul 12, 2016 at 6:21 PM, Xiang Sheng <xs...@pivotal.io>
> wrote:
> > > > Agree . @xunzhang.
> > > > However , some greenplum strings can be easily replaced , but there
> are
> > > too
> > > > many in the code or comments. Changing all of them costs too much
> > > efforts.
> > > >
> > > > So changing the strings that users can see is enough.
> > >
> > > Huge +1 to this! Btw, is this something we may be able to tackle in our
> > > next Apache release?
> > >
> > > Thanks,
> > > Roman.
> > >
> >
>
--
Thanks,
Zhenglin
Re: Rename "greenplum" to "hawq"
Posted by Ivan Weng <iw...@pivotal.io>.
Agree with this good idea. But as Paul said, there are maybe already many
users use greeenplum_path.sh or something else in their environment. So we
need to think about it.
Regards,
Ivan
On Wed, Jul 13, 2016 at 9:31 AM, Paul Guo <pa...@gmail.com> wrote:
> I've asked this before. Seems that affects some old users. I'm not sure
> about the details.
> I agree that we should change it to a better name in a release.
>
> 2016-07-13 9:25 GMT+08:00 Roman Shaposhnik <ro...@shaposhnik.org>:
>
> > On Tue, Jul 12, 2016 at 6:21 PM, Xiang Sheng <xs...@pivotal.io> wrote:
> > > Agree . @xunzhang.
> > > However , some greenplum strings can be easily replaced , but there are
> > too
> > > many in the code or comments. Changing all of them costs too much
> > efforts.
> > >
> > > So changing the strings that users can see is enough.
> >
> > Huge +1 to this! Btw, is this something we may be able to tackle in our
> > next Apache release?
> >
> > Thanks,
> > Roman.
> >
>
Re: Rename "greenplum" to "hawq"
Posted by Paul Guo <pa...@gmail.com>.
I've asked this before. Seems that affects some old users. I'm not sure
about the details.
I agree that we should change it to a better name in a release.
2016-07-13 9:25 GMT+08:00 Roman Shaposhnik <ro...@shaposhnik.org>:
> On Tue, Jul 12, 2016 at 6:21 PM, Xiang Sheng <xs...@pivotal.io> wrote:
> > Agree . @xunzhang.
> > However , some greenplum strings can be easily replaced , but there are
> too
> > many in the code or comments. Changing all of them costs too much
> efforts.
> >
> > So changing the strings that users can see is enough.
>
> Huge +1 to this! Btw, is this something we may be able to tackle in our
> next Apache release?
>
> Thanks,
> Roman.
>
Re: Rename "greenplum" to "hawq"
Posted by Roman Shaposhnik <ro...@shaposhnik.org>.
On Tue, Jul 12, 2016 at 6:21 PM, Xiang Sheng <xs...@pivotal.io> wrote:
> Agree . @xunzhang.
> However , some greenplum strings can be easily replaced , but there are too
> many in the code or comments. Changing all of them costs too much efforts.
>
> So changing the strings that users can see is enough.
Huge +1 to this! Btw, is this something we may be able to tackle in our
next Apache release?
Thanks,
Roman.
Re: Rename "greenplum" to "hawq"
Posted by Xiang Sheng <xs...@pivotal.io>.
Agree . @xunzhang.
However , some greenplum strings can be easily replaced , but there are too
many in the code or comments. Changing all of them costs too much efforts.
So changing the strings that users can see is enough.
On Tue, Jul 12, 2016 at 7:31 PM, Gmail <xu...@gmail.com> wrote:
> Hi hawq developers,
>
> I am a little confused with the greenplum strings(code, file, comment)
> inside hawq code base. Does these codes still rely on upstream gpdb? If
> not, could it possible to rename them with "hawq"?
>
> Also, if these strings are left, as a developer, sometimes I think that
> the bugs in that forked version of greenplum might also be a issue in
> latest HAWQ. Another uncomfortable experience is that before running HAWQ,
> users should source "greenplum.sh".
>
> Best
> xunzhang
>
>
> Send from my iPhone
--
Best Regards,
Xiang Sheng