[GitHub] janpio commented on a change in pull request #572: Resolve issue with plugin target-dir "app*" subdirectories such as "appco"

[GitBox <gi...@apache.org>]

janpio commented on a change in pull request #572: Resolve issue with plugin target-dir "app*" subdirectories such as "appco"
URL: https://github.com/apache/cordova-android/pull/572#discussion_r235709037
 
 

 ##########
 File path: spec/unit/pluginHandlers/handlers.spec.js
 ##########
 @@ -163,6 +163,12 @@ describe('android project handler', function () {
                     'src/android/jniLibs/x86/libnative.so', temp,
                     path.join('app/src/main/jniLibs/x86/libnative.so'), false);
             });
+
+            it('Test#006j : should allow installing sources with target-dir that includes "appco"', function () {
 
 Review comment:
   The bug was that it included `app`, right?
   ```suggestion
               it('Test#006j : should allow installing sources with target-dir that includes "app"', function () {
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org