You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/01/15 12:26:49 UTC
[GitHub] [incubator-mxnet] leezu opened a new pull request #17324:
USE_JEMALLOC=OFF by default
leezu opened a new pull request #17324: USE_JEMALLOC=OFF by default
URL: https://github.com/apache/incubator-mxnet/pull/17324
## Description ##
As of jemalloc 5, jemalloc default build can not be used in libraries that are dlopened. However, libmxnet.so is dlopened by Python (ctypes). To use MXNet with jemalloc 5, users must not to system libjemalloc.so but must rather link to a libjemalloc compiled with special parameters to allow dlopen to work.
jemalloc 5 is distributed as part of Ubuntu 18.10 and higher, as well as Debian Stable. Users on these systems will be unable to compile MXNet with USE_JEMALLOC=ON.
An alternative is to build jemalloc as part of our build. See https://github.com/apache/incubator-mxnet/pull/17121 for an implementation. Given the lack of review of https://github.com/apache/incubator-mxnet/pull/17121 and the reliance of a patched jemalloc version to allow integration into our build, let's first proceed with the current PR.
### Changes ###
- [X] Change USE_JEMALLOC default to OFF
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] leezu merged pull request #17324:
USE_JEMALLOC=OFF by default
Posted by GitBox <gi...@apache.org>.
leezu merged pull request #17324: USE_JEMALLOC=OFF by default
URL: https://github.com/apache/incubator-mxnet/pull/17324
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] ChaiBapchya commented on issue #17324:
USE_JEMALLOC=OFF by default
Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on issue #17324: USE_JEMALLOC=OFF by default
URL: https://github.com/apache/incubator-mxnet/pull/17324#issuecomment-575959917
Should this be brought to the notice of dev community? I remember when certain build flag (MKLDNN/Large tensor) is to be toggled, it's discussed first.
On other side, since this one toggles it off so I guess we can go ahead..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] leezu commented on issue #17324: USE_JEMALLOC=OFF
by default
Posted by GitBox <gi...@apache.org>.
leezu commented on issue #17324: USE_JEMALLOC=OFF by default
URL: https://github.com/apache/incubator-mxnet/pull/17324#issuecomment-575988051
Thanks, I will send a mail to dev.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services